adb08e892b
Each plugin currently uses its own recursive AST run, which adds up. This patch adds another shared plugin which internally contains all (suitable) plugins and dispatches to them from the same one recursive run. This patch converts ~25 plugins and for starmath's accessibility.cxx reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any plugins). As there are almost 50 more plugins to go, this can theoretically result in 4.56s final time, although probably not all plugins can be that easily converted, if at all. This mostly requires very little change in many plugins (see e.g. BadStatics), some even work without any functionality change (e.g. CharRightShift). Traverse* calls require some changes but are often not that difficult. WalkUp* probably can't be supported, although some plugins can(?) possibly be adjusted to not rely on them. And of course some plugins can be left as they are, using their own recursive run. See description at the top of generator.cxx for description of how to convert a plugin. The sharedvisitor.cxx source is generated based on scanning relevant plugin sources using a clang-based scanner/generator. The generated source is intentionally included instead of getting always generated, as the generating currently takes some time, so it should get updated in git whenever a change in a plugin triggers a source change in it. Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01 Reviewed-on: https://gerrit.libreoffice.org/68026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
94 lines
2.5 KiB
C++
94 lines
2.5 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#ifndef LO_CLANG_SHARED_PLUGINS
|
|
|
|
#include <cassert>
|
|
#include <string>
|
|
#include <iostream>
|
|
#include <fstream>
|
|
#include <set>
|
|
#include "plugin.hxx"
|
|
|
|
/**
|
|
Check for places where we do
|
|
if (xxx) ;
|
|
or
|
|
if (xxx) {}
|
|
*/
|
|
namespace
|
|
{
|
|
class EmptyIf : public loplugin::FilteringRewritePlugin<EmptyIf>
|
|
{
|
|
public:
|
|
explicit EmptyIf(loplugin::InstantiationData const& data)
|
|
: FilteringRewritePlugin(data)
|
|
{
|
|
}
|
|
|
|
virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
|
|
|
|
bool VisitIfStmt(IfStmt const*);
|
|
|
|
private:
|
|
bool ContainsComment(Stmt const*);
|
|
};
|
|
|
|
static bool empty(Stmt const* stmt)
|
|
{
|
|
if (isa<NullStmt>(stmt))
|
|
return true;
|
|
auto compoundStmt = dyn_cast<CompoundStmt>(stmt);
|
|
if (!compoundStmt)
|
|
return false;
|
|
return compoundStmt->size() == 0;
|
|
}
|
|
|
|
bool EmptyIf::ContainsComment(Stmt const* stmt)
|
|
{
|
|
auto range = stmt->getSourceRange();
|
|
SourceManager& SM = compiler.getSourceManager();
|
|
SourceLocation startLoc = range.getBegin();
|
|
SourceLocation endLoc = range.getEnd();
|
|
char const* p1 = SM.getCharacterData(startLoc);
|
|
char const* p2 = SM.getCharacterData(endLoc);
|
|
p2 += Lexer::MeasureTokenLength(endLoc, SM, compiler.getLangOpts());
|
|
auto s = llvm::StringRef(p1, p2 - p1);
|
|
return s.find("//") != llvm::StringRef::npos || s.find("/*") != llvm::StringRef::npos
|
|
|| s.find("#if") != llvm::StringRef::npos;
|
|
}
|
|
|
|
bool EmptyIf::VisitIfStmt(IfStmt const* ifStmt)
|
|
{
|
|
if (ignoreLocation(ifStmt))
|
|
return true;
|
|
|
|
if (ifStmt->getElse() && empty(ifStmt->getElse()) && !ContainsComment(ifStmt->getElse()))
|
|
{
|
|
report(DiagnosticsEngine::Warning, "empty else body",
|
|
compat::getBeginLoc(ifStmt->getElse()))
|
|
<< ifStmt->getElse()->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
if (!ifStmt->getElse() && empty(ifStmt->getThen()) && !ContainsComment(ifStmt->getThen()))
|
|
{
|
|
report(DiagnosticsEngine::Warning, "empty if body", compat::getBeginLoc(ifStmt))
|
|
<< ifStmt->getSourceRange();
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
loplugin::Plugin::Registration<EmptyIf> emptyif("emptyif", true);
|
|
}
|
|
|
|
#endif // LO_CLANG_SHARED_PLUGINS
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|