office-gobmx

History

Stephan Bergmann ad0779ed5e Handle uno_threadpool_dispose in parallel with uno_threadpool_putJob While tracking down the issue discussed in the commit message of `78dc7d982b` "Remove a potentially already enqueued response when a bridge is disposed", it occurred to me that there should be a race in those uno_threadpool_putJob( bridge_->getThreadPool(), ...); calls in binaryurp/source/reader.cxx, when the bridge gets disposed (through some other thread) between the time the bridge_->getThreadPool() call checks for the bridge being disposed (in which case it would throw a DisposedException) and the actual uno_threadpool_putJob call. I tried to catch that with a previous incarnation of this change (<https://gerrit.libreoffice.org/c/core/+/96120/1> "Jenkins Slides Through the Tiny Window"), but couldn't---presumably because this race would be very rare after all, and the issue I was chasing turned out to be caused by something different anyway. Nevertheless, I wanted to address this potential race now. We can only reliably check for disposed'ness after having locked ThreadPool's m_mutex in uno_threadpool_putJob -> ThreadPool::addJob, but at which time we can no longer indicate this condition to the caller---uno_threapool_putJob is part of the stable URE interface, has a void return type, and should not throw any exceptions as it is a C function. However, if the bridge gets disposed, any threads that would wait for this job (in cppu_threadpool::JobQueue::enter, either from cppu_threadpool::ORequestThread::run waiting to process new incoming calls, or from a bridge's call to uno_threadpool_enter waiting for a respose to an outgoing call) should already learn about the bridge being disposed by falling out of cppu_threadpool::JobQueue::enter with a null return value. So it should be OK if uno_threadpool_putJob silently discards the job in that case. Change-Id: I36fe996436f55a93d84d66cc0b164e2e45a37e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96120 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>		2020-06-26 10:43:40 +02:00
..
qa
source	Handle uno_threadpool_dispose in parallel with uno_threadpool_putJob	2020-06-26 10:43:40 +02:00
util
CppunitTest_cppu_any-external.mk
CppunitTest_cppu_qa_any.mk
CppunitTest_cppu_qa_recursion.mk
CppunitTest_cppu_qa_reference.mk
CppunitTest_cppu_qa_unotype.mk
CppunitTest_cppu_test_cppumaker.mk
CppunitTest_cppu_typelib.mk
InternalUnoApi_cppu_qa_cppumaker_types.mk
InternalUnoApi_cppu_qa_types.mk
IwyuFilter_cppu.yaml
Library_affine_uno_uno.mk
Library_cppu.mk
Library_log_uno_uno.mk
Library_purpenvhelper.mk
Library_unsafe_uno_uno.mk
Makefile
Module_cppu.mk
README

README

Type definitions/implementations for the core of UNO. The exported API is in C.

See also:
[http://wiki.openoffice.org/wiki/Uno/Binary/Modules/CPPU]