The oslSocketSet/osl_*SocketSet/osl_demultiplexSocketEvents functionality is
based on the POSIX fd_set/FD_*/select functionality, which suffers from the
issue that it has undefined behavior for file descriptors with numerical values
greater than or equal to FD_SETSIZE. (And this can be a real issue e.g. on
Linux, where tools::extendApplicationEnvironment in
tools/source/misc/extendapplicationenvironment.cxx bumps the soft RLIMIT_NOFILE
to the hard limit---so that file descriptors can likely have large values---,
but where the GNU C library sets FD_SETSIZE to only 1024 and ignores larger
descriptors.)
This functionality is unused at least by LO itself, and also likely unused by
third-party code. So instead of fixing the Unix-based implementation in
sal/osl/unx/socket.cxx (by e.g. switching it from select to poll), just mark the
functionality as deprecated (with the option of eventually removing the
functionality completely from sal/osl/{unx,w32}/socket.cxx, leaving just stubs
in sal/osl/all/compat.cxx).
Change-Id: I2b97f8a37b45f298da9328660006f3c14361c9a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116089
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
0a126b4c66