313081c070
This is maybe a Qt bug. Calling QClipboard::setMimeData from Qt5Clipboard::setContents after a previous call to QClipboard::clear results in a clipboard ownership failure. In a terminal you'll see: "QXcbClipboard::setMimeData: Cannot set X11 selection owner". Calling Application::Reschedule() after the clear() doesn't help. The result is a de-sync between the LO's clipboard state and the real clipboard state, which will lead to a crash on LO shutdown. I'm not sure this fix is correct. Maybe this could also be handled by some X11 flush operation. But it's the only working solution I could find: don't clear, if LO re-claims the ownership later. I tried to reproduce the ownership error by modifying the Qt fridgemagnets example, adding some QClipboard::clear and QClipboard::setMimeData calls to the drop handling, but couldn't reproduce. Maybe the dynamic Qt5MimeData object is also involved. Change-Id: I32b6575a78a4b10a2e2b7b189303ab3a40dc69ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90990 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
97 lines
3.9 KiB
C++
97 lines
3.9 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <com/sun/star/lang/XServiceInfo.hpp>
|
|
#include <com/sun/star/datatransfer/XTransferable.hpp>
|
|
#include <com/sun/star/datatransfer/clipboard/XSystemClipboard.hpp>
|
|
#include <com/sun/star/datatransfer/clipboard/XFlushableClipboard.hpp>
|
|
#include <com/sun/star/datatransfer/clipboard/XClipboardOwner.hpp>
|
|
#include <com/sun/star/datatransfer/clipboard/XClipboardListener.hpp>
|
|
#include <cppuhelper/compbase.hxx>
|
|
|
|
#include <QtGui/QClipboard>
|
|
|
|
/**
|
|
* This implementation has two main functions, which handle the clipboard content:
|
|
* the XClipboard::setContent function and the QClipboard::change signal handler.
|
|
*
|
|
* The first just sets the respective clipboard to the expected content from LO,
|
|
* the latter will handle any reported changes.
|
|
**/
|
|
class Qt5Clipboard final
|
|
: public QObject,
|
|
public cppu::WeakComponentImplHelper<css::datatransfer::clipboard::XSystemClipboard,
|
|
css::datatransfer::clipboard::XFlushableClipboard,
|
|
css::lang::XServiceInfo>
|
|
{
|
|
Q_OBJECT
|
|
|
|
osl::Mutex m_aMutex;
|
|
const OUString m_aClipboardName;
|
|
const QClipboard::Mode m_aClipboardMode;
|
|
// has to be set, if LO changes the QClipboard itself, so it won't instantly lose
|
|
// ownership by it's self-triggered QClipboard::changed handler
|
|
bool m_bOwnClipboardChange;
|
|
// true, if LO really wants to give up clipboard ownership
|
|
bool m_bDoClear;
|
|
|
|
// if not empty, this holds the setContents provided XTransferable or a Qt5ClipboardTransferable
|
|
css::uno::Reference<css::datatransfer::XTransferable> m_aContents;
|
|
// the owner of the current contents, which must be informed on content change
|
|
css::uno::Reference<css::datatransfer::clipboard::XClipboardOwner> m_aOwner;
|
|
std::vector<css::uno::Reference<css::datatransfer::clipboard::XClipboardListener>> m_aListeners;
|
|
|
|
static bool isOwner(const QClipboard::Mode aMode);
|
|
static bool isSupported(const QClipboard::Mode aMode);
|
|
|
|
explicit Qt5Clipboard(const OUString& aModeString, const QClipboard::Mode aMode);
|
|
|
|
private Q_SLOTS:
|
|
void handleChanged(QClipboard::Mode mode);
|
|
void handleClearClipboard();
|
|
|
|
signals:
|
|
void clearClipboard();
|
|
|
|
public:
|
|
// factory function to construct only valid Qt5Clipboard objects by name
|
|
static css::uno::Reference<css::uno::XInterface> create(const OUString& aModeString);
|
|
|
|
// XServiceInfo
|
|
virtual OUString SAL_CALL getImplementationName() override;
|
|
virtual sal_Bool SAL_CALL supportsService(const OUString& ServiceName) override;
|
|
virtual css::uno::Sequence<OUString> SAL_CALL getSupportedServiceNames() override;
|
|
|
|
// XClipboard
|
|
virtual css::uno::Reference<css::datatransfer::XTransferable> SAL_CALL getContents() override;
|
|
virtual void SAL_CALL setContents(
|
|
const css::uno::Reference<css::datatransfer::XTransferable>& xTrans,
|
|
const css::uno::Reference<css::datatransfer::clipboard::XClipboardOwner>& xClipboardOwner)
|
|
override;
|
|
virtual OUString SAL_CALL getName() override;
|
|
|
|
// XClipboardEx
|
|
virtual sal_Int8 SAL_CALL getRenderingCapabilities() override;
|
|
|
|
// XFlushableClipboard
|
|
virtual void SAL_CALL flushClipboard() override;
|
|
|
|
// XClipboardNotifier
|
|
virtual void SAL_CALL addClipboardListener(
|
|
const css::uno::Reference<css::datatransfer::clipboard::XClipboardListener>& listener)
|
|
override;
|
|
virtual void SAL_CALL removeClipboardListener(
|
|
const css::uno::Reference<css::datatransfer::clipboard::XClipboardListener>& listener)
|
|
override;
|
|
};
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|