1520d0d6f3
mostly missing explicit before ctors and uninitialized member vars one odd use of std::find > compilerplugins/clang/implicitboolconversion.cxx > 800 stlIfFind warning Suspicious condition. > The result of find() is an iterator, but it is not properly checked. Change-Id: Iade53494cd7fe8ddb0e110e431449ae5a517fe3b Reviewed-on: https://gerrit.libreoffice.org/24398 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
67 lines
1.6 KiB
C++
67 lines
1.6 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* Based on LLVM/Clang.
|
|
*
|
|
*/
|
|
#include "plugin.hxx"
|
|
#include "compat.hxx"
|
|
/*
|
|
This is a compile check.
|
|
|
|
Warns about functions with static keyword in an unnamed namespace.
|
|
*/
|
|
|
|
namespace loplugin
|
|
{
|
|
|
|
class StaticAnonymous
|
|
: public RecursiveASTVisitor< StaticAnonymous >
|
|
, public Plugin
|
|
{
|
|
public:
|
|
explicit StaticAnonymous( const InstantiationData& data );
|
|
virtual void run() override;
|
|
bool VisitFunctionDecl( FunctionDecl* func );
|
|
|
|
};
|
|
|
|
StaticAnonymous::StaticAnonymous( const InstantiationData& data )
|
|
: Plugin( data )
|
|
{
|
|
}
|
|
|
|
void StaticAnonymous::run()
|
|
{
|
|
TraverseDecl( compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
|
|
|
|
bool StaticAnonymous::VisitFunctionDecl( FunctionDecl* func )
|
|
|
|
{
|
|
if( ignoreLocation( func ) )
|
|
return true;
|
|
if( func -> isInAnonymousNamespace () )
|
|
{
|
|
if ( !isa<CXXMethodDecl>(func) && !compat::isInExternCContext(*func) )
|
|
{
|
|
if(func-> getStorageClass() == SC_Static)
|
|
{
|
|
report( DiagnosticsEngine::Warning,
|
|
"redundant 'static' keyword in unnamed namespace",
|
|
func->getLocStart());
|
|
}
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
// Register the plugin action with the LO plugin handling.
|
|
static Plugin::Registration< StaticAnonymous > X( "staticanonymous",true);
|
|
|
|
} // namespace
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|