09df48f87f
moNeedsClearRedo is an implementation detail,
so there should not be public functions for it.
Plus, NeedsClearRedo can be called either against
the CurrentLevel stack or the TopLevel stack
(whatever that implies - there is no documentation...)
and since it is a delayed call that means that
multiple NeedsClearRedo attempts could be made,
theoretically against both stacks.
My initial implementation was "last one wins",
(which may very well prove to be the best one)
but whatever happens, it should be clearly intentional.
Based on my limited skill at code reading,
it sounds like CurrentLevel might be more of an implemention detail
or a temporary expansion of a ListUndoAction,
so I am guessing that any request for TopLevel clearing
should be given priority.
For Writer, it is always clearing the TopLevel stack
sw/source/core/undo/docundo.cxx: ClearRedo()
return SdrUndoManager::ImplClearRedo_NoLock(TopLevel);
Change-Id: I195aefb696599f018712135a2e015549d534791f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171984
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Justin Luth <jluth@mail.com>
|
||
|---|---|---|
| .. | ||
| adrparse.hxx | ||
| asiancfg.hxx | ||
| broadcast.hxx | ||
| cenumitm.hxx | ||
| cintitem.hxx | ||
| cjkoptions.hxx | ||
| converter.hxx | ||
| cryptosign.hxx | ||
| ctloptions.hxx | ||
| currencytable.hxx | ||
| documentlockfile.hxx | ||
| eitem.hxx | ||
| filenotation.hxx | ||
| flagitem.hxx | ||
| fstathelper.hxx | ||
| globalnameitem.hxx | ||
| grabbagitem.hxx | ||
| gridprinter.hxx | ||
| hint.hxx | ||
| ilstitem.hxx | ||
| imageitm.hxx | ||
| IndexedStyleSheets.hxx | ||
| inethist.hxx | ||
| inettype.hxx | ||
| instrm.hxx | ||
| int64item.hxx | ||
| intitem.hxx | ||
| itemiter.hxx | ||
| itempool.hxx | ||
| itemprop.hxx | ||
| itemset.hxx | ||
| languageoptions.hxx | ||
| lckbitem.hxx | ||
| legacyitem.hxx | ||
| listener.hxx | ||
| lngmisc.hxx | ||
| lockfilecommon.hxx | ||
| lstner.hxx | ||
| macitem.hxx | ||
| memberid.h | ||
| metitem.hxx | ||
| msodocumentlockfile.hxx | ||
| nfengine.hxx | ||
| nfkeytab.hxx | ||
| nfsymbol.hxx | ||
| numformat.hxx | ||
| numuno.hxx | ||
| ondemand.hxx | ||
| outstrm.hxx | ||
| ownlist.hxx | ||
| PasswordHelper.hxx | ||
| pickerhistoryaccess.hxx | ||
| poolitem.hxx | ||
| ptitem.hxx | ||
| rectitem.hxx | ||
| rngitem.hxx | ||
| setitem.hxx | ||
| SfxBroadcaster.hxx | ||
| sharecontrolfile.hxx | ||
| sharedstring.hxx | ||
| sharedstringpool.hxx | ||
| sigstruct.hxx | ||
| slstitm.hxx | ||
| solar.hrc | ||
| srchdefs.hxx | ||
| srchitem.hxx | ||
| stritem.hxx | ||
| style.hxx | ||
| stylepool.hxx | ||
| stylesheetuser.hxx | ||
| svdde.hxx | ||
| svl.hrc | ||
| svldllapi.h | ||
| svlresid.hxx | ||
| typedwhich.hxx | ||
| undo.hxx | ||
| urihelper.hxx | ||
| urlbmk.hxx | ||
| visitem.hxx | ||
| voiditem.hxx | ||
| whichranges.hxx | ||
| whiter.hxx | ||
| zforlist.hxx | ||
| zformat.hxx | ||