7cec59402d
ODF 1.4 has removed the attribute table:cell-range-address from the chart:plot-area element. So we may write it only in versions < 1.4. The attribute was used to distinguish whether a chart has internal data. The same information is given by the href attribute of the chart:chart element. The actual used cell-range-address values are already given in the chart:axis and chart:series child elements and evaluated from there. A global setting is not needed. The attributes chart:data-source-has-labels, chart:column-mapping and chart:row-mapping are related to the table:cell-range-address attribute. These three attributes are deprecated already in ODF 1.2. Thus we will not write them in ODF 1.4. Their information is given in the chart:axis and chart:series child elements. The order of series is given by the order of the chart:series child elements. Change-Id: I08886723b1c8eb27489a7f44b5f8321572defdff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177323 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de> |
||
|---|---|---|
| .. | ||
| libreoffice | ||
| mathml2 | ||
| odf1.0 | ||
| odf1.1 | ||
| odf1.2 | ||
| odf1.3 | ||
| odf1.4 | ||
| README.md | ||
Schemas for Validating ODF Files
Schemas that can be used for validating ODF files
subdirs:
mathml2: W3C MathML 2.0 XML Schema (needed for Math embedded objects)odf1.0,odf1.1,odf1.2: official OASIS RelaxNG schemasodf1.3: current OASIS draft ODF 1.3 RelaxNG schemalibreoffice: draft ODF schema, with additional LO extensions
The extension schema in libreoffice/ is used by all unit tests if
--with-export-validation is given, which is the default.
Notably this means that if you add a new feature to the ODF filters and you add the required unit test for the new feature, then most likely the test will fail with a complaint from the validator; in this case the schema needs to be updated to contain the new elements and attributes.
The extension schema uses the RelaxNG "include" feature to refer to the ODF
schema; this means that it only contains those parts of the schema that
actually need to be changed - this works well in many cases because the ODF
schema is quite well structured with many named patterns, but unfortunately
there are a few places where that isn't the case and large chunks needed to be
copied to override them.
In the easy case, to add an attribute you just want to search for the
corresponding element, which will have a "foo-attlist" named pattern, and then
add another attribute like this:
<rng:define name="draw-enhanced-geometry-attlist" combine="interleave"> rng:optional <rng:attribute name="drawooo:sub-view-size"> <rng:ref name="string"/> </rng:attribute> </rng:optional> </rng:define>
Currently only the features that are actually exported in the unit tests have been added to the schema; there is still some work to do here to add everything; the crashtesting script also does ODF validation of all files and now also uses the custom schema.
Unfortunately it turned out that there are a lot of extensions already for which no proposal exists [1], and in many cases not even an entry on the Wiki [2], so clearly something like this extension schema is needed.
[1] git grep TODO schema/libreoffice