546e7d14b3
Applying a numbering style to text causes export to save that out as a number (valued as zero). That is not good because the ODF spec says that a number overrides a string. So don't accept a numbering format on non-number text. Why is this change good? -the cell previously had no direct formatting (by definition). -the cell's previous old format was text (tested). -any numbering format applied obviously isn't correct (by definition). -any previous formatting has already been overwritten with numformat. -the default numbering is appropriate for text. -empty cells still get the numbering format (tested). -odd human-designed formats are accepted as intentional (tested). What are the concerns? -the scope of this change is HUGE, way beyond this bug. -on both my dev box and patch box I saw occassional crashes. -the bug was "fixed" by a different import commit that ensured different languages were treated consistently. So this patch is no longer critical, just nice to have to avoid exporting out-of-spec content. Change-Id: Id3dc5f803c3cf4875bc0cab52d1019a18679da77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123904 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Eike Rathke <erack@redhat.com> |
||
---|---|---|
.. | ||
inc/pch | ||
qa | ||
source | ||
unx/source/svdde | ||
util | ||
AllLangMoTarget_svl.mk | ||
CppunitTest_svl_adrparse.mk | ||
CppunitTest_svl_inetcontenttype.mk | ||
CppunitTest_svl_itempool.mk | ||
CppunitTest_svl_items.mk | ||
CppunitTest_svl_lngmisc.mk | ||
CppunitTest_svl_lockfiles.mk | ||
CppunitTest_svl_notify.mk | ||
CppunitTest_svl_qa_cppunit.mk | ||
CppunitTest_svl_urihelper.mk | ||
IwyuFilter_svl.yaml | ||
JunitTest_svl_complex.mk | ||
Library_fsstorage.mk | ||
Library_passwordcontainer.mk | ||
Library_svl.mk | ||
Makefile | ||
Module_svl.mk | ||
README.md |
Non-Graphical Helper Code (svtools light)
Contains non-graphical helper code for office applications.
Specifically this module does not depend on or use includes from module vcl. Originally all code in svtools that did not depend on vcl was split off into this svl ("svtools light") module.
In particular the SfxItemSet
is a property-bag like container that
stores arbitrary sets of properties for everything from text run
formats, to Chart regression line properties.
There are lots of other useful helpers in here for various office
tasks; much of this code was originally moved from svx/sfx2
.
Items, Pools and Sets
SfxPoolItem
A small reference counted piece of data. Many subclasses, each with a
unique integer to identify its type (WhichId
). Can be compared for equality
(operator==
), Clone()
d, and converted to/from uno::Any
(QueryValue/PutValue
).
A pool item may have value semantics ("poolable"), meaning that
there will generally be only one instance that compares equal per item pool,
or not, in which case the item will be Clone()
d quite a bit.
SfxItemPool
Usually there is one item pool per document, with a range of valid WhichId
s
that is specific to the type of document.
The item pool owns all instances of SfxPoolItem
or its subclasses that have
ever been added to an item set. It also contains a default item for
every WhichId, which will be (depending on parameters) returned from item
sets if the set does not contain an item at this WhichId
.
SfxItemSet
The item set can be created with a user-supplied range of WhichId
s; it
will accept SfxPoolItems
with matching WhichId
s and ignore attempts to
insert items with non-matching WhichId
s.
Items that are successfully inserted into the set will be stored in the
set's SfxItemPool
, and for poolable items only a single instance that
compares equal under the predicate operator==
will be stored in the pool,
regardless of how many sets contain it, thus conserving memory.
There are members m_pWhichRanges
for the valid ranges (as pairs of WhichId
s),
m_nCount
for the number of items contained, and m_pItems
for the pointers to
the actual items.