85fd526fc6
The mechanism is currently broken because it uses hash values as keys, in two different places. But hash values are not required to be unique, and as soon as there are enough items of a given type, a collision is inevitable. So just simplify this whole mechanism. There is no reason we need type-specific item managers. Stuff everything into a single global pool, that uses hashing correctly. Notes (*) Performance, as far as I can tell, is the same or slightly better. (*) I removed the NUMBER_OF_UNSHARED_INSTANCES thing, in favour of just having a simpler mechanism Change-Id: I9068baf9bf6fae2500ae5748c6d1aabe6c3a18a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169709 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins |
||
---|---|---|
.. | ||
inc | ||
qa | ||
source | ||
uiconfig/ui | ||
AllLangMoTarget_editeng.mk | ||
CppunitTest_editeng_borderline.mk | ||
CppunitTest_editeng_core.mk | ||
CppunitTest_editeng_editeng.mk | ||
CppunitTest_editeng_lookuptree.mk | ||
CustomTarget_generated.mk | ||
IwyuFilter_editeng.yaml | ||
Library_editeng.mk | ||
Makefile | ||
Module_editeng.mk | ||
README.md | ||
UIConfig_editeng.mk |
Edit Engine
In OpenOffice.org build DEV300m72 this module was split off from svx
but it
has no dependencies on svx
(nor on sfx2
) while in turn svx
depends on editeng
Read more in the mailing list post: http://www.mail-archive.com/dev@openoffice.org/msg13237.html
If you build LibreOffice with dbgutil
, you have some extended debug keys:
- Ctrl+Alt+F1 - draws the paragraph rectangles in different colors
- Ctrl+Alt+F11 - toggles dumping the edit engine state to the "editenginedump.log" on draw
- Ctrl+Alt+F12 - dumps the current edit engine state to "editenginedump.log"