office-gobmx/include/tools
Tomaž Vajngerl 8ca89dc44a fix reseting WeakReference when moving a ref to another ref.
In ViewIteratorImpl::Reverse we std::move a reference, to a local
variable, however the reference was not reset correctly, which
caused a crash.

The issue is that a mpWeakConnection in WeakReference always
needs to be non-null as shown in reset(reference_type* pReference)
method. In the move constructor of WeakReference, we just std::move
the reference like:

mpWeakConnection = std::move(rWeakRef.mpWeakConnection);

This means rWeakRef.mpWeakConnection will be reset to null, which
is not what is expected, so what is missing is to instantiate
rWeakRef.mpWeakConnection by calling reset(nullptr) or using the
added reset() method.

This also adds a test for LOKit PDF search as this is the case
where the crash has been reproduced. It happens because of a
call to:

... std::move(maPosition.mxObject);

in the method ViewIteratorImpl::Reverse()

Change-Id: I43692554ba4f6231d00091269b7c902ab5cbc11f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95995
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-10 15:58:16 +02:00
..
b3dtrans.hxx
bigint.hxx
color.hxx
config.hxx
contnr.hxx
cpuid.hxx
date.hxx
datetime.hxx
datetimeutils.hxx
debug.hxx
diagnose_ex.h
extendapplicationenvironment.hxx
fileutil.hxx
fldunit.hxx
fontenum.hxx
fract.hxx
gen.hxx
GenericTypeSerializer.hxx
globname.hxx
helpers.hxx
inetmime.hxx
inetmsg.hxx
inetstrm.hxx
line.hxx
lineend.hxx
link.hxx
mapunit.hxx
multisel.hxx
pathutils.hxx
poly.hxx
ref.hxx
resary.hxx
simd.hxx
simdsupport.hxx
solar.h
stream.hxx
svborder.hxx
svlibrary.h
tenccvt.hxx
time.hxx
toolsdllapi.h
UnitConversion.hxx vcl: add conversion point to twip int64 & double values 2020-06-01 18:46:13 +02:00
urlobj.hxx
vcompat.hxx
weakbase.h fix reseting WeakReference when moving a ref to another ref. 2020-06-10 15:58:16 +02:00
weakbase.hxx fix reseting WeakReference when moving a ref to another ref. 2020-06-10 15:58:16 +02:00
wintypes.hxx
wldcrd.hxx
XmlWalker.hxx
XmlWriter.hxx
zcodec.hxx