Test repository to check push and ssh key
Find a file
Noel Grandin 8cea437301 simplify code
These methods are virtual, so the check does nothing useful.
Possibly back when this code was introduced, the methods were not.

This was introduced in
    commit 411f66186e
    Date:   Mon Jan 31 07:58:15 2005 +0000
    INTEGRATION: CWS vcl34 (1.49.26); FILE MERGED
2005/01/06 14:13:03 ssa 1.49.26.1: #i37461# get/setOutputsize has to
check for DockingWindow to call proper method

to solve
    https://bz.apache.org/ooo/show_bug.cgi?id=37461

I have checked, and the bug does not come back.

Change-Id: I540b85eccbf7107ee640f09b41340dc906995557
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90795
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-21 08:07:34 +01:00
.git-hooks
.github
accessibility Revert "loplugin:constfields in svtools" 2020-03-13 19:20:38 +01:00
android android: Pass Intent's action in ctor already 2020-03-13 22:01:25 +01:00
animations
apple_remote
avmedia
basctl The idl __attribute__((__weak__)) hack doesn't seem necessary for --enable-lto 2020-03-20 19:31:11 +01:00
basegfx tdf#130974 replace rtl::math::isSignBitSet with std::signbit. 2020-03-14 09:10:34 +01:00
basic tdf#130977 replace rtl::math::isFinite with std::isfinite. 2020-03-12 10:34:46 +01:00
bean
bin
binaryurp
bridges
canvas tdf#130977 replace rtl::math::isFinite with std::isfinite. 2020-03-12 10:34:46 +01:00
chart2 Rename isMobile to isMobilePhone and introduce a separate isTablet 2020-03-20 15:10:48 +01:00
cli_ure
codemaker
comphelper Rename isMobile to isMobilePhone and introduce a separate isTablet 2020-03-20 15:10:48 +01:00
compilerplugins loplugin:redundantpointerops add some more smart pointer types 2020-03-19 09:04:21 +01:00
config_host The idl __attribute__((__weak__)) hack doesn't seem necessary for --enable-lto 2020-03-20 19:31:11 +01:00
configmgr
connectivity MSVC hack to avoid multiply defined symbols 2020-03-20 19:16:26 +01:00
cppcanvas
cppu
cppuhelper Fix typo 2020-03-10 20:43:41 +01:00
cpputools
cui tdf#125440 Allow raising text import dialog for paste 2020-03-11 12:43:44 +01:00
dbaccess fix test dependencies 2020-03-21 07:21:51 +01:00
desktop Rename isMobile to isMobilePhone and introduce a separate isTablet 2020-03-20 15:10:48 +01:00
dictionaries@74d8e82635 Update git submodules 2020-03-17 12:21:16 +01:00
distro-configs
drawinglayer EMF+ tdf#124424 Add support for transparency to LinearGradient and blend points 2020-03-20 08:21:53 +01:00
dtrans
editeng tdf#114441: Convert use of sal_uLong to better integer types 2020-03-20 17:57:09 +01:00
embeddedobj
embedserv -Werror,-Wpointer-to-int-cast (LLVM 10 trunk clang-cl) 2020-03-20 20:48:03 +01:00
emfio tdf#124424 EMF+ Extend test options of SvgLinearGradientPrimitive2D 2020-03-16 16:52:24 +01:00
eventattacher
extensions Silence -Werror,-Wvoid-pointer-to-int-cast (LLVM 10 trunk clang-cl) 2020-03-20 19:15:15 +01:00
external Missing include (Windows --disable-pch; for HFONT) 2020-03-20 21:54:21 +01:00
extras Revert "Resolves tdf#99675: Add BPMN images to the gallery" 2020-03-14 10:22:02 +01:00
filter pdfium: support for pages when using PDF import with pdfium 2020-03-18 09:23:15 +01:00
forms tdf#130974 replace rtl::math::isSignBitSet with std::signbit. 2020-03-14 09:10:34 +01:00
formula Resolves: tdf#131423 Handle Function Wizard max argument count correctly 2020-03-21 00:10:01 +01:00
fpicker Revert "loplugin:constfields in svtools" 2020-03-13 19:20:38 +01:00
framework tdf#127205 call shutdown in terminate, if not exec 2020-03-17 14:04:49 +01:00
helpcompiler
helpcontent2@daf2f20d7b Update git submodules 2020-03-20 23:59:03 +01:00
hwpfilter
i18nlangtag tdf#131297 Add Sundanese [sun-ID] to language list 2020-03-12 15:08:03 +01:00
i18npool sw pad-to-4 numbering: add ODF filter 2020-03-20 21:46:35 +01:00
i18nutil
icon-themes Sukapura: Fix for tdf#131454: Wrong icons for Valid Signature 2020-03-21 07:26:40 +01:00
idl The idl __attribute__((__weak__)) hack doesn't seem necessary for --enable-lto 2020-03-20 19:31:11 +01:00
idlc
include sw pad-to-4 numbering: add doc model, UNO API and layout 2020-03-20 16:58:53 +01:00
instsetoo_native tdf#128281 Increase a checkbox height in Windows installer 2020-03-16 15:36:13 +01:00
io
ios
javaunohelper Fix typo 2020-03-10 20:43:18 +01:00
jurt
jvmaccess
jvmfwk
l10ntools
librelogo
libreofficekit libreofficekit: Use 'gb_Library_set_include' for GTK3_CFLAGS 2020-03-17 15:53:05 +01:00
lingucomponent
linguistic
lotuswordpro
m4
nlpsolver
o3tl
odk
offapi sw pad-to-4 numbering: add doc model, UNO API and layout 2020-03-20 16:58:53 +01:00
officecfg Add option to disallow opening files locked by other users 2020-03-16 08:44:15 +01:00
onlineupdate comparison operators should be const 2020-03-12 11:05:36 +01:00
oovbaapi
oox tdf#42949 Fix IWYU warnings in oox/source/[e-v]*/*cxx 2020-03-20 16:38:16 +01:00
opencl Revert "loplugin:constfields in oox" 2020-03-12 07:31:08 +01:00
osx
package Revert "loplugin:constfields in package..registry" 2020-03-12 08:17:11 +01:00
pch
postprocess tdf#130911: convert image-sort from Perl to Python 2020-03-20 09:52:15 +01:00
pyuno Revert "loplugin:constfields in package..registry" 2020-03-12 08:17:11 +01:00
qadevOOo Fix typo 2020-03-10 20:42:53 +01:00
readlicense_oo update credits 2020-03-11 17:07:33 +01:00
registry Revert "loplugin:constfields in package..registry" 2020-03-12 08:17:11 +01:00
remotebridges
reportbuilder
reportdesign loplugin:redundantpointerops add some more smart pointer types 2020-03-19 09:04:21 +01:00
ridljar
sal Avoid stack overflow in testTdf124815 on Windows 2020-03-16 14:02:00 +01:00
salhelper
sax Revert "loplugin:constfields in reportdesign,sal,sax" 2020-03-12 09:22:20 +01:00
sc The idl __attribute__((__weak__)) hack doesn't seem necessary for --enable-lto 2020-03-20 19:31:11 +01:00
scaddins tdf#130975 replace rtl::math::isNan with std::isnan. 2020-03-14 09:19:00 +01:00
sccomp Revert "loplugin:constfields in scaddins,sccomp" 2020-03-12 17:44:30 +01:00
schema
scp2 Revert "Resolves tdf#99675: Add BPMN images to the gallery" 2020-03-14 10:22:02 +01:00
scripting Revert "loplugin:constfields in scripting" 2020-03-12 09:22:31 +01:00
sd -Werror,-Wvoid-pointer-to-int-cast (LLVM 10 trunk clang-cl) 2020-03-20 19:15:52 +01:00
sdext Revert "loplugin:constfields in sdext" 2020-03-12 09:34:21 +01:00
setup_native
sfx2 The idl __attribute__((__weak__)) hack doesn't seem necessary for --enable-lto 2020-03-20 19:31:11 +01:00
shell Fix passing RT_RCDATA into FindResourceW 2020-03-20 19:14:43 +01:00
slideshow Revert "loplugin:constfields in slideshow" 2020-03-12 19:44:42 +01:00
smoketest Revert "loplugin:constfields in smoketest..sot" 2020-03-12 19:43:04 +01:00
solenv tdf#130911: convert image-sort from Perl to Python 2020-03-20 09:52:15 +01:00
soltools Revert "loplugin:constfields in smoketest..sot" 2020-03-12 19:43:04 +01:00
sot Revert "loplugin:constfields in smoketest..sot" 2020-03-12 19:43:04 +01:00
starmath loplugin:redundantpointerops add some more smart pointer types 2020-03-19 09:04:21 +01:00
stoc Revert "loplugin:constfields in stoc..svgio" 2020-03-14 07:54:02 +01:00
store Revert "loplugin:constfields in stoc..svgio" 2020-03-14 07:54:02 +01:00
svgio Revert "loplugin:constfields in stoc..svgio" 2020-03-14 07:54:02 +01:00
svl tdf#130974 replace rtl::math::isSignBitSet with std::signbit. 2020-03-14 09:10:34 +01:00
svtools Revert "loplugin:constfields in svtools" 2020-03-13 19:20:38 +01:00
svx Rename isMobile to isMobilePhone and introduce a separate isTablet 2020-03-20 15:10:48 +01:00
sw sw pad-to-4 numbering: add DOCX filter 2020-03-20 22:37:47 +01:00
swext
sysui
test tdf#130975 replace rtl::math::isNan with std::isnan. 2020-03-14 09:19:00 +01:00
testtools Revert "loplugin:constfields in sw" 2020-03-13 15:41:42 +01:00
toolkit simplify code 2020-03-21 08:07:34 +01:00
tools Revert "loplugin:constfields in tools" 2020-03-15 16:28:03 +01:00
translations@7b4a46ae14 Update git submodules 2020-03-16 13:16:32 +01:00
ucb Revert "loplugin:constfields in ucb" 2020-03-15 16:29:08 +01:00
ucbhelper Revert "loplugin:constfields in ucbhelper" 2020-03-15 16:28:14 +01:00
udkapi
uitest uitest: use hex instead of int for colors 2020-03-16 22:02:39 +01:00
UnoControls Revert "loplugin:constfields in ucbhelper" 2020-03-15 16:28:14 +01:00
unodevtools
unoidl Revert "loplugin:constfields in unoidl" 2020-03-15 16:28:50 +01:00
unoil
unotest
unotools tdf#131069 always produce utf-8 from gettext 2020-03-18 12:40:43 +01:00
unoxml Revert "loplugin:constfields in unotools..uui" 2020-03-16 08:21:14 +01:00
ure
uui use SolarMutexReleaser in UUIInteractionHelper 2020-03-19 13:46:30 +01:00
vbahelper Revert "loplugin:constfields in vbahelper" 2020-03-16 08:17:02 +01:00
vcl ScrollToAbsPos is better than ScrollOutputArea 2020-03-20 13:56:48 +01:00
winaccessibility
wizards
writerfilter sw pad-to-4 numbering: add DOCX filter 2020-03-20 22:37:47 +01:00
writerperfect Revert "loplugin:constfields in writerfilter" 2020-03-16 10:59:41 +01:00
xmerge
xmlhelp Revert "loplugin:constfields in xmlhelp" 2020-03-16 10:29:56 +01:00
xmloff xmloff: create SchXMLExport_Oasis_Meta instances with an uno constructor 2020-03-20 09:12:12 +01:00
xmlreader
xmlscript
xmlsecurity tdf#42316 always evaluate macro signatures on load 2020-03-13 00:37:46 +01:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in
config_host_lang.mk.in
configure.ac The idl __attribute__((__weak__)) hack doesn't seem necessary for --enable-lto 2020-03-20 19:31:11 +01:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst repack the boost tarball to be smaller and faster 2020-03-18 12:21:23 +01:00
g
hardened_runtime.xcent
install-sh
leak-suppress.txt
Library_merged.mk
lo.xcent
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in make: map slowcheck to gbuild's build and slowcheck 2020-03-19 20:43:51 +01:00
README.cross
README.md
README.Solaris
Repository.mk
RepositoryExternal.mk implement text rendering using directly Skia (X11) 2020-03-18 10:47:49 +01:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-blacklist
setup.cfg
TEMPLATE.SOURCECODE.HEADER

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The build chain and runtime baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.4
  • macOS:
    • Runtime: 10.10
    • Build: 10.14.4 + Xcode 11.3
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 5.0.2 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The important bits of code

Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: 'Rectangle', 'Color' etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding out more

Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.