7e403195e5
...with a boost::optional fallback for Xcode < 10 (as std::optional is only
available starting with Xcode 10 according to
<https://en.cppreference.com/w/cpp/compiler_support>, and our baseline for iOS
and macOS is still Xcode 9.3 according to README.md). And mechanically rewrite
all code to use o3tl::optional instead of boost::optional.
One immediate benefit is that disabling -Wmaybe-uninitialized for GCC as per
fed7c3deb3 "Slience bogus
-Werror=maybe-uninitialized" should no longer be necessary (and whose check
happened to no longer trigger for GCC 10 trunk, even though that compiler would
still emit bogus -Wmaybe-uninitialized for uses of boost::optional under
--enable-optimized, which made me ponder whether this switch from
boost::optional to std::optional would be a useful thing to do; I keep that
configure.ac check for now, though, and will only remove it in a follow up
commit).
Another longer-term benefit is that the code is now already in good shape for an
eventual switch to std::optional (a switch we would have done anyway once we no
longer need to support Xcode < 10).
Only desktop/qa/desktop_lib/test_desktop_lib.cxx heavily uses
boost::property_tree::ptree::get_child_optional returning boost::optional, so
let it keep using boost::optional for now.
After a number of preceding commits have paved the way for this change, this
commit is completely mechanical, done with
> git ls-files -z | grep -vz -e '^bin/find-unneeded-includes$' -e '^configure.ac$' -e '^desktop/qa/desktop_lib/test_desktop_lib.cxx$' -e '^dictionaries$' -e '^external/' -e '^helpcontent2$' -e '^include/IwyuFilter_include.yaml$' -e '^sc/IwyuFilter_sc.yaml$' -e '^solenv/gdb/boost/optional.py$' -e '^solenv/vs/LibreOffice.natvis$' -e '^translations$' -e '\.svg$' | xargs -0 sed -i -E -e 's|\<boost(/optional)?/optional\.hpp\>|o3tl/optional.hxx|g' -e 's/\<boost(\s*)::(\s*)(make_)?optional\>/o3tl\1::\2\3optional/g' -e 's/\<boost(\s*)::(\s*)none\>/o3tl\1::\2nullopt/g'
(before committing include/o3tl/optional.hxx, and relying on some GNU features).
It excludes some files where mention of boost::optional et al should apparently
not be changed (and the sub-repo directory stubs). It turned out that all uses
of boost::none across the code base were in combination with boost::optional, so
had all to be rewritten as o3tl::nullopt.
Change-Id: Ibfd9f4b3d5a8aee6e6eed310b988c4e5ffd8b11b
Reviewed-on: https://gerrit.libreoffice.org/84128
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
68 lines
2.3 KiB
C++
68 lines
2.3 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
* This file incorporates work covered by the following license notice:
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed
|
|
* with this work for additional information regarding copyright
|
|
* ownership. The ASF licenses this file to you under the Apache
|
|
* License, Version 2.0 (the "License"); you may not use this file
|
|
* except in compliance with the License. You may obtain a copy of
|
|
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
|
|
*/
|
|
|
|
#ifndef INCLUDED_SC_INC_PARAMISC_HXX
|
|
#define INCLUDED_SC_INC_PARAMISC_HXX
|
|
|
|
#include "address.hxx"
|
|
#include <o3tl/optional.hxx>
|
|
|
|
struct ScSolveParam
|
|
{
|
|
ScAddress aRefFormulaCell;
|
|
ScAddress aRefVariableCell;
|
|
o3tl::optional<OUString> pStrTargetVal;
|
|
|
|
ScSolveParam();
|
|
ScSolveParam( const ScSolveParam& r );
|
|
ScSolveParam( const ScAddress& rFormulaCell,
|
|
const ScAddress& rVariableCell,
|
|
const OUString& rTargetValStr );
|
|
~ScSolveParam();
|
|
|
|
ScSolveParam& operator= ( const ScSolveParam& r );
|
|
bool operator== ( const ScSolveParam& r ) const;
|
|
};
|
|
|
|
/**
|
|
* Parameter for data table aka multiple operations.
|
|
*/
|
|
struct SC_DLLPUBLIC ScTabOpParam
|
|
{
|
|
enum Mode { Column = 0, Row = 1, Both = 2 };
|
|
|
|
ScRefAddress aRefFormulaCell;
|
|
ScRefAddress aRefFormulaEnd;
|
|
ScRefAddress aRefRowCell;
|
|
ScRefAddress aRefColCell;
|
|
Mode meMode;
|
|
|
|
ScTabOpParam();
|
|
ScTabOpParam( const ScTabOpParam& r );
|
|
ScTabOpParam(
|
|
const ScRefAddress& rFormulaCell, const ScRefAddress& rFormulaEnd,
|
|
const ScRefAddress& rRowCell, const ScRefAddress& rColCell, Mode eMode );
|
|
|
|
ScTabOpParam& operator= ( const ScTabOpParam& r );
|
|
bool operator== ( const ScTabOpParam& r ) const;
|
|
};
|
|
|
|
#endif // INCLUDED_SC_INC_PARAMISC_HXX
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|