0807fe3628
While debugging tdf#163945, Xcode's Instruments application uncovered the following performance bottlenecks when using Skia/Metal: 1. Very slow rendering an NSBox: Many system colors have the NSColorTypeCatalog color type. For some unkown reason, setting the NSBox's fill color to a color set to NSColorTypeCatalog causes drawing to take at least twice as long as when the fill color is set to NSColorTypeComponentBased. So, only draw with a fill color set to NSColorTypeComponentBased. 2. Excessively large offscreen buffers when drawing native controls: The temporary bitmap was set to the control region expanded by 50 * mScaling (e.g. both width and height were increased by 200 pixels when running on a Retina display). This caused temporary bitmaps to be up to several times larger than needed. Also, drawing NSBox objects to a CGBitmapContext is noticeably slow so filling all that unneeded temporary bitmap area can slow down performance when a large number of NSBox objects like the status bar are redrawn in quick succession. Using getNativeControlRegion() isn't perfect, but it does try to account for the focus ring as well as the minimum width and/or height of the native control so union the two regions set by getNativeControlRegion() and add double the focus ring width on each side just to be safe. In most cases, this should ensure that the temporary bitmap is large enough to draw the entire native control and a focus ring. 3. Unncessary copying of bitmap buffer when drawing native controls: Let Skia own the CGBitmapContext's buffer so that an SkImage can be created without Skia making a copy of the buffer. Change-Id: Ibd3abb4b9d7045c47268319772fe97a5c4dba3c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177225 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> |
||
|---|---|---|
| .. | ||
| android | ||
| animate | ||
| bitmap | ||
| filter | ||
| font | ||
| graphic | ||
| headless | ||
| ios | ||
| jsdialog | ||
| opengl | ||
| osx | ||
| pch | ||
| qt5 | ||
| qt6 | ||
| quartz | ||
| skia | ||
| test | ||
| unx | ||
| widgetdraw | ||
| win | ||
| accel.hxx | ||
| accmgr.hxx | ||
| bitmaps.hlst | ||
| BitmapSymmetryCheck.hxx | ||
| brdwin.hxx | ||
| bubblewindow.hxx | ||
| calendar.hxx | ||
| canvasbitmap.hxx | ||
| configsettings.hxx | ||
| ContextVBox.hxx | ||
| ControlCacheKey.hxx | ||
| cursor_hotspots.hxx | ||
| dbggui.hxx | ||
| debugevent.hxx | ||
| displayconnectiondispatch.hxx | ||
| dndeventdispatcher.hxx | ||
| dndhelper.hxx | ||
| dndlistenercontainer.hxx | ||
| drawmode.hxx | ||
| driverblocklist.hxx | ||
| DropdownBox.hxx | ||
| factory.hxx | ||
| FileDefinitionWidgetDraw.hxx | ||
| fltcall.hxx | ||
| fontattributes.hxx | ||
| fontsubset.hxx | ||
| glyphid.hxx | ||
| helpwin.hxx | ||
| hyperlabel.hxx | ||
| IconThemeScanner.hxx | ||
| IconThemeSelector.hxx | ||
| iconview.hxx | ||
| image.h | ||
| imagerepository.hxx | ||
| impdel.hxx | ||
| impfont.hxx | ||
| impfontcache.hxx | ||
| impfontcharmap.hxx | ||
| impglyphitem.hxx | ||
| impgraph.hxx | ||
| implimagetree.hxx | ||
| ImplLayoutArgs.hxx | ||
| ImplLayoutRuns.hxx | ||
| ImplOutDevData.hxx | ||
| IPrioritable.hxx | ||
| jobdata.hxx | ||
| jobset.h | ||
| justificationdata.hxx | ||
| langboost.hxx | ||
| listbox.hxx | ||
| managedmenubutton.hxx | ||
| menubarvalue.hxx | ||
| menutogglebutton.hxx | ||
| messagedialog.hxx | ||
| NotebookbarPopup.hxx | ||
| OptionalBox.hxx | ||
| ppdparser.hxx | ||
| print.h | ||
| print.hrc | ||
| printaccessoryview.hrc | ||
| printdlg.hxx | ||
| printerinfomanager.hxx | ||
| PriorityHBox.hxx | ||
| PriorityMergedHBox.hxx | ||
| regband.hxx | ||
| regionband.hxx | ||
| ResampleKernel.hxx | ||
| salbmp.hxx | ||
| salframe.hxx | ||
| salgdi.hxx | ||
| salgdiimpl.hxx | ||
| salgeom.hxx | ||
| SalGradient.hxx | ||
| salinst.hxx | ||
| sallayout.hxx | ||
| salmenu.hxx | ||
| salobj.hxx | ||
| salprn.hxx | ||
| salptype.hxx | ||
| salsession.hxx | ||
| salsys.hxx | ||
| saltimer.hxx | ||
| salusereventlist.hxx | ||
| salvd.hxx | ||
| salvtables.hxx | ||
| salwtype.hxx | ||
| scanlinewriter.hxx | ||
| schedulerimpl.hxx | ||
| scrptrun.h | ||
| scrwnd.hxx | ||
| sft.hxx | ||
| slider.hxx | ||
| spin.hxx | ||
| strhelper.hxx | ||
| strings.hrc | ||
| strings.hxx | ||
| svdata.hxx | ||
| svimpbox.hxx | ||
| svsys.h | ||
| textlayout.hxx | ||
| TextLayoutCache.hxx | ||
| textlineinfo.hxx | ||
| textrender.hxx | ||
| toolbarvalue.hxx | ||
| toolbox.h | ||
| treeglue.hxx | ||
| uiobject-internal.hxx | ||
| units.hrc | ||
| vcleventlisteners.hxx | ||
| vclpluginapi.h | ||
| vclstatuslistener.hxx | ||
| verticaltabctrl.hxx | ||
| watchdog.hxx | ||
| WidgetDrawInterface.hxx | ||
| window.h | ||
| windowdev.hxx | ||
| wizdlg.hxx | ||