Test repository to check push and ssh key
Find a file
Justin Luth 91d1cd8687 tdf#81522 comphelper: just ignore disposed obj on save
Even if xObj.is(), it might be disposed, and then
getCurrentState() will raise an exception,
resulting in an ERRCODE_IO_GENERAL,
and failing to save the entire document.

Although it might not seem good to just ignore an error
on save, the general attitude in that function already
leans that way. In fact, the other ::StoreChildren()
wraps the entire for-loop in a try-catch.
Also, in this function a bad xPersist also breaks
out of the loop and returns a false.
So wrapping the entire xObj in an "ignore if errors"
try-catch seems reasonable to me in this instance.

The alternative is not to allow the user to save at all,
which is much worse, especially since there is nothing
he can do to fix the problem.

Change-Id: I0372245563735ae7ac7976bf7ce6060e57a5eb87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99129
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-07-22 17:27:55 +02:00
.git-hooks Fixup pre-commit hook to work with worktrees 2020-07-10 22:52:07 +02:00
.github
accessibility move CheckBox to toolkit-only headers 2020-07-12 20:28:56 +02:00
android Update paths in Makefile.in and android/.gitignore 2020-07-17 14:35:53 +02:00
animations
apple_remote
avmedia compact namespace: avmedia 2020-07-16 18:05:48 +02:00
basctl update pches 2020-07-12 12:20:05 +02:00
basegfx compact namespace: basegfx,canvas 2020-07-16 18:06:55 +02:00
basic Fix uses of char16_t*/wchar_t* stream inserters 2020-07-21 21:32:10 +02:00
bean
bin Silence GCC 11 trunk -Werror=nonnull in external/boost 2020-07-22 15:05:54 +02:00
binaryurp replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
bridges
canvas compact namespace: basegfx,canvas 2020-07-16 18:06:55 +02:00
chart2 chart2: clean-up redundant ShapeFactory::createText() 2020-07-22 11:08:59 +02:00
cli_ure
codemaker
comphelper tdf#81522 comphelper: just ignore disposed obj on save 2020-07-22 17:27:55 +02:00
compilerplugins loplugin:unusedmethods 2020-07-21 08:31:20 +02:00
config_host Revert "configure: add a --with-product-flavor switch" 2020-07-21 13:24:16 +02:00
configmgr compact namespace: connectivity 2020-07-18 19:08:12 +02:00
connectivity Fix typo 2020-07-20 05:05:36 +02:00
cppcanvas compact namespace: cppcanvas 2020-07-16 20:37:01 +02:00
cppu replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
cppuhelper update pches 2020-07-12 12:20:05 +02:00
cpputools Upcoming improved loplugin:staticanonymous -> redundantstatic: cpputools 2020-07-01 07:07:26 +02:00
cui tdf#133026: Additions - Parameter support to UNO Command 2020-07-21 22:25:13 +02:00
dbaccess weld PatternControl 2020-07-22 12:24:23 +02:00
desktop compact namespace: dbaccess,desktop 2020-07-16 18:06:13 +02:00
dictionaries@8cd579e3a6 Update git submodules 2020-07-22 16:01:45 +02:00
distro-configs android: Add a CP x86 configuration too. 2020-07-01 18:00:09 +02:00
drawinglayer limit bitmap size for glow/softedge effects to visible area (tdf#134237) 2020-07-20 12:40:17 +02:00
dtrans dtrans/clipboard: create instances with uno constructors 2020-07-22 14:41:19 +02:00
editeng compact namespace: editeng-filter 2020-07-16 20:31:01 +02:00
embeddedobj embeddedobj/util: create instances with uno constructors 2020-07-22 08:29:47 +02:00
embedserv embedserv: create instances with uno constructors 2020-07-07 17:44:43 +02:00
emfio move Primitive2dXmlDump from drawinglayer::tools to drawinglayer NS 2020-07-13 19:31:18 +02:00
eventattacher eventattacher: create instances with uno constructors 2020-07-09 20:04:18 +02:00
extensions extensions/prop: create instances with uno constructors 2020-07-22 14:40:58 +02:00
external Silence GCC 11 trunk -Werror=nonnull in external/boost 2020-07-22 15:05:54 +02:00
extras [en-US] Added 13 words to autocorrect 2020-07-22 15:38:53 +02:00
filter SVG export: fix lost semi-transparent text on shapes 2020-07-17 10:07:11 +02:00
forms compact namespace decl 2020-07-20 10:12:57 +02:00
formula formula: create instances with uno constructors 2020-07-07 22:01:33 +02:00
fpicker fpicker/aqua: create instances with uno constructors 2020-07-15 08:45:58 +02:00
framework Revert "configure: add a --with-product-flavor switch" 2020-07-21 13:24:16 +02:00
helpcompiler replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
helpcontent2@da688f647b Update git submodules 2020-07-22 13:17:35 +02:00
hwpfilter hwpfilter: create instances with uno constructors 2020-07-14 10:26:53 +02:00
i18nlangtag Upcoming improved loplugin:staticanonymous -> redundantstatic: i18nlangtag 2020-07-01 10:21:18 +02:00
i18npool i18npool: don't break line at slash '/' 2020-07-21 13:17:47 +02:00
i18nutil Upcoming improved loplugin:staticanonymous -> redundantstatic: i18nutil 2020-07-01 11:05:31 +02:00
icon-themes Remove tagline from brand image and splash screen 2020-07-21 16:00:14 +02:00
idl
idlc Upcoming improved loplugin:staticanonymous -> redundantstatic: idlc 2020-07-01 11:05:52 +02:00
include move PatternField to toolkit headers 2020-07-22 12:24:46 +02:00
instsetoo_native
io io: create instances with uno constructors 2020-07-14 10:27:34 +02:00
ios tdf#134832: Also run the BitmapTest from vcl 2020-07-22 10:38:22 +03:00
javaunohelper replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
jurt
jvmaccess replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
jvmfwk replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
l10ntools Upcoming improved loplugin:staticanonymous -> redundantstatic: l10ntools 2020-07-01 13:20:34 +02:00
librelogo Follow up tdf#132022: Remove Tango icons for LibreLogo 2020-07-17 06:50:25 +02:00
libreofficekit We apparently need to call Application::Quit() on iOS now 2020-07-20 13:14:46 +02:00
lingucomponent this should be a single-instance component 2020-07-20 22:00:09 +02:00
linguistic fix SAL_WARN when instantiating Thesaurus 2020-07-20 17:28:33 +02:00
lotuswordpro update pches 2020-07-12 12:20:05 +02:00
m4
nlpsolver
o3tl
odk Remove obsolete dynamic exception specifications from SDK example C++ code 2020-07-22 15:13:24 +02:00
offapi replace usage of whitelist with allowlist 2020-07-10 01:36:07 +02:00
officecfg tdf#67560: PNG export option Save transparency not remembered 2020-07-10 13:25:08 +02:00
onlineupdate
oovbaapi
oox ofz#24317 hash too short 2020-07-22 12:52:20 +02:00
opencl replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
osx
package package: create instances with uno constructors 2020-07-17 08:47:55 +02:00
pch
postprocess replace usage of blacklist with denylist 2020-07-10 01:34:54 +02:00
pyuno pyuno: create instances with uno constructors 2020-07-14 15:49:24 +02:00
qadevOOo xmloff: remove dead com.sun.star.comp.Impress.XMLStylesExporter 2020-07-17 09:08:11 +02:00
readlicense_oo
registry compact namespace decl 2020-07-20 10:12:57 +02:00
remotebridges remotebridges: create instances with uno constructors 2020-07-14 12:03:12 +02:00
reportbuilder
reportdesign update pches 2020-07-12 12:20:05 +02:00
ridljar
sal Improved oplugin:staticanonymous -> redundantstatic redux, macOS 2020-07-21 09:19:33 +02:00
salhelper
sax Upcoming improved loplugin:staticanonymous -> redundantstatic: sax 2020-07-01 21:29:44 +02:00
sc tdf#133026: Additions - Parameter support to UNO Command 2020-07-21 22:25:13 +02:00
scaddins compact namespace decl 2020-07-20 10:12:57 +02:00
sccomp replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
schema
scp2 Add Turkish (tr) dictionary 2020-07-02 09:04:02 +02:00
scripting scripting/basprov: create instances with uno constructors 2020-07-15 10:10:54 +02:00
sd tdf#134969 Add solid transparence in color gradient 2020-07-22 11:54:04 +02:00
sdext loplugin:unnecessaryvirtual 2020-07-20 23:03:43 +02:00
setup_native Related: tdf#82184: consider installer language for UI list to install 2020-07-12 22:59:11 +02:00
sfx2 Removed executable permission on cxx file 2020-07-22 13:19:08 +02:00
shell shell/simplemail: create instances with uno constructors 2020-07-21 15:17:19 +02:00
slideshow Deprecated std::result_of has been removed from C++20 2020-07-21 22:50:32 +02:00
smoketest
solenv ucb/file: create instances with uno constructors 2020-07-22 16:05:06 +02:00
soltools
sot update pches 2020-07-12 12:20:05 +02:00
starmath compact namespace decl 2020-07-20 10:12:57 +02:00
stoc stoc/proxy: create instances with uno constructors 2020-07-15 10:05:23 +02:00
store replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
svgio compact namespace: svgio 2020-07-20 08:42:57 +02:00
svl comphelper: don't hardcode hash sizes in Hash::getLength() 2020-07-15 09:16:05 +02:00
svtools weld PatternControl 2020-07-22 12:24:23 +02:00
svx update svx pch 2020-07-22 15:24:06 +02:00
sw weld PatternControl 2020-07-22 12:24:23 +02:00
swext
sysui
test replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
testtools Upcoming improved loplugin:staticanonymous -> redundantstatic: testtools 2020-07-02 10:06:47 +02:00
toolkit weld DateControl 2020-07-21 10:25:42 +02:00
tools Fix uses of char16_t*/wchar_t* stream inserters 2020-07-21 21:32:10 +02:00
translations@d602d2af8c Update git submodules 2020-07-15 16:25:57 +02:00
ucb ucb/file: create instances with uno constructors 2020-07-22 16:05:06 +02:00
ucbhelper replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
udkapi
uitest uitest: Fix small issue in UI Logger DSL grammar "EditUIObject" 2020-07-03 11:46:38 +02:00
UnoControls replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
unodevtools Upcoming improved loplugin:staticanonymous -> redundantstatic: unodevtools 2020-07-02 13:16:27 +02:00
unoidl replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
unoil
unotest
unotools update pches 2020-07-12 12:20:05 +02:00
unoxml update pches 2020-07-12 12:20:05 +02:00
ure
uui compact namespace decl 2020-07-20 10:12:57 +02:00
vbahelper update pches 2020-07-12 12:20:05 +02:00
vcl Fix typo 2020-07-22 15:37:48 +02:00
winaccessibility winaccessibility: create instances with uno constructors 2020-07-14 18:31:39 +02:00
wizards
writerfilter tdf#134648 DOCX import: fix bottom auto margin of subitem 2020-07-21 11:01:12 +02:00
writerperfect compact namespace: writerperfect 2020-07-20 08:42:29 +02:00
xmerge
xmlhelp replace usage of blacklist with excludelist for IWYU 2020-07-10 02:03:40 +02:00
xmloff compact namespace decl 2020-07-20 10:12:57 +02:00
xmlreader
xmlscript xmlscript: create instances with uno constructors 2020-07-06 20:17:26 +02:00
xmlsecurity compact namespace decl 2020-07-20 10:12:57 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in use Clang11's -fpch-instantiate-templates if available 2020-07-17 13:30:55 +02:00
config_host_lang.mk.in
configure.ac Revert "configure: add a --with-product-flavor switch" 2020-07-21 13:24:16 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst external: update pdfium to 4203 2020-07-22 10:40:57 +02:00
g
hardened_runtime.xcent.in
install-sh
leak-suppress.txt
Library_merged.mk
lo.xcent
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in Update paths in Makefile.in and android/.gitignore 2020-07-17 14:35:53 +02:00
README.cross
README.md
README.Solaris
Repository.mk tdf#133788 Missing pieces for Gallery localization 2020-07-15 09:41:59 +02:00
RepositoryExternal.mk python3: update to 3.8.4 2020-07-17 10:15:06 +02:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist replace usage of blacklist with denylist 2020-07-10 01:34:54 +02:00
setup.cfg
TEMPLATE.SOURCECODE.HEADER

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The build chain and runtime baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.4
  • macOS:
    • Runtime: 10.10
    • Build: 10.14.4 + Xcode 11.3
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 5.0.2 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The important bits of code

Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: 'Rectangle', 'Color' etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding out more

Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.