Test repository to check push and ssh key
Find a file
Patrick Luby 926ed71244 tdf#161729 clear style sheets in same order as they were added
std::vector::clear() appears to delete elements in the
reverse order added. In the case of tdf#161729, a style
sheet's SfxItemSet can have a parent SfxItemSet and that
parent is the SfxItemSet for a style sheet added later.

Deleting from the end of the vector deletes a style sheet
and its SfxItemSet. If the now deleted SfxItemSet is a
parent SfxItemSet of a style sheet that was added earlier,
the style sheet added earlier will now have an SfxItemSet
with its parent set to an already deleted pointer. And so
a crash will occur when that earlier style sheet is deleted.
rxStyleSheet.clear();

Change-Id: I8ce7023fce8b01432cb3c9288a8f83e7a2f0f2d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170707
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-20 13:01:36 +02:00
.git-hooks
.github
.vscode
accessibility
android android: Drop unused import 2024-07-19 18:32:15 +02:00
animations
apple_remote
avmedia
basctl
basegfx cid#1555694 COPY_INSTEAD_OF_MOVE 2024-07-17 21:49:14 +02:00
basic Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
bean
bin configure,curl: enable GSSAPI on Linux/MacOS/etc. 2024-07-19 21:36:53 +02:00
binaryurp cid#1555694 COPY_INSTEAD_OF_MOVE 2024-07-17 21:49:14 +02:00
bridges
canvas
chart2 Resolves: tdf#158753 GtkAssistant loses current page on hide+show 2024-07-17 15:03:08 +02:00
cli_ure
codemaker Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
comphelper Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
compilerplugins
config_host
configmgr Revert "boost::unordered_map to std::unordered_map in configmgr::Partial" 2024-07-14 17:32:17 +02:00
connectivity tdf#162111: promote integer types automatically 2024-07-20 07:55:03 +02:00
cppcanvas
cppu
cppuhelper
cpputools
cui tdf#161909: Repair certdialog columns with VCLPLUGIN != gtk3 2024-07-19 21:37:52 +02:00
dbaccess tdf#43157 Use SAL_WARN_IF instead of OSL_ENSURE 2024-07-20 12:34:57 +02:00
desktop Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
dictionaries@fc2dc383a4
distro-configs
docmodel cid#1554709 COPY_INSTEAD_OF_MOVE 2024-07-16 15:13:41 +02:00
drawinglayer Fix typos 2024-07-20 00:32:11 +02:00
editeng Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
embeddedobj Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
embedserv
emfio
eventattacher
extensions Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
external configure,curl: enable GSSAPI on Linux/MacOS/etc. 2024-07-19 21:36:53 +02:00
extras Update Beehive template 2024-07-13 15:56:15 +02:00
filter Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
forms cid#1608071 Out-of-bounds access 2024-07-17 18:25:54 +02:00
formula tdf#161296 Convert functions list in FD & FW into collapsible sections 2024-07-19 07:50:55 +02:00
fpicker
framework
helpcompiler
helpcontent2@c6956d32c0 Update git submodules 2024-07-15 17:08:12 +02:00
hwpfilter
i18nlangtag
i18npool Fix "lets" -> "let's" 2024-07-19 14:40:23 +02:00
i18nutil
icon-themes
idl Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
idlc/test/parser
include tdf#43157 Use SAL_WARN_IF instead of OSL_ENSURE 2024-07-20 12:34:57 +02:00
instsetoo_native
io
ios
javaunohelper
jurt
jvmaccess
jvmfwk Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
l10ntools
librelogo Python: use is None/is not None instead of == None/!= None 2024-07-13 09:13:54 +02:00
libreofficekit
lingucomponent Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
linguistic
lotuswordpro Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
m4
msicreator
net_ure
nlpsolver
o3tl
odk Fix typo 2024-07-19 14:41:40 +02:00
offapi Add test code for UNO attributes implemented in JS 2024-07-16 12:48:40 +02:00
officecfg getting the "manual cert path" throws unexpectedly 2024-07-19 21:36:08 +02:00
oovbaapi
oox cid#1555694 COPY_INSTEAD_OF_MOVE 2024-07-17 21:49:14 +02:00
opencl
osx
package CppunitTest_package2_test: Add unittest for 0fb25ce9ff 2024-07-18 10:39:30 +02:00
pch
postprocess
pyuno Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
qadevOOo
readlicense_oo
registry
remotebridges
reportbuilder
reportdesign
ridljar
sal Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
salhelper
sax Fix "lets" -> "let's" 2024-07-19 14:40:23 +02:00
sc Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
scaddins
sccomp
schema
scp2
scripting Python: use is None/is not None instead of == None/!= None 2024-07-13 09:13:54 +02:00
sd Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
sdext cid#1555824 Check of thread-shared field evades lock acquisition 2024-07-18 11:52:22 +02:00
setup_native
sfx2 Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
shell Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
slideshow
smoketest
solenv solenv: gdb: adapt ItemSetPrinter to unordered_map 2024-07-18 16:38:41 +02:00
soltools
sot Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
starmath make some single-arg constructors in starmath explicit 2024-07-18 15:33:56 +02:00
static Drop obsolete "Ideas for an UNO bridge implementation" 2024-07-19 19:24:40 +02:00
stoc
store
svgio cid#1555694 COPY_INSTEAD_OF_MOVE 2024-07-17 21:49:14 +02:00
svl tdf#161729 clear style sheets in same order as they were added 2024-07-20 13:01:36 +02:00
svtools Use IsRunningUnitTest / IsRunningUITest consistently 2024-07-17 19:15:31 +02:00
svx Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
sw Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
swext
sysui
test cid#1554837 COPY_INSTEAD_OF_MOVE 2024-07-19 12:09:11 +02:00
testtools
toolkit make date/time single-arg constructors explicit 2024-07-18 10:27:41 +02:00
tools cid#1555652 COPY_INSTEAD_OF_MOVE 2024-07-14 15:16:40 +02:00
translations@0e95a8dfb0 Update git submodules 2024-07-15 12:38:59 +02:00
ucb Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
ucbhelper
udkapi
uitest Simplify use of close_dialog_through_button: allow button by name 2024-07-15 21:55:40 +02:00
UnoControls
unodevtools Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
unoidl cid#1555694 COPY_INSTEAD_OF_MOVE 2024-07-17 21:49:14 +02:00
unoil
unotest Change from Module.intiUno() to Module.uno_init promise 2024-07-18 15:55:12 +02:00
unotools cid#1554837 COPY_INSTEAD_OF_MOVE 2024-07-19 12:09:11 +02:00
unoxml
ure
uui uui: improve Authentication dialog 2024-07-19 19:53:09 +02:00
vbahelper
vcl Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
winaccessibility
wizards Fix typo 2024-07-19 20:37:49 +02:00
writerperfect
xmerge
xmlhelp
xmloff Fix typo 2024-07-20 12:05:54 +02:00
xmlreader
xmlscript
xmlsecurity make date/time single-arg constructors explicit 2024-07-18 10:27:41 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh Add a note about autogen.input into autogen.sh --help output 2024-07-13 22:18:14 +02:00
BUCK
config.guess
config.sub
config_host.mk.in
config_host_lang.mk.in
configure.ac configure,curl: enable GSSAPI on Linux/MacOS/etc. 2024-07-19 21:36:53 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint
download.lst Update libxmlsec to 1.3.5 2024-07-19 11:08:06 +02:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.help.md
README.md
README.Solaris
Repository.mk
RepositoryExternal.mk
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.