office-gobmx/slideshow/source
Mike Kaganski e5b18c7d00 Make slideshow objects' debugging semi-transparency and shift conditional
It was introduced in commit cfd7bf7f6e
(INTEGRATION: CWS presfixes12 (1.1.2); FILE ADDED, 2007-07-17); and
back then, it was guarded by VERBOSE define. The VERBOSE condition
was replaced by OSL_DEBUG_LEVEL >= 2 condition later in commit
912e36e911 (Remove VERBOSE part 3,
2012-04-10); and then, it was completely dropped in commit
e5ec630414 (stop inclduing
canvas/verbosetraces.hxx and canvas/debug.hxx, 2015-08-11).

But this code is definitely harmful by default, when an unaware
developer (like myself) tries to debug an animation problem, and
suddenly sees a very different problem in the debug build (the shift
and transparency of objects), which obviously is a new regression in
master, but it can't be bisected using bibisect repos, which makes
you to question your sanity, until you realize that it must be some
debug-only feature.

Thorsten wrote on IRC:
> the semi-transparency & shifting is needed for actually noticing
> what's behind (shapes get moved to sprites, then erased from the
> static canvas, then moved around)
> so I believe it's useful debugging tools, but of course should not
> randomly enable for normal dev builds

So use environment variable to control this behavior-changing code.

Change-Id: I493cdde26c95fdde4a5d542a0bdad8e329fdfda8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173965
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-09-26 14:48:13 +02:00
..
engine Make slideshow objects' debugging semi-transparency and shift conditional 2024-09-26 14:48:13 +02:00
inc Make slideshow objects' debugging semi-transparency and shift conditional 2024-09-26 14:48:13 +02:00