1fd27a7931
I seem to have missed quite a few in
commit 9f4d23c151
filter out some of the AST in the plugins
This nets me another 14% improvement
Change-Id: I39b980b49ced560f768045dbedd3ddfef29306c1
Reviewed-on: https://gerrit.libreoffice.org/59501
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
81 lines
2.2 KiB
C++
81 lines
2.2 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <string>
|
|
#include <iostream>
|
|
#include <map>
|
|
#include <set>
|
|
|
|
#include "plugin.hxx"
|
|
#include "clang/AST/CXXInheritance.h"
|
|
|
|
// Check for final classes that have protected members
|
|
|
|
namespace
|
|
{
|
|
|
|
class FinalProtected:
|
|
public loplugin::FilteringPlugin<FinalProtected>
|
|
{
|
|
public:
|
|
explicit FinalProtected(loplugin::InstantiationData const & data):
|
|
FilteringPlugin(data) {}
|
|
|
|
virtual void run() override {
|
|
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
|
|
bool VisitCXXMethodDecl(CXXMethodDecl const *);
|
|
bool VisitFieldDecl(FieldDecl const *);
|
|
};
|
|
|
|
|
|
bool FinalProtected::VisitCXXMethodDecl(CXXMethodDecl const * cxxMethodDecl)
|
|
{
|
|
if (ignoreLocation(cxxMethodDecl)) {
|
|
return true;
|
|
}
|
|
if (cxxMethodDecl->getAccess() != AS_protected) {
|
|
return true;
|
|
}
|
|
if (!cxxMethodDecl->getParent()->hasAttr<FinalAttr>()) {
|
|
return true;
|
|
}
|
|
cxxMethodDecl = cxxMethodDecl->getCanonicalDecl();
|
|
report(DiagnosticsEngine::Warning,
|
|
"final class should not have protected members - convert them to private",
|
|
compat::getBeginLoc(cxxMethodDecl))
|
|
<< cxxMethodDecl->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
bool FinalProtected::VisitFieldDecl(FieldDecl const * fieldDecl)
|
|
{
|
|
if (ignoreLocation(fieldDecl)) {
|
|
return true;
|
|
}
|
|
if (fieldDecl->getAccess() != AS_protected) {
|
|
return true;
|
|
}
|
|
if (!fieldDecl->getParent()->hasAttr<FinalAttr>()) {
|
|
return true;
|
|
}
|
|
fieldDecl = fieldDecl->getCanonicalDecl();
|
|
report(DiagnosticsEngine::Warning,
|
|
"final class should not have protected members - convert them to private",
|
|
compat::getBeginLoc(fieldDecl))
|
|
<< fieldDecl->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
loplugin::Plugin::Registration< FinalProtected > X("finalprotected", true);
|
|
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|