Test repository to check push and ssh key
Find a file
Mike Kaganski 9c14ec81b6 tdf#164006: Only use original word's positions, ignore extra encoded length
The encoding of the string passed to Hunspell/hyphen service depends on the
encoding of the dictionary itself. When the usual UTF-8 encoding is used,
the resulting octet string may be longer than the original UTF-16 code unit
count. In that case, the length of the buffer receiving the positions will
be longer, respectively. But on return, the buffer will only contain data
in positions corresponding to the characters, not code units (it is unclear
if we even need to pass buffer that large). So just as the following loop
only iterates up to nWord length, the calculation of hyphen count must use
its length, too, not the length of encWord.

I suspect that the use of UTF-16 code units as hyphen positions is wrong;
it will break in SMP surrogate pairs. The proper would be to iterate code
points. However, I don't have data to test, so let it be TODO/LATER.

Change-Id: Ieed5e696e03cb22e3b48fabc14537372bbe74363
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177077
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-11-23 10:03:41 +01:00
.configurations
.git-hooks
.github
.vscode
accessibility Related: cid#1364016 Missing move assignment operator 2024-11-21 11:44:00 +01:00
android
animations
apple_remote
avmedia consider VndSunStarExpand an exotic protocol 2024-11-19 20:20:03 +01:00
basctl Use specific SvtModuleOptions::Is*Installed for clarity 2024-11-23 09:45:38 +01:00
basegfx
basic tdf#108189 inspection of object hangs LO 2024-11-14 18:02:03 +01:00
bean
bin bin: Add script to check the latest version of external libraries 2024-11-13 09:33:38 +01:00
binaryurp
bridges
canvas canvas: simplify calcTransformedRectBounds 2024-11-19 16:14:13 +01:00
chart2 PVS: V560 A part of conditional expression is always true: 2024-11-22 13:45:45 +01:00
cli_ure
codemaker
comphelper crypto: add AES256 test, document Encrypt, Hash conv. function 2024-11-22 07:19:30 +01:00
compilerplugins svx: unused return 2024-11-19 18:03:18 +01:00
config_host Fix Linux cppuhelper_detail_findSofficePath 2024-11-14 16:11:59 +01:00
configmgr cid#1606638 silence Overflowed integer argument 2024-11-18 22:24:40 +01:00
connectivity tdf#163486: PVS: Identical branches 2024-11-20 13:52:12 +01:00
cppcanvas canvas: simplify calcTransformedRectBounds 2024-11-19 16:14:13 +01:00
cppu
cppuhelper Fix Linux cppuhelper_detail_findSofficePath 2024-11-14 16:11:59 +01:00
cpputools
cui tdf#152299 - Remove unused define(s) from C/C++ files 2024-11-23 09:54:47 +01:00
dbaccess Use specific SvtModuleOptions::Is*Installed for clarity 2024-11-23 09:45:38 +01:00
desktop Use specific SvtModuleOptions::Is*Installed for clarity 2024-11-23 09:45:38 +01:00
dictionaries@1ca6cb9f31
distro-configs
docmodel
drawinglayer no longer need this svtools/drawinglayer hack 2024-11-21 14:31:49 +01:00
editeng tdf#152299 - Remove unused define(s) from C/C++ files 2024-11-23 09:56:31 +01:00
embeddedobj consider VndSunStarExpand an exotic protocol 2024-11-19 20:20:03 +01:00
embedserv
emfio Improve loplugin:dyncastvisibility to check for non-inline key functions 2024-11-14 12:49:22 +01:00
eventattacher
extensions Use specific SvtModuleOptions::Is*Installed for clarity 2024-11-23 09:45:38 +01:00
external Revert "tdf#163945 present drawable immediately" 2024-11-22 15:21:54 +01:00
extras Revert "add an autotext 'common' directory like templates/common" 2024-11-18 22:24:27 +01:00
filter PVS: V547 Expression '!aHandlePropVec.empty()' is always true. 2024-11-22 14:05:13 +01:00
forms PVS: V1048 The 'nConcurrency' variable was assigned the same value. 2024-11-22 14:12:20 +01:00
formula
fpicker
framework add XInitialization to PathSettings 2024-11-21 12:11:33 +01:00
helpcompiler
helpcontent2@143fba581c Update git submodules 2024-11-22 12:50:37 +01:00
hwpfilter
i18nlangtag Related: tdf#163903 Add French (Republic of Guinea) {fr-GN} [0x940C] 2024-11-18 22:45:45 +01:00
i18npool Resolves: tdf#163903 Add French (Republic of Guinea) {fr-GN} locale data 2024-11-18 22:45:54 +01:00
i18nutil
icon-themes
idl
idlc/test/parser
include tdf#152299 - Remove unused define(s) from C/C++ files 2024-11-23 09:55:36 +01:00
instsetoo_native
io
ios
javaunohelper
jurt
jvmaccess
jvmfwk
l10ntools
librelogo
libreofficekit PVS: V547 Expression 'aUnoArgs.empty()' is always false 2024-11-22 13:09:16 +01:00
lingucomponent tdf#164006: Only use original word's positions, ignore extra encoded length 2024-11-23 10:03:41 +01:00
linguistic
lotuswordpro
m4
msicreator
net_ure
nlpsolver
o3tl
odk Parameterize lower case PRODUCTNAME in odk/config/setsdkenv_windows.bat 2024-11-13 23:04:53 +01:00
offapi tdf#36709 sw: Writer layout for font-relative first-line indent 2024-11-13 09:35:20 +01:00
officecfg tdf#148161 - Remove redundant attributes from configuration schema XML files 2024-11-22 08:03:03 +01:00
oovbaapi
oox use TOOLS_WARN_EXCEPTION to get exception details 2024-11-20 09:33:28 +01:00
opencl
osx
package loplugin:unusedmethods 2024-11-22 20:03:48 +01:00
pch
postprocess
pyuno tdf#163486: PVS: variable was assigned the same value 2024-11-13 20:12:29 +01:00
qadevOOo
readlicense_oo Some missing readme PRODUCTNAME parametrization 2024-11-13 08:03:53 +01:00
registry Limit to len the number of UTF-16 code units being read 2024-11-18 16:37:28 +01:00
remotebridges
reportbuilder
reportdesign tdf#36709 editeng: Layout for font-relative first-line indent 2024-11-13 15:01:11 +01:00
ridljar
sal Fix typos 2024-11-22 14:28:50 +01:00
salhelper
sax tdf#36709 sw: Writer layout for font-relative first-line indent 2024-11-13 09:35:20 +01:00
sc Use specific SvtModuleOptions::Is*Installed for clarity 2024-11-23 09:45:38 +01:00
scaddins
sccomp
schema tdf#160404 tdf#160535 tdf#160536 - sc improve sheet protection 2024-11-14 23:53:24 +01:00
scp2 add Santali (Ol-Chiki) languagepack (sat-Olck) 2024-11-22 19:08:52 +01:00
scripting loplugin:reftotemp in scripting..uui 2024-11-13 06:35:19 +01:00
sd Use specific SvtModuleOptions::Is*Installed for clarity 2024-11-23 09:45:38 +01:00
sdext tdf#145614 Convert #define to enum class 2024-11-12 15:27:34 +01:00
setup_native
sfx2 Use specific SvtModuleOptions::Is*Installed for clarity 2024-11-23 09:45:38 +01:00
shell
slideshow loplugin:unusedfields 2024-11-22 20:03:37 +01:00
smoketest
solenv add Santali (Ol-Chiki) languagepack (sat-Olck) 2024-11-22 19:08:52 +01:00
soltools
sot loplugin:reftotemp in sot..svl 2024-11-12 16:06:24 +01:00
starmath tdf#163486: PVS V1043 global object variable is declared in header (starmath) 2024-11-22 16:35:42 +01:00
static
stoc loplugin:reftotemp in sot..svl 2024-11-12 16:06:24 +01:00
store
svgio
svl cid#1634867 Using a moved object 2024-11-21 11:43:40 +01:00
svtools no longer need this svtools/drawinglayer hack 2024-11-21 14:31:49 +01:00
svx Use specific SvtModuleOptions::Is*Installed for clarity 2024-11-23 09:45:38 +01:00
sw tdf#162195: use SwFrame::IsHiddenNow when building index 2024-11-23 09:50:36 +01:00
swext
sysui
test loplugin:reftotemp in scripting..uui 2024-11-13 06:35:19 +01:00
testtools
toolkit consider VndSunStarExpand an exotic protocol 2024-11-19 20:20:03 +01:00
tools consider VndSunStarExpand an exotic protocol 2024-11-19 20:20:03 +01:00
translations@096ea21136 Update git submodules 2024-11-22 17:48:14 +01:00
ucb crashtesting: use after free 2024-11-17 20:16:40 +01:00
ucbhelper loplugin:reftotemp in scripting..uui 2024-11-13 06:35:19 +01:00
udkapi
uitest
UnoControls
unodevtools
unoidl
unoil
unotest
unotools Use specific SvtModuleOptions::Is*Installed for clarity 2024-11-23 09:45:38 +01:00
unoxml loplugin:reftotemp in scripting..uui 2024-11-13 06:35:19 +01:00
ure
uui tdf#130857 uui: Drop empty GtkSizeGroup from password.ui 2024-11-19 07:53:18 +01:00
vbahelper
vcl loplugin:unusedmethods 2024-11-22 20:03:48 +01:00
winaccessibility
wizards
writerperfect loplugin:reftotemp in writerperfect 2024-11-13 06:35:08 +01:00
xmlhelp
xmloff Related: tdf#160517 - chart odf: import/export formatted chart titles 2024-11-22 21:58:13 +01:00
xmlreader
xmlscript
xmlsecurity
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
.vsconfig
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in
config_host_lang.mk.in
configure.ac bump product version to 25.2.0.0.alpha1+ 2024-11-22 21:06:27 +01:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint
download.lst postgresql: upgrade to 14.15 2024-11-21 20:13:50 +01:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.help.md
README.md
README.Solaris
Repository.mk Revert "add an autotext 'common' directory like templates/common" 2024-11-18 22:24:27 +01:00
RepositoryExternal.mk
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.

SAST Tools

PVS-Studio - static analyzer for C, C++, C#, and Java code.