office-gobmx/starmath
Stephan Bergmann f8a30a87a9 Fix (mis-)uses of temporary O[U]StringLiteral
...as sub-expressions of ternary operators, which happened to keep compiling
after 4b9e440c51 "Turn OStringLiteral into a
consteval'ed, static-refcound rtl_String" and
e6dfaf9f44 "Turn OUStringLiteral into a
consteval'ed, static-refcound rtl_uString" because both branches are of the same
type O[U]StringLiteral<N>, and which didn't cause any issues because no dangling
pointers to those temporary objects escaped the surrounding full expressions.

This was found with an experimental build with VS 2022 with
--enable-latest-c++, which would support HAVE_CPP_CONSTEVAL after some linking
fix in the configure.ac detection code (which is forthcoming in a later commit)
and flagged all these uses in ternary operators as error C7595 "call to
immediate function is not a constant expression".  That error looks bogus (and
it also caused a false

> sd/source/ui/unoidl/unoobj.cxx(742): error C7595: 'Color::Color': call to immediate function is not a constant expression

so HAVE_CPP_CONSTEVAL will need to remain undefined for VS 2022 until that
compiler bug is fixed), but it nicely found all these cases that should arguably
be cleaned up.

Change-Id: I81de94e8af5a6c50e5fe7dfa1a4b253e0c2a68f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125082
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-12 11:23:14 +01:00
..
inc loplugin:finalclasses 2021-11-03 07:54:27 +01:00
qa
sdi
source Fix (mis-)uses of temporary O[U]StringLiteral 2021-11-12 11:23:14 +01:00
uiconfig/smath
util
AllLangMoTarget_sm.mk
CppunitTest_starmath_dialogs_test.mk
CppunitTest_starmath_export.mk
CppunitTest_starmath_import.mk
CppunitTest_starmath_qa_cppunit.mk
IwyuFilter_starmath.yaml
JunitTest_starmath_unoapi.mk
Library_sm.mk
Library_smd.mk
Makefile
Module_starmath.mk
README.md
UIConfig_smath.mk
visual-editor-todo

Formula Editor Code for LibreOffice Writer

Good overview from the original developer:

http://www.mail-archive.com/dev@sw.openoffice.org/msg00200.html