a245fd604c
The problem was, that the function only considered the target XSQLVAR's sqltype, ignoring sqlsubtype. This led to a situation when assignment to NUMERIC or DECIMAL was treated as assignment to an underlying type, like SQL_LONG, performed without taking scale into account. Use ColumnTypeInfo and its getSdbcType, which provides the correct type, and add missing cases to setString. Fix setObjectWithInfo to make sure that the resulting number is correct. This also fixes export of NUMERIC/DECIMAL in HSQL migration. Previously it miscalculated the position of decimal separator, which accidentally went unnoticed in the existing unit test, because it was compensated by broken handling in Firebird SDBC for the specific numbers in the test. OResultSet::makeNumericString was also fixed; it didn't handle properly the case of zero fractional part: initial number 1200 with scale 2 was converted to a string "12.000" instead of expected "12.00". Change-Id: I5adac59737d21f91c782fe867d4827fb880fd62a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170812 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins |
||
|---|---|---|
| .. | ||
| inc | ||
| qa | ||
| source | ||
| uiconfig | ||
| util | ||
| win32/source/odbcconfig | ||
| AllLangMoTarget_dba.mk | ||
| CppunitTest_dbaccess_CRMDatabase_test.mk | ||
| CppunitTest_dbaccess_dialog_save.mk | ||
| CppunitTest_dbaccess_dialogs_test.mk | ||
| CppunitTest_dbaccess_embeddeddb_performancetest.mk | ||
| CppunitTest_dbaccess_empty_stdlib_save.mk | ||
| CppunitTest_dbaccess_firebird_test.mk | ||
| CppunitTest_dbaccess_hsqlbinary_import.mk | ||
| CppunitTest_dbaccess_hsqldb_test.mk | ||
| CppunitTest_dbaccess_hsqlschema_import.mk | ||
| CppunitTest_dbaccess_nolib_save.mk | ||
| CppunitTest_dbaccess_RowSetClones.mk | ||
| CppunitTest_dbaccess_tdf119625.mk | ||
| CppunitTest_dbaccess_tdf126268.mk | ||
| Executable_odbcconfig.mk | ||
| IwyuFilter_dbaccess.yaml | ||
| JunitTest_dbaccess_complex.mk | ||
| JunitTest_dbaccess_unoapi.mk | ||
| Library_dba.mk | ||
| Library_dbahsql.mk | ||
| Library_dbaxml.mk | ||
| Library_dbu.mk | ||
| Library_sdbt.mk | ||
| Makefile | ||
| Module_dbaccess.mk | ||
| PythonTest_dbaccess_python.mk | ||
| README.md | ||
| UIConfig_dbaccess.mk | ||
| UIConfig_dbapp.mk | ||
| UIConfig_dbbrowser.mk | ||
| UIConfig_dbquery.mk | ||
| UIConfig_dbrelation.mk | ||
| UIConfig_dbtable.mk | ||
| UIConfig_dbtdata.mk | ||
Database Access Tools for LibreOffice Base DB Apps
Database access tools, for base database application
Builds on top of drivers in connectivity.