Test repository to check push and ssh key
Find a file
Jonathan Clark ab0a4543ca tdf#124116 Correct Writer text shaping across formatting changes
Previously, Writer performed shaping for each span of text separately.
In certain situations, this caused incorrect glyph use, or incorrect
glyph positioning. This change updates Writer so it will also consider
neighboring text while performing shaping.

This change resolves the outstanding duplicates filed against tdf#61444.
As a side effect, this change also fixes tdf#134226.

In addition to the shaping fix, this change implements rendering for
individually-styled glyphs, which is required to fix tdf#71956. However,
this change does not implement diacritic selection, which is also
required for that issue.

Change-Id: Iab4774ffaab5ad6113778c54d02cb260a70c1010
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167699
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
2024-05-22 19:20:38 +02:00
.git-hooks Revert "Drop allownonascii check from pre-commit checks" 2023-12-02 21:55:33 +01:00
.github
.vscode vscode-ide-integration: add license-header template (snippet) 2023-11-06 13:55:12 +01:00
accessibility Change for loop to have getAccessibleChildCount in accessibletabbar 2024-05-20 07:47:44 +02:00
android Update translation files for android-viewer 2024-05-17 10:48:22 +02:00
animations loplugin:ostr avmedia 2024-05-06 15:14:09 +02:00
apple_remote Drop C/C++ DEBUG macro 2024-03-21 16:30:59 +01:00
avmedia tdf#145735 avmedia qt: Use QtMultimedia for Qt 6 media playback 2024-05-21 17:28:04 +02:00
basctl loplugin:ostr in basctl 2024-05-03 18:38:56 +02:00
basegfx tdf#147906 implement hypot function for s1 x s1 + s2 x s2 statements 2024-05-20 08:20:40 +02:00
basic loplugin:ostr basic 2024-05-06 13:56:49 +02:00
bean
bin tdf#158803 Remove E999: SyntaxError's and some other minor edits 2024-05-21 09:59:45 +02:00
binaryurp drop requirement for rtl_random_getBytes to have "Pool" arg 2024-05-08 11:29:54 +02:00
bridges WaE: C6011 Dereferencing NULL pointer warnings 2024-05-11 11:09:49 +02:00
canvas cid#1598237 Uncaught exception 2024-05-18 16:27:04 +02:00
chart2 tdf#159547 of-pie connector lines aren't quite geometrically correct 2024-05-16 10:56:21 +02:00
cli_ure introduce SAL_RET_MAYBENULL 2024-05-17 17:37:58 +02:00
codemaker WaE: C6011 Dereferencing NULL pointer warnings 2024-04-30 14:48:15 +02:00
comphelper loplugin:ostr in various 2024-05-20 22:09:56 +02:00
compilerplugins tdf#158803 compilerplugins: remove semicolons; improve membership checks 2024-05-21 11:40:31 +02:00
config_host tdf#145735 avmedia qt: Use QtMultimedia for Qt 6 media playback 2024-05-21 17:28:04 +02:00
configmgr no need to convert from Sequence to std::set here 2024-05-10 10:44:13 +02:00
connectivity use more officecfg in OSDBCDriverManager 2024-05-15 10:05:45 +02:00
cppcanvas loplugin:ostr in cppcanvas 2024-05-07 12:53:11 +02:00
cppu elide some OUString temporaries 2024-05-02 02:51:23 +02:00
cppuhelper drop requirement for rtl_random_getBytes to have "Pool" arg 2024-05-08 11:29:54 +02:00
cpputools loplugin:ostr in various 2024-05-20 22:09:56 +02:00
cui tdf#69724 Allow to change default bullet symbols in UI 2024-05-21 12:04:25 +02:00
dbaccess WaE: C6011 Dereferencing NULL pointer warnings 2024-05-17 12:57:37 +02:00
desktop Drop remnants of a long-obsolete hack 2024-05-20 17:31:19 +02:00
dictionaries@7272a82714 Update git submodules 2024-05-19 05:35:08 +02:00
distro-configs add --enable-hardening-flags to enable compiler hardening flags 2024-04-19 21:01:53 +02:00
docmodel loplugin:ostr in various 2024-05-20 22:09:56 +02:00
drawinglayer tdf#161154: pass "scaling is done externally" information down the stack 2024-05-18 11:03:58 +02:00
editeng tdf#124116 Correct Writer text shaping across formatting changes 2024-05-22 19:20:38 +02:00
embeddedobj loplugin:ostr in embeddedobj 2024-05-08 08:15:07 +02:00
embedserv tdf#148251 Use std::swap instead of using temporary values 2024-04-08 20:45:39 +02:00
emfio loplugin:ostr in emfio 2024-05-07 18:15:01 +02:00
eventattacher loplugin:ostr in various 2024-05-20 22:09:56 +02:00
extensions WaE: C6011 Dereferencing NULL pointer warnings 2024-05-08 15:11:42 +02:00
external curl: Upgrade to 8.8.0 2024-05-22 15:14:44 +02:00
extras tdf#160712 tdf#160899 Update Candy template 2024-05-07 11:42:37 +02:00
filter createFromAscii -> OUString literals in SvxMSDffManager 2024-05-14 18:47:20 +02:00
forms don't need -I ... YaccTarget/connectivity/source/parse in forms 2024-05-20 12:13:38 +02:00
formula Fix typo in code 2024-05-21 22:14:06 +02:00
fpicker loplugin:ostr in fpicker 2024-05-08 21:23:12 +02:00
framework VCL: Windows: more usecases for FlashWindow() API to inform on changes 2024-05-16 12:50:31 +02:00
helpcompiler WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 09:17:34 +02:00
helpcontent2@74121a4068 Update git submodules 2024-05-22 17:24:39 +02:00
hwpfilter loplugin:ostr in hwpfilter 2024-05-09 13:29:23 +02:00
i18nlangtag loplugin:ostr in various 2024-05-20 22:09:56 +02:00
i18npool loplugin:ostr in various 2024-05-20 22:09:56 +02:00
i18nutil loplugin:ostr in various 2024-05-20 22:09:56 +02:00
icon-themes tdf#160349: add .uno:ChangeTheme to notebookbar to toggle dark mode 2024-05-03 17:58:15 +02:00
idl make the slot data constinit 2024-05-02 14:37:56 +02:00
idlc/test/parser
include tdf#124116 Correct Writer text shaping across formatting changes 2024-05-22 19:20:38 +02:00
instsetoo_native MSI: Adds the missing ExtendedType column in the CustomAction table 2024-05-16 15:13:09 +02:00
io loplugin:ostr in io 2024-05-09 12:48:17 +02:00
ios
javaunohelper loplugin:ostr in javaunohelper 2024-05-09 17:59:45 +02:00
jurt makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo) 2024-05-06 11:40:45 +02:00
jvmaccess
jvmfwk WaE: C6011 Dereferencing NULL pointer warnings 2024-05-12 22:14:19 +02:00
l10ntools cid#1546281 COPY_INSTEAD_OF_MOVE 2023-12-10 11:57:12 +01:00
librelogo tdf#158803 F821: remove unused variables and unused imports in librelogo/ 2024-05-21 21:12:08 +02:00
libreofficekit LOK: send inner text boundry information of shapes/textbox on change 2024-03-08 10:55:26 +01:00
lingucomponent loplugin:ostr in lingucomponent 2024-05-09 17:59:34 +02:00
linguistic loplugin:ostr in linguistic 2024-05-10 10:44:33 +02:00
lotuswordpro cid#1597280 Dereference null return value 2024-05-11 14:30:33 +02:00
m4
msicreator createmsi: retrieve file handle explicitely so we can close it at the end 2023-11-17 17:34:52 +01:00
nlpsolver Double values comparison changed to compare method. 2024-04-29 15:40:27 +02:00
o3tl loplugin:ostr in various 2024-05-20 22:09:56 +02:00
odk tdf#158803 pyflakes F821: undefined name 'com' and remove bare except clauses 2024-05-21 11:43:46 +02:00
offapi tdf#157657 - sc: add option to make data validity case-sensitive 2024-05-13 17:20:20 +02:00
officecfg tdf#33603: sd: make state of notes pane persist across runs 2024-05-16 15:01:55 +02:00
oovbaapi tdf#157657 - sc: add option to make data validity case-sensitive 2024-05-13 17:20:20 +02:00
oox WaE: C6011 Dereferencing NULL pointer warnings 2024-05-16 20:31:57 +02:00
opencl loplugin:ostr in various 2024-05-20 22:09:56 +02:00
osx
package drop requirement for rtl_random_getBytes to have "Pool" arg 2024-05-08 11:29:54 +02:00
pch
postprocess loplugin:ostr in various 2024-05-20 22:09:56 +02:00
pyuno workaround clang segfault on macos-intel 2024-05-11 14:50:28 +02:00
qadevOOo Tie javac -g option to --enable-symbols instead of gb_DEBUGLEVEL 2024-03-21 09:41:57 +01:00
readlicense_oo update credits 2024-05-07 19:20:16 +02:00
registry loplugin:ostr in various 2024-05-20 22:09:56 +02:00
remotebridges loplugin:ostr in various 2024-05-20 22:09:56 +02:00
reportbuilder reportbuilder: remove unused config files 2023-12-18 07:57:24 +01:00
reportdesign replace createFromAscii with OUString literals in OConfigurationNode 2024-05-11 23:05:38 +02:00
ridljar makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
sal Unit test for tdf#160985 2024-05-15 18:02:32 +02:00
salhelper Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
sax loplugin:ostr in sax 2024-05-10 12:40:26 +02:00
sc Partially revert 860d11230d "sc: check GetActiveViewShell()" 2024-05-22 15:40:50 +02:00
scaddins loplugin:ostr in various 2024-05-20 22:09:56 +02:00
sccomp loplugin:ostr in sccomp 2024-05-13 14:43:56 +02:00
schema tdf#132599 sw schema xmloff: add hyphenation-keep-type='always' 2024-05-07 13:58:28 +02:00
scp2 makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
scripting Fix typo 2024-05-16 02:00:23 +02:00
sd Drop unused ATTR_OPTIONS_SNAP 2024-05-22 16:26:58 +02:00
sdext loplugin:ostr in sdext 2024-05-16 08:49:45 +02:00
setup_native makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
sfx2 sfx2: bGlobalOnly is always false 2024-05-22 12:22:47 +02:00
shell loplugin:ostr in shell 2024-05-16 08:49:30 +02:00
slideshow loplugin:ostr in slideshow 2024-05-13 14:44:04 +02:00
smoketest loplugin:ostr in various 2024-05-20 22:09:56 +02:00
solenv tdf#115357: Set Start Menu folder under Windows to \LibreOffice\ 2024-05-18 12:09:12 +02:00
soltools Drop C/C++ DEBUG macro 2024-03-21 16:30:59 +01:00
sot loplugin:ostr in sot 2024-05-13 20:11:36 +02:00
starmath loplugin:ostr in starmath 2024-05-14 10:13:45 +02:00
static Embind: Fix uno_Any.get for null interface values 2024-05-09 18:48:29 +02:00
stoc loplugin:ostr in stoc 2024-05-13 20:11:48 +02:00
store loplugin:ostr in various 2024-05-20 22:09:56 +02:00
svgio loplugin:ostr in svgio 2024-05-15 12:53:22 +02:00
svl loplugin:ostr in svl 2024-05-14 09:03:47 +02:00
svtools Resolves: tdf#161133 read-only widget should have deactivated calendar 2024-05-18 16:34:57 +02:00
svx svx: prefix members of SdrUndoDelPage 2024-05-21 13:05:42 +02:00
sw tdf#124116 Correct Writer text shaping across formatting changes 2024-05-22 19:20:38 +02:00
swext makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo) 2024-05-06 11:40:45 +02:00
sysui makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
test loplugin:ostr in test 2024-05-14 11:47:53 +02:00
testtools loplugin:ostr in various 2024-05-20 22:09:56 +02:00
toolkit loplugin:ostr in toolkit 2024-05-15 14:22:39 +02:00
tools loplugin:ostr in tools 2024-05-16 14:49:58 +02:00
translations@fa6c5405a7 Update git submodules 2024-05-14 19:31:56 +02:00
ucb Revert "LOK: Allow image upload from WOPI-like host with self-signed cert" 2024-05-17 07:49:15 +02:00
ucbhelper loplugin:ostr in ucbhelper 2024-05-16 14:49:15 +02:00
udkapi Move org.libreoffice.embindtest from udkapi to offapi 2024-04-11 15:22:40 +02:00
uitest fix comparison of UIObject's inside UITests 2024-03-28 17:17:32 +01:00
UnoControls loplugin:ostr in various 2024-05-20 22:09:56 +02:00
unodevtools loplugin:ostr in various 2024-05-20 22:09:56 +02:00
unoidl makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
unoil makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
unotest loplugin:ostr in various 2024-05-20 22:09:56 +02:00
unotools loplugin:ostr in unotools 2024-05-16 11:36:10 +02:00
unoxml loplugin:ostr in unoxml 2024-05-16 13:14:09 +02:00
ure
uui loplugin:ostr in uui 2024-05-16 08:49:53 +02:00
vbahelper loplugin:ostr in vbahelper 2024-05-14 15:14:51 +02:00
vcl tdf#124116 Correct Writer text shaping across formatting changes 2024-05-22 19:20:38 +02:00
winaccessibility wina11y: Return E_INVALIDARG if out param is null 2024-05-07 06:06:45 +02:00
wizards makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
writerperfect loplugin:ostr in writerperfect 2024-05-16 08:49:38 +02:00
xmerge
xmlhelp use more officecfg in xmlhelp::Databases 2024-05-16 10:57:12 +02:00
xmloff Related: tdf#145972 sw images: fix rounding error in relative size calculation 2024-05-22 10:27:36 +02:00
xmlreader loplugin:ostr in various 2024-05-20 22:09:56 +02:00
xmlscript loplugin:ostr in xmlscript 2024-05-16 08:50:01 +02:00
xmlsecurity WaE: C6011 Dereferencing NULL pointer warnings 2024-05-16 20:31:57 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs tdf#157638 Added to git blame ignore list 2023-12-29 17:01:32 +01:00
.gitattributes
.gitignore add secmod.db files to .gitignore 2024-01-15 08:48:52 +01:00
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in tdf#145735 avmedia qt: Use QtMultimedia for Qt 6 media playback 2024-05-21 17:28:04 +02:00
config_host_lang.mk.in
configure.ac tdf#145735 avmedia qt: Use QtMultimedia for Qt 6 media playback 2024-05-21 17:28:04 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint Add some entries into cpp.hint 2024-04-24 09:43:42 +02:00
download.lst openldap: upgrade to 2.6.8 2024-05-22 15:54:01 +02:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit When no branch is specified, fallback to the tracked branch first 2024-04-11 14:08:29 +02:00
Makefile.fetch Fail early when external tarball can't be fetched 2024-04-26 10:46:04 +02:00
Makefile.gbuild Create MAR updates from msi rather than from archive 2024-01-22 16:06:42 +01:00
Makefile.in add --with-keep-awake switch to prevent going into sleep/suspend 2024-04-26 23:10:22 +02:00
README.cross
README.help.md
README.md fix broken link to OSI image in README.md 2024-04-22 23:26:08 +02:00
README.Solaris
Repository.mk tdf#145735 avmedia qt: Use QtMultimedia for Qt 6 media playback 2024-05-21 17:28:04 +02:00
RepositoryExternal.mk Revert "make skia into static library" 2024-05-07 20:34:39 +02:00
RepositoryFixes.mk Experimental support for latest Emscripten (and Qt6) 2024-01-29 19:51:57 +01:00
RepositoryModule_build.mk Extract embindmaker from cppumaker into its own tool 2024-01-21 15:51:39 +01:00
RepositoryModule_host.mk move writerfilter inside sw 2024-04-18 09:16:12 +02:00
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt update tsan suppressions 2023-12-06 20:27:49 +01:00

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.