f824c4f23c
Change-Id: I987d6d60ca2d1e8ed8b8cde1e0c7996c0fff71b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160006 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
163 lines
11 KiB
C++
163 lines
11 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include "sal/config.h"
|
|
|
|
#include <string>
|
|
#include <string_view>
|
|
|
|
#include "rtl/ustring.hxx"
|
|
|
|
#define M(arg) f(arg, arg)
|
|
|
|
struct S
|
|
{
|
|
OUString s;
|
|
};
|
|
|
|
void takeOstring(OString const&);
|
|
|
|
void takeOustring(OUString const&);
|
|
|
|
void f(OUString const&, OUString const&);
|
|
|
|
void takeStdString(std::string const&);
|
|
|
|
void takeStdString(std::u16string const&);
|
|
|
|
void takeStdView(std::string_view);
|
|
|
|
void takeStdView(std::u16string_view);
|
|
|
|
void f()
|
|
{
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
OString s1o = "foo";
|
|
(void)s1o;
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
OString s2o = (("foo"));
|
|
(void)s2o;
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
OString s3o("foo");
|
|
(void)s3o;
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
OString s4o((("foo")));
|
|
(void)s4o;
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring(OString("foo"));
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring(((OString((("foo"))))));
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring(OString("foo", rtl::libreoffice_internal::Dummy()));
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring(((OString((("foo")), rtl::libreoffice_internal::Dummy()))));
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring("foo");
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring((("foo")));
|
|
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
OString s1o8 = u8"foo";
|
|
(void)s1o8;
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
OString s2o8 = ((u8"foo"));
|
|
(void)s2o8;
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
OString s3o8(u8"foo");
|
|
(void)s3o8;
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
OString s4o8(((u8"foo")));
|
|
(void)s4o8;
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring(OString(u8"foo"));
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring(((OString(((u8"foo"))))));
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring(OString(u8"foo", rtl::libreoffice_internal::Dummy()));
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring(((OString(((u8"foo")), rtl::libreoffice_internal::Dummy()))));
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring(u8"foo");
|
|
// expected-error-re@+1 {{use a _ostr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOstring(((u8"foo")));
|
|
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
OUString s1u = "foo";
|
|
(void)s1u;
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
OUString s2u = (("foo"));
|
|
(void)s2u;
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
OUString s3u("foo");
|
|
(void)s3u;
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
OUString s4u((("foo")));
|
|
(void)s4u;
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOustring(OUString("foo"));
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOustring(((OUString((("foo"))))));
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOustring(OUString("foo", rtl::libreoffice_internal::Dummy()));
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOustring(((OUString((("foo")), rtl::libreoffice_internal::Dummy()))));
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOustring("foo");
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
takeOustring((("foo")));
|
|
|
|
OString s9;
|
|
// expected-error@+1 {{use a _ostr user-defined string literal instead of assigning from an ordinary string literal [loplugin:ostr]}}
|
|
s9 = "foo";
|
|
// expected-error@+1 {{use a _ostr user-defined string literal instead of assigning from an ordinary string literal [loplugin:ostr]}}
|
|
s9 = (("foo"));
|
|
// expected-error@+1 {{use a _ostr user-defined string literal instead of assigning from an ordinary string literal [loplugin:ostr]}}
|
|
s9.operator=("foo");
|
|
// expected-error@+1 {{use a _ostr user-defined string literal instead of assigning from an ordinary string literal [loplugin:ostr]}}
|
|
s9.operator=((("foo")));
|
|
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
S s10 = { "foo" };
|
|
|
|
// Only generate one warning here, not two, for a macro argument used twice in the macro's
|
|
// expansion:
|
|
// expected-error-re@+1 {{use a _ustr user-defined string literal instead of constructing an instance of '{{(rtl::)?}}OUString' from an ordinary string literal [loplugin:ostr]}}
|
|
M("foo");
|
|
|
|
// expected-note@+1 {{intermediary variable l1 declared here [loplugin:ostr]}}
|
|
constexpr OStringLiteral l1("foo");
|
|
// expected-error@+1 {{directly use a _ostr user-defined string literal instead of introducing the intermediary 'OStringLiteral' variable l1 [loplugin:ostr]}}
|
|
(void)l1;
|
|
// expected-error@+1 {{use 'OString', created from a _ostr user-defined string literal, instead of 'OStringLiteral' for the variable l2 [loplugin:ostr]}}
|
|
constexpr OStringLiteral l2("foo");
|
|
(void)l2;
|
|
(void)l2;
|
|
// expected-note@+1 {{intermediary variable l3 declared here [loplugin:ostr]}}
|
|
OUStringLiteral l3(u"foo");
|
|
// expected-error@+1 {{directly use a _ustr user-defined string literal instead of introducing the intermediary 'OUStringLiteral' variable l3 [loplugin:ostr]}}
|
|
(void)l3;
|
|
// expected-error@+1 {{use 'OUString', created from a _ustr user-defined string literal, instead of 'OUStringLiteral' for the variable l4 [loplugin:ostr]}}
|
|
OUStringLiteral l4(u"foo");
|
|
(void)l4;
|
|
(void)l4;
|
|
}
|
|
|
|
void passLiteral()
|
|
{
|
|
// expected-error-re@+1 {{directly use a 'std::string' (aka 'basic_string<char{{(, char_traits<char>, allocator<char>)?}}>') value instead of a _ostr user-defined string literal [loplugin:ostr]}}
|
|
takeStdString(std::string(""_ostr));
|
|
// expected-error-re@+1 {{directly use a 'std::u16string' (aka 'basic_string<char16_t{{(, char_traits<char16_t>, allocator<char16_t>)?}}>') value instead of a _ustr user-defined string literal [loplugin:ostr]}}
|
|
takeStdString(std::u16string(u""_ustr));
|
|
// expected-error@+1 {{directly use a 'std::string_view' (aka 'basic_string_view<char>') value instead of a _ostr user-defined string literal [loplugin:ostr]}}
|
|
takeStdView(""_ostr);
|
|
// expected-error@+1 {{directly use a 'std::u16string_view' (aka 'basic_string_view<char16_t>') value instead of a _ustr user-defined string literal [loplugin:ostr]}}
|
|
takeStdView(u""_ustr);
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|