f3e7004794
... representation of given decimal. Use dtoa.c from https://www.netlib.org/fp/dtoa.c to build a custom static library that doesn't use current locale (unlike strtod from stdlib.h). This is the implementation used by e.g. python and nss (search for "dtoa.c" under UnpackedTarball). To avoid name clash with the standard strtod, rename the function to strtod_nolocale. Size of buffer on stack in ImpSvNumberInputScan::StringToDouble is 256 characters. Logging function usage in make check, of ~124 600 invocations, the longest string was 14 characters, average being 2.1 characters. So heap allocation is unlikely in scenarios with intensive function usage. After std::from_chars is available in baseline compilers, external library can be dropped, and call to strtod_nolocale replaced with the standard function. The artifact at https://dev-www.libreoffice.org/src/dtoa-20180411.tgz is created with mkdir dtoa && mkdir dtoa/src && wget https://www.netlib.org/fp/dtoa.c -O dtoa/src/dtoa.c && \ printf 'd8bab255476f39ea495c8c8ed164f9077da926e6ca7afb9ad3c56d337c4484fe dtoa/src/dtoa.c' | sha256sum -c && \ tar -c --owner=0 --group=0 --mode=go=r,u=rw --mtime='Wed, 11 Apr 2018 15:59:39 GMT' dtoa/src/dtoa.c | gzip -n > dtoa-20180411.tgz && \ printf '0082d0684f7db6f62361b76c4b7faba19e0c7ce5cb8e36c4b65fea8281e711b4 dtoa-20180411.tgz' | sha256sum -c (where the date "Wed, 11 Apr 2018 15:59:39 GMT" is from `wget -S https://www.netlib.org/fp/dtoa.c` "Last-Modified: Wed, 11 Apr 2018 15:59:39 GMT" header). Change-Id: Ia61b7678e257c4bc1ff193f3f856d611aa5c1a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88854 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> |
||
---|---|---|
.. | ||
inc/pch | ||
qa | ||
source | ||
unx/source/svdde | ||
util | ||
AllLangMoTarget_svl.mk | ||
CppunitTest_svl_inetcontenttype.mk | ||
CppunitTest_svl_itempool.mk | ||
CppunitTest_svl_items.mk | ||
CppunitTest_svl_lngmisc.mk | ||
CppunitTest_svl_lockfiles.mk | ||
CppunitTest_svl_notify.mk | ||
CppunitTest_svl_qa_cppunit.mk | ||
CppunitTest_svl_urihelper.mk | ||
IwyuFilter_svl.yaml | ||
JunitTest_svl_complex.mk | ||
Library_fsstorage.mk | ||
Library_passwordcontainer.mk | ||
Library_svl.mk | ||
Makefile | ||
Module_svl.mk | ||
README |
Contains non-graphical helper code for office applications. Specifically this module does not depend on or use includes from module vcl. Originally all code in svtools that did not depend on vcl was split off into this svl ("svtools light") module. In particular the SfxItemSet is a property-bag like container that stores arbitrary sets of properties for everything from text run formats, to Chart regression line properties. There are lots of other useful helpers in here for various office tasks; much of this code was originally moved from svx/sfx2. == Items, Pools and Sets == === SfxPoolItem === A small reference counted piece of data. Many subclasses, each with a unique integer to identify its type (WhichId). Can be compared for equality (operator==), Clone()d, and converted to/from uno::Any (QueryValue/PutValue). A pool item may have value semantics ("poolable"), meaning that there will generally be only one instance that compares equal per item pool, or not, in which case the item will be Clone()d quite a bit. === SfxItemPool === Usually there is one item pool per document, with a range of valid WhichIds that is specific to the type of document. The item pool owns all instances of SfxPoolItem or its subclasses that have ever been added to an item set. It also contains a default item for every WhichId, which will be (depending on parameters) returned from item sets if the set does not contain an item at this WhichId. === SfxItemSet === The item set can be created with a user-supplied range of WhichIds; it will accept SfxPoolItems with matching WhichIds and ignore attempts to insert items with non-matching WhichIds. Items that are successfully inserted into the set will be stored in the set's SfxItemPool, and for poolable items only a single instance that compares equal under the predicate operator== will be stored in the pool, regardless of how many sets contain it, thus conserving memory. There are members m_pWhichRanges for the valid ranges (as pairs of WhichIds), m_nCount for the number of items contained, and m_pItems for the pointers to the actual items.