aef7feb3e6
"Find explicit casts from signed to unsigned integer in comparison against
unsigned integer, where the cast is presumably used to avoid warnings about
signed vs. unsigned comparisons, and could thus be replaced with
o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx)
o3tl::make_unsigned requires its argument to be non-negative, and there is a
chance that some original code like
static_cast<sal_uInt32>(n) >= c
used the explicit cast to actually force a (potentially negative) value of
sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the
cast to avoid a false "signed vs. unsigned comparison" warning in a case where
n is known to be non-negative. It appears that restricting this plugin to non-
equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=)
is a useful heuristic to avoid such false positives. The only remainging false
positive I found was
|
||
|---|---|---|
| .. | ||
| inc | ||
| qa | ||
| source | ||
| uiconfig/ui | ||
| AllLangMoTarget_flt.mk | ||
| Configuration_filter.mk | ||
| CppunitTest_filter_dialogs_test.mk | ||
| CppunitTest_filter_dxf_test.mk | ||
| CppunitTest_filter_eps_test.mk | ||
| CppunitTest_filter_met_test.mk | ||
| CppunitTest_filter_msfilter.mk | ||
| CppunitTest_filter_pcd_test.mk | ||
| CppunitTest_filter_pcx_test.mk | ||
| CppunitTest_filter_pict_test.mk | ||
| CppunitTest_filter_ppm_test.mk | ||
| CppunitTest_filter_priority.mk | ||
| CppunitTest_filter_psd_test.mk | ||
| CppunitTest_filter_ras_test.mk | ||
| CppunitTest_filter_textfilterdetect.mk | ||
| CppunitTest_filter_tga_test.mk | ||
| CppunitTest_filter_tiff_test.mk | ||
| CppunitTest_filter_xslt.mk | ||
| CustomTarget_svg.mk | ||
| IwyuFilter_filter.yaml | ||
| JunitTest_filter_complex.mk | ||
| Library_filterconfig.mk | ||
| Library_flash.mk | ||
| Library_gie.mk | ||
| Library_graphicfilter.mk | ||
| Library_icg.mk | ||
| Library_msfilter.mk | ||
| Library_odfflatxml.mk | ||
| Library_pdffilter.mk | ||
| Library_storagefd.mk | ||
| Library_svgfilter.mk | ||
| Library_t602filter.mk | ||
| Library_textfd.mk | ||
| Library_xmlfa.mk | ||
| Library_xmlfd.mk | ||
| Library_xsltdlg.mk | ||
| Library_xsltfilter.mk | ||
| Makefile | ||
| Module_filter.mk | ||
| Package_docbook.mk | ||
| Package_xhtml.mk | ||
| Package_xslt.mk | ||
| README | ||
| UIConfig_filter.mk | ||
Filter registration and some simple filters (also descriptions). Desperate splitting of code into small shared libraries for historical reasons presumably (OS/2 and Windows 3.x). The libraries produced from the code in each subdirectory of filter/source/graphicfilter are graphic format import or export filters. But they don't have uniform API. Some have either a GraphicImport or GraphicExport entry point, and are loaded and used in a uniform fashion from code in svtools/source/filter/filter.cxx. Others have different API and are loaded from other places. For instance "icgm" has ImportCGM, and is loaded and used by sd/source/filter/cgm/sdcgmfilter.cxx (!). Svgreader is used for "File->Open" and then to choose the svg file. For "Insert->Picture->From File", see svgio/source/svgreader directory. ==================== filter configuration ==================== The filter configuration consists of two parts, the type definition in filter/source/config/fragments/types/ and the actual filter definition in filter/source/config/fragments/filters/. Each file type e.g. text file should be represented by exactly one type definition. This type can then be referenced by several different filters, e.g. calc text, writer text.