office-gobmx

History

Mike Kaganski afa6a77493 Don't crash on exiting print preview with Notebookbar Crash caused by this sequence (tested in Writer): 1. Closing print preview, frame is attached to controller; 2. This calls SfxNotebookBar::StateMethod 3. There notebookbar's listener is added to list of the controller's context change event listeners 4. Then in SwPagePreview::~SwPagePreview, notebookbar's listener is added to that list again 5. ContextChangeEventMultiplexer::addContextChangeEventListener detects second addition, and throws an unhandled exception. I don't know why starting listening is needed in SwPagePreview dtor; unfortunately commit `d05b7b32d9` doesn't say much about context and reasons. ControlListener is renamed to ControlListenerForCurrentController to emphasize that it operates on the current controller of notebookbar's frame; and its bListen parameter meaning was reverted: previously its "true" value awkwardly meant "stop listening". All direct operations with listener of notebookbar are replaced with calls to notebookbar's methods. In ContextChangeEventMultiplexer::addContextChangeEventListener, uno::UNO_QUERY_THROW was replaced with uno::UNO_QUERY, because not only chart controller may appear here, and it's not an error: e.g. SfxBaseController doesn't implement lang::XServiceInfo. Regression after commit `d05b7b32d9`. Change-Id: Ief1aed188d8f02a6cfe3ea25f4d082dfdf449f32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86257 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>		2020-01-06 11:29:17 +01:00
..
dtd
inc	tdf#46037: use officecfg/Setup	2019-12-23 07:41:49 +01:00
qa	Fix typo	2019-12-28 11:58:16 +01:00
source	Don't crash on exiting print preview with Notebookbar	2020-01-06 11:29:17 +01:00
uiconfig/startmodule/menubar
util
AllLangMoTarget_fwk.mk
CppunitTest_framework_dispatch.mk
IwyuFilter_framework.yaml
JunitTest_framework_complex.mk
JunitTest_framework_unoapi.mk
Library_fwe.mk
Library_fwi.mk
Library_fwk.mk
Library_fwl.mk
Library_fwm.mk	tdf#46037: remove configurationhelper in framework/helponstartup	2019-12-23 11:48:26 +01:00
Makefile
Module_framework.mk
Package_dtd.mk
README
UIConfig_startmodule.mk

README

Toolbars, menus, UNO stuff, including accelerators and interaction, etc.

See also:
http://wiki.openoffice.org/wiki/Framework