strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
office-gobmx/sd
History
Miklos Vajna 014f33066a svx: fix crash with active text edit vs slide delete 
The problem is that SdrObjEditView::HideSdrPage() may delete
SdrPaintView::mpPageView when it calls SdrGlueEditView::HideSdrPage().

But SdrObjEditView::pTextEditPV is a non-owning reference to that.

GetTextEditBackgroundColor() in svx/ calls
SdrObjEditView::GetTextEditPageView(), so in case
SdrObjEditView::pTextEditPV is not cleared, we would access a deleted
SdrPageView.

Change-Id: I948bae8e0e8d557e38aa8f243e9eea522b21a043
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115324
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2021-05-10 15:19:52 +02:00
..
inc loplugin:constmethod 2021-05-05 18:50:51 +02:00
qa svx: fix crash with active text edit vs slide delete 2021-05-10 15:19:52 +02:00
res
sdi
source tdf#124457 PPTX animation: export repeatCount 2021-05-10 11:40:18 +02:00
uiconfig add missing truncate-multiline properties 2021-05-07 09:46:02 +02:00
util
workben
xml
xsl
AllLangMoTarget_sd.mk
CppunitTest_sd_activex_controls_tests.mk
CppunitTest_sd_dialogs_test.mk
CppunitTest_sd_export_ooxml1.mk
CppunitTest_sd_export_ooxml2.mk
CppunitTest_sd_export_tests.mk
CppunitTest_sd_filter_eppt.mk
CppunitTest_sd_filters_test.mk
CppunitTest_sd_html_export_tests.mk
CppunitTest_sd_import_tests.mk
CppunitTest_sd_import_tests_smartart.mk
CppunitTest_sd_layout_tests.mk
CppunitTest_sd_misc_tests.mk
CppunitTest_sd_pdf_import_test.mk
CppunitTest_sd_svg_export_tests.mk
CppunitTest_sd_tiledrendering.mk
CppunitTest_sd_uiimpress.mk
CppunitTest_sd_uimpress.mk
IwyuFilter_sd.yaml
JunitTest_sd_unoapi.mk
Library_sd.mk
Library_sdd.mk
Library_sdfilt.mk
Library_sdui.mk
Makefile
Module_sd.mk
Package_opengl.mk
Package_web.mk
Package_xml.mk
README.md
README_REMOTE
UIConfig_sdraw.mk
UIConfig_simpress.mk
UITest_impress_tests.mk
UITest_sd_findReplace.mk

README.md

LibreOffice Impress / Draw Application

The core directory for the impress/draw applications.

Think of impress as a hack on top of draw.

sd module contains impress/draw specific code, non-shared UI and part of ppt and pptx filter, few other filters too.

the slideshow UI lives here as well, the slideshow engine is in slideshow module though (including the 3D transitions engine slideshow/source/engine/opengl).

the most used filters are ODF's odp, binary ppt and OOXML's pptx. their locations are listed below:

  • odp import and export filters are in xmloff module (mostly xmloff/source/draw)

  • ppt import is in sd/source/filter/ppt (big shared chunks are also in svx)

  • ppt export is in sd/source/filter/eppt (big shared chunks are also in svx)

  • pptx import is in oox/source/ppt (and uses a lot of oox/source/drawingml and oox/source/*)

  • pptx export is in sd/source/filter/eppt (mostly in pptx-* source files) and shared part is in oox/source/export

PPTX Export / Import Filters

PPTX export filter is split into 2 parts. Impress related part is in sd/source/filter/eppt/pptx-* and the other part is in oox/source/export/ because it contains mostly code related to DrawingML, which is shared with writer and calc ooxml export.

The export filter was written in 2009 IIRC and was not much extended feature-wise lately.

Future Works

Add custom shapes export (see below). enhance text output, we don't write text style for indentation levels now, need to export a:lvl1pPr, a:lvl2pPr, ... elements.

PPTX import was written by Sun/Oracle and then extended in LibreOffice a lot during bug fixing. It is located in oox/source/ppt and oox/source/drawingml. The areas with most bugs (at least until today) were shape placeholders and text style inheritance.