3901e029bd
Communicate Kashida insertion positions in an explicit way. Rest of LibreOffice communicate adjustments to character widths (e.g. for justification or spacing) using so-called DX array. DX array is an array of absolute character positions (e.g. DX[n] is the position after character n from the start of the lines, and its widths is DX[n] - DX[n-1]). This DX array is modified also when Kashidas are inserted after a given character for Arabic justification, by expanding its width. VCL would use this to know where to insert the Kashidas and how many ones. But because DX array is used for both widths adjustments and kashida insertion, this turns out to be a source of bugs since VCL has tosecond guess the DX array to find which is pure width adjustment and which also involves Kashida insertion, and the heuristics it uses are fragile. This change adds a second array of booleans that records where Kashida is inserted and communicates it all the way from where Kashida insertion is decoded in Writer and down to VCL layout. This change passes the Kashida array only when it seems necessary (e.g. during drawing but not when measuring text since the DX array is enough in this case). Hopefully no places where Kashida insertion needs to be passed down were missed. A couple of glyph and layout flags that were used for old heuristics and no longer needed and are removed. This also fixes: tdf#87731 tdf#106309 tdf#108604 tdf#112849 tdf#114257 tdf#127176 tdf#145647 tdf#146199 Change-Id: I4ed0850ef2fdc3e9143341afac649e7e7d463c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> |
||
|---|---|---|
| .. | ||
| inc | ||
| qa | ||
| res | ||
| sdi | ||
| source | ||
| uiconfig | ||
| util | ||
| workben | ||
| xml | ||
| xsl | ||
| AllLangMoTarget_sd.mk | ||
| CppunitTest_sd_a11y.mk | ||
| CppunitTest_sd_activex_controls_tests.mk | ||
| CppunitTest_sd_dialogs_test.mk | ||
| CppunitTest_sd_export_tests-ooxml1.mk | ||
| CppunitTest_sd_export_tests-ooxml2.mk | ||
| CppunitTest_sd_export_tests-ooxml3.mk | ||
| CppunitTest_sd_export_tests.mk | ||
| CppunitTest_sd_filter_eppt.mk | ||
| CppunitTest_sd_filters_test.mk | ||
| CppunitTest_sd_html_export_tests.mk | ||
| CppunitTest_sd_import_tests-smartart.mk | ||
| CppunitTest_sd_import_tests.mk | ||
| CppunitTest_sd_import_tests2.mk | ||
| CppunitTest_sd_layout_tests.mk | ||
| CppunitTest_sd_misc_tests.mk | ||
| CppunitTest_sd_pdf_import_test.mk | ||
| CppunitTest_sd_png_export_tests.mk | ||
| CppunitTest_sd_shape_import_export_tests.mk | ||
| CppunitTest_sd_svg_export_tests.mk | ||
| CppunitTest_sd_tiledrendering.mk | ||
| CppunitTest_sd_uiimpress.mk | ||
| CppunitTest_sd_uimpress.mk | ||
| export_setup.mk | ||
| import_setup.mk | ||
| IwyuFilter_sd.yaml | ||
| JunitTest_sd_unoapi.mk | ||
| Library_sd.mk | ||
| Library_sdd.mk | ||
| Library_sdfilt.mk | ||
| Library_sdui.mk | ||
| Makefile | ||
| Module_sd.mk | ||
| Package_opengl.mk | ||
| Package_web.mk | ||
| Package_xml.mk | ||
| README.md | ||
| README.vars | ||
| README_REMOTE | ||
| UIConfig_sdraw.mk | ||
| UIConfig_simpress.mk | ||
| UITest_impress_tests.mk | ||
| UITest_impress_tests2.mk | ||
| UITest_sd_findReplace.mk | ||
LibreOffice Impress / Draw Application
The core directory for the impress/draw applications.
Think of impress as a hack on top of draw.
sd module contains impress/draw specific code, non-shared UI and part
of ppt and pptx filter, few other filters too.
the slideshow UI lives here as well, the slideshow engine is in
slideshow module though (including the 3D transitions engine
slideshow/source/engine/opengl).
the most used filters are ODF's odp, binary ppt and OOXML's
pptx. their locations are listed below:
-
odpimport and export filters are inxmloffmodule (mostlyxmloff/source/draw) -
pptimport is insd/source/filter/ppt(big shared chunks are also insvx) -
pptexport is insd/source/filter/eppt(big shared chunks are also insvx) -
pptximport is inoox/source/ppt(and uses a lot ofoox/source/drawingmlandoox/source/*) -
pptxexport is insd/source/filter/eppt(mostly inpptx-*source files) and shared part is inoox/source/export
PPTX Export / Import Filters
PPTX export filter is split into 2 parts. Impress related part is in
sd/source/filter/eppt/pptx-* and the other part is in
oox/source/export/ because it contains mostly code related to
DrawingML, which is shared with writer and calc ooxml export.
The export filter was written in 2009 IIRC and was not much extended feature-wise lately.
Future Works
Add custom shapes export (see below). enhance text
output, we don't write text style for indentation levels now, need to
export a:lvl1pPr, a:lvl2pPr, ... elements.
PPTX import was written by Sun/Oracle and then extended in LibreOffice
a lot during bug fixing. It is located in oox/source/ppt and
oox/source/drawingml. The areas with most bugs (at least until today)
were shape placeholders and text style inheritance.