office-gobmx/xmlsecurity
Miklos Vajna 40ba7a5c25 cool#9992 lok doc sign: implement signature removal
Open an already signed document, click on the sign icon on the status
bar, notice how the button to remove a signature is hidden.

This was added in commit 71a8bad4b9
(jsdialog: enable Digital Signatures dialog, 2022-01-24), which exposed
the signatures dialog as a read-only jsdialog. The dialog was improved
recently to be a read-write jsdialog, so this is no longer needed.

But then DigitalSignaturesDialog::canRemove() had an inner non-async
message dialog. Fix that by converting canRemove() to async.

An additional problem could be that the document is not marked as
modified, so the LOK client code doesn't notice the document is updated
(to not have a signature), but we do update the last mod timestamp of
the file, which is meant to be enough.

Change-Id: I8e7ee22e4b1b8ce59dee3617bb2f22f8d734f31d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173428
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2024-09-16 16:26:18 +02:00
..
doc XMLSecurity Module Documentation Update 2023-08-26 01:01:40 +02:00
inc cool#9992 lok doc sign: implement signature removal 2024-09-16 16:26:18 +02:00
qa cool#9992 lok doc sign: allow sign of macros & the document itself in one step 2024-09-12 16:53:06 +02:00
source cool#9992 lok doc sign: implement signature removal 2024-09-16 16:26:18 +02:00
test_docs
uiconfig/ui [API CHANGE] XDocumentDigitalSignatures: remove deprecated / unused functions 2024-09-13 10:27:14 +02:00
util
workben loplugin:ostr in xmlsecurity 2024-05-15 18:03:51 +02:00
AllLangMoTarget_xsc.mk
CppunitTest_qa_certext.mk
CppunitTest_xmlsecurity_dialogs_test.mk
CppunitTest_xmlsecurity_pdfsigning.mk
CppunitTest_xmlsecurity_signing.mk
CppunitTest_xmlsecurity_signing2.mk
Executable_pdfverify.mk
IwyuFilter_xmlsecurity.yaml Drop transitional header xmlsecurity/xmlsec-wrapper.h 2024-03-28 12:51:00 +01:00
Library_xmlsecurity.mk
Library_xsec_xmlsec.mk makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo) 2024-05-06 11:40:45 +02:00
Makefile
Module_xmlsecurity.mk xmlsecurity: Add UItest (save GPG encrypted ODF) 2024-07-17 21:02:52 +02:00
README.md Fix typo 2023-08-27 18:46:24 +02:00
UIConfig_xmlsec.mk
UITest_xmlsecurity_gpg.mk pyuno,unotest,xmlsecurity: copy GPG test files for UITtest 2024-08-01 11:18:30 +02:00

Document Signing

Introduction

This code provides dialogs, and infrastructure wrapping libxmlsec and gpgme that implements document signing.

For signing a document, a personal key pair is used, which consists of a private key and a public key, which is added to the document in addition to the digital signature of the document, when signing it.

The document signing can be done both for the source ODF/OOXML files and the exported PDF files. It is also possible to sign existing PDF files.

Module Contents

  • doc: OpenDocument workflow legacy information with some illustrations to have an idea of the workflow, for starters check doc/OpenDocumentSignatures-Workflow.odt.
  • inc: Headers to a subset of source files inside the module, parts like source/framework have headers inside the folder.
  • qa: Unit tests for signing and shell scripts for certificates creation for testing.
  • test_docs: Documents & certificates used for testing.
  • source: More on that below.
  • uiconfig: User interface configuration for different dialogs, it is recommended to navigate from relevant source file to the .ui file linked in the class which will be under uiconfig/ui.
  • util: UNO passive registration config for GPG/ NSS.

Source Primary Contents

  • component: Main implementation of DocumentDigitalSignatures where the interaction with security environment and certificates occur.
  • dialogs: Certificate & Signatures management dialogs.
    • certificatechooser: Dialog that allows you to find and choose certificates or signatures for encryption.
    • certificateviewer: More detailed information about each certificate.
    • digitalsignaturesdialog: Main window for signatures of the documents and the start point of signing document.
  • framework: Various elements for verifying signatures and running security engine.
  • gpg: The implementation of encrypting with GPG and security environment initialization.
  • helper: Some helper classes that include signatures manager and the helpers for PDF signing, UriBinding, and XML signatures. It also include helper tools for XSecurityEnvironment.
  • xmlsec: XML, NSS, MSCrypt encryption/ signing tools, more on the low-level side of actual implementation of algorithms.

PDF Testing

To test the signed PDFs, one can use the pdfverify in this way:

./bin/run pdfverify $PWD/xmlsecurity/qa/unit/pdfsigning/data/2good.pdf

The file parameter should be an absolute path.

This is the output of pdfverify for 2good.pdf:

verifying signatures
found 2 signatures
signature #0: digest match? 1
signature #0: partial? 0
signature #1: digest match? 1
signature #1: partial? 0

References