office-gobmx/include/svx/sxelditm.hxx
Stephan Bergmann 16e3b84d2e Improve loplugin:dyncastvisibility to check for non-inline key functions
This would have caught the issue discussed in
709b1f3ddb "Make sure VCLXPopupMenu has unique
RTTI".  (The commit message talks about RTTI there, while what Clang actually
compared for an optimized implementation of a dynamic_cast to a final class is
vtable pointers, but the overall picture remains the same.  Both RTTI and
vtables are emitted along the key function, and if that is missing or inline,
they are emitted for each dynamic library individually, and as internal symbols
on macOS.)

This commit also addresses all the issues found by the improved
loplugin:dyncastvisibility on Linux.  See the newly added TODO in
compilerplugins/clang/dyncastvisibility.cxx and
86b86ac87e "Give DocumentEventHolder (aka
EventHolder<DocumentEvent>) a key function" for an issue with key functions for
class template instantiations.

Change-Id: Ia19155efb1d23692c92b9c97ff17f18ae7a1f3ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176576
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
2024-11-14 12:49:22 +01:00

60 lines
2 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#ifndef INCLUDED_SVX_SXELDITM_HXX
#define INCLUDED_SVX_SXELDITM_HXX
#include <svx/svddef.hxx>
#include <svx/sdmetitm.hxx>
class SAL_DLLPUBLIC_RTTI SdrEdgeLineDeltaCountItem final : public SfxUInt16Item
{
SdrEdgeLineDeltaCountItem(SdrEdgeLineDeltaCountItem const&) = default;
void operator=(SdrEdgeLineDeltaCountItem const&) = delete;
public:
SdrEdgeLineDeltaCountItem(sal_uInt16 nVal = 0)
: SfxUInt16Item(SDRATTR_EDGELINEDELTACOUNT, nVal,
SfxItemType::SdrEdgeLineDeltaCountItemType)
{
}
virtual ~SdrEdgeLineDeltaCountItem() override;
virtual SdrEdgeLineDeltaCountItem* Clone(SfxItemPool*) const override
{
return new SdrEdgeLineDeltaCountItem(*this);
}
};
inline SdrMetricItem makeSdrEdgeLine1DeltaItem(tools::Long nVal)
{
return SdrMetricItem(SDRATTR_EDGELINE1DELTA, nVal);
}
inline SdrMetricItem makeSdrEdgeLine2DeltaItem(tools::Long nVal)
{
return SdrMetricItem(SDRATTR_EDGELINE2DELTA, nVal);
}
inline SdrMetricItem makeSdrEdgeLine3DeltaItem(tools::Long nVal)
{
return SdrMetricItem(SDRATTR_EDGELINE3DELTA, nVal);
}
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */