Test repository to check push and ssh key
Find a file
Caolán McNamara c6d8778bfa cid#1596251 Dereference null return value
and

cid#1596249 Dereference null return value

Change-Id: I2d50e8be5ec20001527c20ccd46a9a0336792d8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165871
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-07 17:10:21 +02:00
.git-hooks
.github
.vscode
accessibility tdf#146619 Drop unused 'using namespace' in: accessibility/ 2024-04-01 10:03:56 +02:00
android android-viewer translated using Weblate 2024-03-13 21:05:38 +01:00
animations tdf#146619 Recheck animations/ with IWYU 2024-03-08 09:13:28 +01:00
apple_remote Drop C/C++ DEBUG macro 2024-03-21 16:30:59 +01:00
avmedia loplugin:unusedmethods 2024-04-04 19:58:14 +02:00
basctl Use weak reference to SfxObjectShell in SfxEventHint to avoid use-after-free 2024-03-11 04:43:28 +01:00
basegfx tdf#147906 Use std::hypot for Pythagorean distance 2024-04-05 13:59:33 +02:00
basic Simplify VBALikeToRegexp a bit 2024-04-03 04:35:10 +02:00
bean
bin Drop transitional header xmlsecurity/xmlsec-wrapper.h 2024-03-28 12:51:00 +01:00
binaryurp Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
bridges riscv64 bridge: replace some preprocessor directives to macros for debugging 2024-04-02 14:16:01 +02:00
canvas convert CanvasFont to comphelper::WeakComponentImplHelper 2024-03-30 18:01:34 +01:00
chart2 loplugin:unusedmethods 2024-04-04 19:58:14 +02:00
cli_ure Fix warning C4456 when building with MSVC without -Wv:18 2024-02-23 01:34:29 +01:00
codemaker map SAL_DLLPUBLIC_RTTI to visibility:default for gcc 2024-03-05 14:39:06 +01:00
comphelper ofz#67491 avoid direct nss use to support --enable-tls-openssh 2024-04-07 13:45:23 +02:00
compilerplugins loplugin:unusedenumconstants 2024-04-04 19:58:35 +02:00
config_host add UNLESS_MERGELIBS_MORE and use to reduce symbol visibility 2024-03-02 09:36:01 +01:00
configmgr configmgr: fix parse error if subelements of <info> used 2024-03-22 08:46:04 +01:00
connectivity loplugin:unusedenumconstants 2024-04-04 19:58:35 +02:00
cppcanvas
cppu tdf#146619 Drop unused 'using namespace' in: cppu/ cppuhelper/ 2024-03-29 21:20:50 +01:00
cppuhelper tdf#146619 Drop unused 'using namespace' in: cppu/ cppuhelper/ 2024-03-29 21:20:50 +01:00
cpputools
cui tdf#146619 Drop unused 'using namespace' in: cui/ 2024-04-05 13:45:28 +02:00
dbaccess tdf#146619 Drop unused 'using namespace' in: dbaccess/ 2024-04-03 08:57:28 +02:00
desktop Introduce ResettableMutexGuardScopedReleaser 2024-04-04 13:21:09 +02:00
dictionaries@c5b2a36bde Update git submodules 2024-03-28 10:56:58 +01:00
distro-configs move Windows amd macOS builds to mergelibs=more 2024-03-04 18:04:23 +01:00
docmodel cool#8327 use tools::JsonWriter for theme colors 2024-03-04 11:50:45 +01:00
drawinglayer loplugin:unusedenumconstants 2024-04-04 19:58:35 +02:00
editeng tdf160518 DOCX: import hyphenation-keep to fix layout 2024-04-04 22:46:12 +02:00
embeddedobj Use osl::ResettableMutexGuardScopedReleaser instead of ad-hoc guards 2024-04-04 13:21:14 +02:00
embedserv Drop std::as_const from css::uno::Sequence iterations 2024-01-27 12:43:48 +01:00
emfio
eventattacher tdf#146619 Drop unused 'using namespace' in: eventattacher/ 2024-03-30 10:03:30 +01:00
extensions Drop C/C++ DEBUG macro 2024-03-21 16:30:59 +01:00
external external/lxml: Silence -Wincompatible-pointer-types 2024-04-03 21:36:29 +02:00
extras Resolves tdf#159573 and tdf#137931 - WhatsNew or Welcome dialog 2024-03-27 09:41:44 +01:00
filter tdf#147021 Replace SAL_N_ELEMENTS with std::size 2024-04-02 10:38:58 +02:00
forms tdf#146619 Drop unused 'using namespace' in: forms 2024-04-05 13:45:10 +02:00
formula tdf#126573 Add Excel2021 array function SORTBY to Calc 2024-03-26 10:20:38 +01:00
fpicker tdf#146619 Drop unused 'using namespace' in: fpicker/ 2024-03-31 19:22:40 +02:00
framework tdf#146619 Drop unused 'using namespace' in: framework/ 2024-04-01 11:46:16 +02:00
helpcompiler Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
helpcontent2@4c741dd9f0 Update git submodules 2024-04-05 07:32:25 +02:00
hwpfilter A number of bogus GCC 13 warnings still hit with recent GCC 14 trunk 2024-04-04 07:06:17 +02:00
i18nlangtag Drop C/C++ DEBUG macro 2024-03-21 16:30:59 +01:00
i18npool i18npool : use OUString literal for XInterface implementation 2024-04-03 12:59:48 +02:00
i18nutil Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
icon-themes Resolves: tdf#160562 change white background of icon to transparent 2024-04-06 22:12:19 +02:00
idl tdf#143148 update all headers in idl/inc to use #pragma once 2024-03-16 20:20:21 +01:00
idlc/test/parser
include Enable allowing comment editing in readOnly view mode. 2024-04-06 22:10:57 +02:00
instsetoo_native
io tdf#146619 Drop unused 'using namespace' in: io/ 2024-03-29 21:21:02 +01:00
ios
javaunohelper
jurt
jvmaccess
jvmfwk Tie javac -g option to --enable-symbols instead of gb_DEBUGLEVEL 2024-03-21 09:41:57 +01:00
l10ntools
librelogo Revert "tdf#158803 remove some unused imports, unnecessary semicolons and related styling" 2024-03-28 10:10:32 +01:00
libreofficekit LOK: send inner text boundry information of shapes/textbox on change 2024-03-08 10:55:26 +01:00
lingucomponent tdf#146619 Drop unused 'using namespace' in: lingucomponent/ 2024-04-01 20:47:37 +02:00
linguistic Silence strange -Wmaybe-uninitialized with recent GCC 14 2024-04-05 20:06:08 +02:00
lotuswordpro tdf#141908 - CppUnittests: replace usage of sal_Int32 with colors 2024-03-14 02:33:03 +01:00
m4
msicreator
nlpsolver
o3tl Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
odk loplugin:unusedenumconstants 2024-04-04 19:58:35 +02:00
offapi a11y: Fix XAccessible{Editable,Multiline}Text doc 2024-04-04 17:16:05 +02:00
officecfg tdf#95405 Sidebar: Quick Find for writer 2024-04-04 20:46:29 +02:00
oovbaapi
oox Base scale on 1.0, not on 100.0 2024-04-03 16:41:59 +02:00
opencl Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
osx
package tdf#146619 Drop unused 'using namespace' in: package/ 2024-03-31 09:41:32 +02:00
pch
postprocess Emscripten: Filter out some configuration 2024-02-23 20:58:56 +01:00
pyuno minor fixes to officehelper.py 2024-04-03 17:50:11 +02:00
qadevOOo Tie javac -g option to --enable-symbols instead of gb_DEBUGLEVEL 2024-03-21 09:41:57 +01:00
readlicense_oo update credits 2024-03-19 12:24:43 +01:00
registry Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
remotebridges
reportbuilder
reportdesign use std::mutex in StatusbarController 2024-03-29 16:24:29 +01:00
ridljar Allow building with Java 8 2024-03-02 06:29:50 +01:00
sal Allow custom "eye catcher" from LO_TESTNAME in tempfiles on Windows 2024-04-03 12:31:33 +02:00
salhelper Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
sax tdf#146619 Drop unused 'using namespace' in: sax/ 2024-03-31 09:41:18 +02:00
sc use "ok" id like the other 446 dialogs instead of "okay" 2024-04-06 22:11:08 +02:00
scaddins Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
sccomp convert SolverComponent to comphelper::WeakImplHelper 2024-03-29 07:42:41 +01:00
schema tdf#160356 Add support for hidden named expressions in Calc 2024-04-01 05:56:10 +02:00
scp2 scp2: Take ENABLE_{KF,QT}6 into account 2024-02-14 09:42:53 +01:00
scripting cid#1596251 Dereference null return value 2024-04-07 17:10:21 +02:00
sd SdNavigator: Make the objects tree update after rename 2024-04-06 03:16:52 +02:00
sdext A small refactor 2024-04-04 09:21:49 +02:00
setup_native Drop C/C++ DEBUG macro 2024-03-21 16:30:59 +01:00
sfx2 Enable allowing comment editing in readOnly view mode. 2024-04-06 22:10:57 +02:00
shell tdf#146619 Drop unused 'using namespace' in: shell/ 2024-03-30 20:50:06 +01:00
slideshow tdf#159258 sd: fix to show objects in slideshow if they have 2024-03-22 11:44:16 +01:00
smoketest
solenv loplugin:unusedmethods 2024-04-04 19:58:14 +02:00
soltools Drop C/C++ DEBUG macro 2024-03-21 16:30:59 +01:00
sot simplify SotTempStream and lifetime 2024-04-02 07:53:43 +02:00
starmath reduce symbol visibility in --enable-mergelibs=more mode 2024-03-13 08:14:38 +01:00
static Fix typo 2024-04-06 03:23:12 +02:00
stoc tdf#146619 Drop unused 'using namespace' in: stoc/ 2024-03-30 09:49:07 +01:00
store Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
svgio tdf#146619 Drop unused 'using namespace' in: svgio/ 2024-04-03 08:57:49 +02:00
svl loplugin:unusedmethods 2024-04-04 19:58:14 +02:00
svtools RESTART_REASON_MSCOMPATIBLE_FORMS_MENU is dead 2024-04-04 19:58:23 +02:00
svx tdf#160084 Simplify comparison for basegfx::fTools 2024-04-05 13:15:46 +02:00
sw Drop a redundant check 2024-04-07 14:46:34 +02:00
swext
sysui use portable "command -v" to detect installed programs, part 3 2024-01-22 14:11:47 +01:00
test tdf#146619 Drop unused 'using namespace' in: test/ 2024-04-03 19:02:48 +02:00
testtools
toolkit loplugin:unusedmethods 2024-04-04 19:58:14 +02:00
tools loplugin:unusedmethods 2024-03-17 13:06:48 +01:00
translations@e36ba06ea7 Update git submodules 2024-04-02 12:46:35 +02:00
ucb ucb: webdav-curl: always set CURLOPT_NOBODY for HEAD 2024-03-14 18:59:16 +01:00
ucbhelper tdf#146619 Drop unused 'using namespace' in: ucbhelper/ 2024-03-29 21:21:23 +01:00
udkapi Add Embind'ing of UNO Any getter for interfaces 2024-03-07 23:13:31 +01:00
uitest fix comparison of UIObject's inside UITests 2024-03-28 17:17:32 +01:00
UnoControls tdf#146619 Drop unused 'using namespace' in: UnoControls/ 2024-03-30 19:54:17 +01:00
unodevtools
unoidl Some improvements to the UNOIDL SourceTreeProvider 2024-02-28 16:01:38 +01:00
unoil
unotest Embind construction of UNO Any sequence/struct/exception/interface 2024-03-11 13:36:24 +01:00
unotools ofz#67825 build failure clang frontend command failed with exit code 139 2024-04-04 17:00:14 +02:00
unoxml tdf#146619 Drop unused 'using namespace' in: unoxml/ 2024-03-31 09:41:07 +02:00
ure
uui uui: show what is the unhandled result before asserting 2024-02-15 16:37:52 +01:00
vbahelper tdf#143148 Update Include Guard usage 2024-03-11 05:42:43 +01:00
vcl cid#1596238 clarify Explicit null dereferenced 2024-04-07 17:10:15 +02:00
winaccessibility
wizards Revert "tdf#158803 remove some unused imports, unnecessary semicolons and related styling" 2024-03-28 10:10:32 +01:00
writerfilter tdf160518 DOCX: import hyphenation-keep to fix layout 2024-04-04 22:46:12 +02:00
writerperfect reduce symbol visibility in --enable-mergelibs=more mode 2024-03-13 08:14:38 +01:00
xmerge
xmlhelp Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
xmloff flatten for readability 2024-04-06 22:11:46 +02:00
xmlreader Use less boost_headers in low level libraries 2024-03-06 21:23:17 +01:00
xmlscript tdf#146619 Drop unused 'using namespace' in: xmlscript/ 2024-04-01 10:03:25 +02:00
xmlsecurity Missing include, again 2024-04-04 18:19:45 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in Allow building with Java 8 2024-03-02 06:29:50 +01:00
config_host_lang.mk.in
configure.ac Update the Android "enough memory for linking" check 2024-03-21 16:57:37 +01:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint Add SAL_LOPLUGIN_ANNOTATE to cpp.hint 2024-01-30 07:18:32 +01:00
download.lst Update to latest Rhino 1.7.14 2024-04-02 18:56:13 +02:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit Fix indentation 2024-04-04 15:26:09 +02:00
Makefile.fetch
Makefile.gbuild Create MAR updates from msi rather than from archive 2024-01-22 16:06:42 +01:00
Makefile.in
README.cross
README.help.md
README.md Building with Clang needs at least libstdc++ 10 2024-03-16 11:53:25 +01:00
README.Solaris
Repository.mk Resolves tdf#159573 and tdf#137931 - WhatsNew or Welcome dialog 2024-03-27 09:41:44 +01:00
RepositoryExternal.mk Revert "make skia into static library" 2024-03-16 16:02:31 +01:00
RepositoryFixes.mk Experimental support for latest Emscripten (and Qt6) 2024-01-29 19:51:57 +01:00
RepositoryModule_build.mk
RepositoryModule_host.mk add sd to --enable-mergelibs=more 2024-03-05 20:35:30 +01:00
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.