office-gobmx/compilerplugins/clang/dodgyswitch.cxx
Stephan Bergmann d1a2b80b9d Bump compiler plugins Clang baseline to 12.0.1
...as discussed in the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2020-November/086234.html>
"Bump --enable-compiler-plugins Clang baseline?" (and now picked up again at
<https://lists.freedesktop.org/archives/libreoffice/2022-February/088459.html>
"Re: Bump --enable-compiler-plugins Clang baseline?"), and clean up
compilerplugins/clang/ accordingly

Change-Id: I5e81c6fdcc363aeefd6227606225b526fdf7ac16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129989
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-17 21:45:06 +01:00

78 lines
2.1 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <cassert>
#include <string>
#include <iostream>
#include <fstream>
#include <set>
#include "plugin.hxx"
namespace {
class DodgySwitch:
public loplugin::FilteringPlugin<DodgySwitch>
{
public:
explicit DodgySwitch(loplugin::InstantiationData const & data): FilteringPlugin(data)
{}
virtual void run() override
{
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool VisitDefaultStmt(DefaultStmt const * );
bool VisitCaseStmt(CaseStmt const * );
private:
bool IsParentSwitch(Stmt const * );
};
bool DodgySwitch::VisitDefaultStmt(DefaultStmt const * defaultStmt)
{
if (ignoreLocation(defaultStmt))
return true;
if (!IsParentSwitch(defaultStmt))
report(
DiagnosticsEngine::Warning, "default statement not directly under switch",
defaultStmt->getBeginLoc())
<< defaultStmt->getSourceRange();
return true;
}
bool DodgySwitch::VisitCaseStmt(CaseStmt const * caseStmt)
{
if (ignoreLocation(caseStmt))
return true;
if (!IsParentSwitch(caseStmt))
{
//parentStmt(parentStmt(caseStmt))->dump();
report(
DiagnosticsEngine::Warning, "case statement not directly under switch",
caseStmt->getBeginLoc())
<< caseStmt->getSourceRange();
}
return true;
}
bool DodgySwitch::IsParentSwitch(Stmt const * stmt)
{
auto parent = getParentStmt(stmt);
if (isa<CaseStmt>(parent) || isa<DefaultStmt>(parent)) // daisy chain
return true;
auto compoundStmt = dyn_cast<CompoundStmt>(parent);
if (!compoundStmt)
return false;
return isa<SwitchStmt>(getParentStmt(compoundStmt));
}
loplugin::Plugin::Registration< DodgySwitch > X("dodgyswitch", false);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */