cafc53f8b4
The problem as seen by the user: if you have a table of 2 rows and 1 column, and the separator line is dragged upwards by the mouse, then undo doesn't restore the original situation. Two items are created on the undo stack: sd::UndoGeoObject and sdr::table::TableRowUndo. Let's say the table height is 8000 mm100 and the two cell heights are 4000 and 4000. If the user resizes the first cell, so that its height is 2000, then the new table height will be 6000. The problem is that when undo is executed, first sd::UndoGeoObject resizes the table, distributing the newly available 2000 between the existing rows, and then sdr::table::TableRowUndo sets the row height of the first row: the height of the second cell will be larger than expected. Fix the problem by not doing a relayout during sd::UndoGeoObject, but doing a relayout after sdr::table::TableRowUndo in this case. This is done by: 1) Adding a new SdrDragStat::mbEndDragChangesLayout, so that SdrTableObj::applySpecialDrag() can inform SdrDragObjOwn::EndSdrDrag() that TableRowUndo will do the layout instead of UndoGeoObject. (This is done only in case a row edge is dragged, as otherwise it's not guaranteed that a TableRowUndo will follow the UndoGeoObject on the undo stack.) 2) Adding a new SdrUndoGeoObj::mbSkipChangeLayout, so that SdrTableObj::applySpecialDrag() can let SdrUndoGeoObj::Undo() not do the layout. 3) Adding a sdr::table::SdrTableObjImpl::mbSkipChangeLayout, so that SdrUndoGeoObj::Undo() can let SdrTableObj::NbcSetLogicRect() not do the layout. 4) Marking the table model as modified in TableRowUndo::setData(), so it does the layout at the end of the undo group. Change-Id: I8adde3cdad5741e6fcb420e333ce336e18c77cf1 Reviewed-on: https://gerrit.libreoffice.org/24363 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> |
||
---|---|---|
.git-hooks | ||
accessibility | ||
android | ||
animations | ||
apple_remote | ||
avmedia | ||
basctl | ||
basegfx | ||
basic | ||
bean | ||
bin | ||
binaryurp | ||
bridges | ||
canvas | ||
chart2 | ||
cli_ure | ||
codemaker | ||
comphelper | ||
compilerplugins | ||
config_host | ||
configmgr | ||
connectivity | ||
cppcanvas | ||
cppu | ||
cppuhelper | ||
cpputools | ||
cui | ||
dbaccess | ||
desktop | ||
dictionaries@de93f4fc07 | ||
distro-configs | ||
drawinglayer | ||
dtrans | ||
editeng | ||
embeddedobj | ||
embedserv | ||
eventattacher | ||
extensions | ||
external | ||
extras | ||
filter | ||
forms | ||
formula | ||
fpicker | ||
framework | ||
helpcompiler | ||
helpcontent2@aefc01b1da | ||
hwpfilter | ||
i18nlangtag | ||
i18npool | ||
i18nutil | ||
icon-themes | ||
idl | ||
idlc | ||
include | ||
instsetoo_native | ||
io | ||
ios | ||
javaunohelper | ||
jurt | ||
jvmaccess | ||
jvmfwk | ||
l10ntools | ||
librelogo | ||
libreofficekit | ||
lingucomponent | ||
linguistic | ||
lotuswordpro | ||
m4 | ||
mysqlc | ||
nlpsolver | ||
o3tl | ||
odk | ||
offapi | ||
officecfg | ||
onlineupdate | ||
oovbaapi | ||
oox | ||
opencl | ||
osx | ||
package | ||
postprocess | ||
pyuno | ||
qadevOOo | ||
readlicense_oo | ||
registry | ||
remotebridges | ||
reportbuilder | ||
reportdesign | ||
ridljar | ||
rsc | ||
sal | ||
salhelper | ||
sax | ||
sc | ||
scaddins | ||
sccomp | ||
scp2 | ||
scripting | ||
sd | ||
sdext | ||
setup_native | ||
sfx2 | ||
shell | ||
slideshow | ||
smoketest | ||
solenv | ||
soltools | ||
sot | ||
starmath | ||
stoc | ||
store | ||
svgio | ||
svl | ||
svtools | ||
svx | ||
sw | ||
swext | ||
sysui | ||
test | ||
testtools | ||
toolkit | ||
tools | ||
translations@0732bbfc53 | ||
tubes | ||
ucb | ||
ucbhelper | ||
udkapi | ||
UnoControls | ||
unodevtools | ||
unoidl | ||
unoil | ||
unotest | ||
unotools | ||
unoxml | ||
ure | ||
uui | ||
vbahelper | ||
vcl | ||
winaccessibility | ||
windows | ||
wizards | ||
writerfilter | ||
writerperfect | ||
xmerge | ||
xmlhelp | ||
xmloff | ||
xmlreader | ||
xmlscript | ||
xmlsecurity | ||
.buckconfig | ||
.buckversion | ||
.gitattributes | ||
.gitignore | ||
.gitmodules | ||
.gitreview | ||
autogen.sh | ||
BUCK | ||
config.guess | ||
config.sub | ||
config_host.mk.in | ||
config_host_lang.mk.in | ||
configure.ac | ||
COPYING | ||
COPYING.LGPL | ||
COPYING.MPL | ||
download.lst | ||
g | ||
install-sh | ||
leak-suppress.txt | ||
Library_merged.mk | ||
lo.xcent.in | ||
logerrit | ||
Makefile.fetch | ||
Makefile.gbuild | ||
Makefile.in | ||
README.cross | ||
README.md | ||
README.Solaris | ||
Repository.mk | ||
RepositoryExternal.mk | ||
RepositoryFixes.mk | ||
RepositoryModule_build.mk | ||
RepositoryModule_host.mk | ||
sanitize-ubsan-blacklist | ||
TEMPLATE.SOURCECODE.HEADER | ||
unusedcode.easy | ||
unusedcode.exclude | ||
unusedcode.README |
LibreOffice
LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.
A quick overview of the LibreOffice code structure.
Overview
You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.
The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.
The important bits of code
Each module should have a README
file inside it which has some
degree of documentation for that module; patches are most welcome to
improve those. We have those turned into a web page here:
However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:
Module | Description |
---|---|
sal/ | this provides a simple System Abstraction Layer |
tools/ | this provides basic internal types: 'Rectangle', 'Color' etc. |
vcl/ | this is the widget toolkit library and one rendering abstraction |
framework | UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files |
sfx2/ | legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc. |
svx/ | drawing model related helper code, including much of Draw/Impress |
Then applications
Module | Description |
---|---|
desktop/ | this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop |
sw/ | Writer |
sc/ | Calc |
sd/ | Draw / Impress |
There are several other libraries that are helpful from a graphical perspective:
Module | Description |
---|---|
basegfx/ | algorithms and data-types for graphics as used in the canvas |
canvas/ | new (UNO) canvas rendering model with various backends |
cppcanvas/ | C++ helper classes for using the UNO canvas |
drawinglayer/ | View code to render drawable objects and break them down into primitives we can render more easily. |
Finding out more
Beyond this, you can read the README
files, send us patches, ask
on the mailing list libreoffice@lists.freedesktop.org (no subscription
required) or poke people on IRC #libreoffice-dev
on irc.freenode.net -
we're a friendly and generally helpful mob. We know the code can be
hard to get into at first, and so there are no silly questions.