Test repository to check push and ssh key
Find a file
Mike Kaganski d82349e3fc tdf#120703 PVS: fix possible buffer over-read when iterating string
V560 A part of conditional expression is always true: nStartPos < nLen.

Change-Id: I2ae8634bd656e857724615d5187a14bd087598eb
Reviewed-on: https://gerrit.libreoffice.org/63958
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25 11:15:23 +01:00
.git-hooks git hooks: Tell what to do in another problematic submodules case. 2018-11-22 11:53:07 +01:00
accessibility Fix typo 2018-11-22 07:07:48 +01:00
android
animations
apple_remote
avmedia tdf#42949 Fix IWYU warnings in include/vcl/[B-E]* 2018-11-21 11:02:04 +01:00
basctl allow collapsing rows 2018-11-24 15:42:17 +01:00
basegfx Fix typo 2018-11-25 00:15:25 +01:00
basic improve function-local statics in basic..cui 2018-11-21 12:28:23 +01:00
bean
bin
binaryurp
bridges
canvas drop unused ColorType in canvas 2018-11-24 07:06:20 +01:00
chart2 improve function local statics 2018-11-23 13:35:25 +01:00
cli_ure
codemaker
comphelper Use the correct DPI scaling factor in LibreOfficeKit for iOS, too 2018-11-23 17:48:20 +02:00
compilerplugins drop unused FormulaVectorDisabledNotInSoftwareSubset 2018-11-25 08:25:12 +01:00
config_host
configmgr improve function-local statics in basic..cui 2018-11-21 12:28:23 +01:00
connectivity tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
cppcanvas loplugin:redundantfcast improvements 2018-11-21 12:44:55 +01:00
cppu
cppuhelper improve function-local statics in basic..cui 2018-11-21 12:28:23 +01:00
cpputools
cui allow collapsing rows 2018-11-24 15:42:17 +01:00
dbaccess convert AGGREGATE_ACTION to scoped enum 2018-11-24 07:05:49 +01:00
desktop Use the correct DPI scaling factor in LibreOfficeKit for iOS, too 2018-11-23 17:48:20 +02:00
dictionaries@86921a78c4
distro-configs Make Jenkins linux_gcc_release_64 pick up Developer Toolset 7 2018-11-24 14:49:21 +01:00
drawinglayer loplugin:redundantfcast improvements 2018-11-21 12:44:55 +01:00
dtrans
editeng tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
embeddedobj
embedserv
emfio
eventattacher
extensions Related: tdf#121340: Do wizards steps Title Case 2018-11-22 16:43:33 +01:00
external Revert "Fix NSS parallel build" 2018-11-20 16:17:09 +01:00
extras weld SwFramePage 2018-11-22 21:59:48 +01:00
filter tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
forms --enable-dbgutil --disable-assert-always-abort fixes 2018-11-22 21:02:07 +01:00
formula tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
fpicker weld SwCondCollPage 2018-11-21 22:08:04 +01:00
framework tdf#42949 Fix IWYU warnings in include/vcl/[B-E]* 2018-11-21 11:02:04 +01:00
helpcompiler improve function-local statics in forms..reportdesign 2018-11-21 13:00:02 +01:00
helpcontent2@6c90a05e6c Update git submodules 2018-11-23 16:14:44 +01:00
hwpfilter
i18nlangtag
i18npool
i18nutil
icon-themes Colibre icons: add calc data icons and sync with elementary 2018-11-23 06:00:11 +01:00
idl
idlc
include allow collapsing rows 2018-11-24 15:42:17 +01:00
instsetoo_native
io
ios
javaunohelper
jurt
jvmaccess
jvmfwk tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
l10ntools remove unused enums in reportdesign,linguistic,l10ntools,vcl,svx 2018-11-23 20:31:22 +01:00
librelogo
libreofficekit
lingucomponent
linguistic tdf#120703 PVS: fix possible buffer over-read when iterating string 2018-11-25 11:15:23 +01:00
lotuswordpro
m4
nlpsolver
o3tl
odk
offapi
officecfg tdf#121490 Hide item Standard (Viewing Mode) toolbar from menu 2018-11-20 16:34:40 +01:00
onlineupdate
oovbaapi
oox tdf#119991 save checkbox tristate in oox format 2018-11-22 09:59:53 +01:00
opencl improve function-local statics in forms..reportdesign 2018-11-21 13:00:02 +01:00
osx
package Use returned iterator by list::erase 2018-11-24 21:37:24 +01:00
postprocess Build mysql_jdbc library even when building.. 2018-11-24 23:15:34 +01:00
pyuno
qadevOOo tdf#45904 Move XEnumeration Java tests to C++ 2018-11-22 06:58:49 +01:00
readlicense_oo
registry
remotebridges
reportbuilder
reportdesign remove unused enums in reportdesign,linguistic,l10ntools,vcl,svx 2018-11-23 20:31:22 +01:00
ridljar
sal improve function-local statics in sal 2018-11-22 12:07:54 +01:00
salhelper
sax convert CallbackType to scoped enum 2018-11-23 19:52:13 +01:00
sc tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
scaddins tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
sccomp
schema
scp2 tdf#112536 related: make soffice.bin a proper console application on Win 2018-11-21 08:19:38 +01:00
scripting improve function-local statics in scripting..svtools 2018-11-22 12:46:56 +01:00
sd tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
sdext remove unused enums DocumentTextDirection and RendererPaneStyle::Side 2018-11-22 17:21:42 +01:00
setup_native
sfx2 weld SfxMacroTabPage 2018-11-23 21:28:16 +01:00
shell
slideshow remove unused DocTreeNode::NodeType::Invalid 2018-11-24 16:49:45 +01:00
smoketest
solenv Revert "Do use -O1 for Apple Clang older than 9.1.0" 2018-11-23 23:38:14 +01:00
soltools remove some unused enum values and defines in soltools 2018-11-22 10:15:40 +01:00
sot
starmath remove unused FontChangeMask::HorAlign 2018-11-24 16:49:32 +01:00
stoc improve function-local statics in scripting..svtools 2018-11-22 12:46:56 +01:00
store
svgio
svl improve function-local statics in scripting..svtools 2018-11-22 12:46:56 +01:00
svtools tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
svx tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
sw tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
swext
sysui
test loplugin:redundantfcast improvements 2018-11-21 12:44:55 +01:00
testtools
toolkit improve function-local statics in toolkit 2018-11-22 18:54:21 +01:00
tools convert INetURLObject::PrefixInfo::Kind to scoped enum 2018-11-22 07:35:26 +01:00
translations@552fa2fbab
ucb
ucbhelper
udkapi
uitest
UnoControls
unodevtools
unoidl
unoil
unotest
unotools improve function local statics 2018-11-23 13:35:25 +01:00
unoxml
ure
uui remove unused LoginFlags values 2018-11-24 11:18:53 +01:00
vbahelper improve function-local statics in vbahelper 2018-11-22 14:27:18 +01:00
vcl tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
winaccessibility
wizards Related: tdf#121340: Do wizards steps Title Case 2018-11-22 16:43:33 +01:00
writerfilter tdf#120703 PVS: V560 A part of conditional expression is always true/false 2018-11-25 09:13:12 +01:00
writerperfect
xmerge
xmlhelp
xmloff BoolAttrFlags::DefaultMask is unnecessary 2018-11-24 07:06:31 +01:00
xmlreader
xmlscript
xmlsecurity weld SwCondCollPage 2018-11-21 22:08:04 +01:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.gitattributes
.gitignore
.gitmodules
.gitreview
autogen.sh Restrict Developer Toolset to Config=linux_gcc_release_64 2018-11-25 00:25:43 +01:00
BUCK
config.guess
config.sub
config_host.mk.in Revert "Do use -O1 for Apple Clang older than 9.1.0" 2018-11-23 23:38:14 +01:00
config_host_lang.mk.in
configure.ac Revert "Do use -O1 for Apple Clang older than 9.1.0" 2018-11-23 23:38:14 +01:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst
g
install-sh
leak-suppress.txt
Library_merged.mk
lo.xcent.in
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.md Bump Xcode baseline to 9.3 2018-11-23 17:03:59 +01:00
README.Solaris
Repository.mk Build mysql_jdbc library even when building.. 2018-11-24 23:15:34 +01:00
RepositoryExternal.mk
RepositoryFixes.mk tdf#112536 related: make soffice.bin a proper console application on Win 2018-11-21 08:19:38 +01:00
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-blacklist
setup.cfg
TEMPLATE.SOURCECODE.HEADER

LibreOffice

Coverity Scan Build Status CII Best Practices

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The build chain and runtime baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2017
  • macOS:
    • Runtime: 10.9
    • Build: 10.12 + Xcode 9.3
  • Linux:
    • Runtime: RHEL 6 or CentOS 6
    • Build: GCC 4.8.1 or Clang
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4

At least Clang 3.4.2 is known to be too old to pass the configure.ac check "whether $CXX supports C++17, C++14, or C++11" in its current form (due to the #pragma GCC diagnostic ignored "-Wpragmas" that it does not understand).

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The important bits of code

Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: 'Rectangle', 'Color' etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding out more

Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.