strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
office-gobmx/desktop/source
History
Stephan Bergmann b512ce255f Make upcasting css::uno::Reference ctor require complete types 
The main reason for the "home-grown" UpCast introduced with
904b3d1fce "Up-cast conversion constructor for
css::uno::Reference" in 2013 was probably that we could not yet rely on C++11
std::is_base_of back then.  A (welcome) side effect was that the derived class
could be incomplete.

However, specializations of UpCast relying on whether or not T2 is incomplete
are obviously an ODR violation if the type is incomplete in some TUs and
complete (and derived from T1) in others.  And even if UpCast had internal
linkage, it would still be brittle that its behavior depends on the completeness
of T2 at the point of the template's instantiation, and not necessarily at the
point of use.

That means we should better base that ctor on std::is_base_of (which we can do
now since 39a1edd6fe "Make css::uno::Reference
upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on
Clang and GCC if the completeness requirements are not met.  This change fixes
all the cases where types need to be complete now, plus any resulting
loplugin:referencecasting warnings ("the source reference is already a subtype
of the destination reference").

Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-27 07:19:30 +02:00
..
app loplugin:flatten in desktop 2020-04-14 20:46:19 +02:00
deployment Make upcasting css::uno::Reference ctor require complete types 2020-04-27 07:19:30 +02:00
inc
lib Drop Macromedia Flash export filter 2020-04-23 16:16:12 +02:00
migration loplugin:flatten in desktop 2020-04-14 20:46:19 +02:00
minidump tdf#42949 Fix IWYU warnings in desktop/ 2020-01-24 11:59:16 +01:00
offacc tdf#42949 Fix IWYU warnings in desktop/ 2020-01-24 11:59:16 +01:00
pkgchk/unopkg loplugin:flatten in desktop 2020-04-14 20:46:19 +02:00
splash tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/ 2020-04-22 15:36:50 +02:00