office-gobmx

History

Stephan Bergmann b512ce255f Make upcasting css::uno::Reference ctor require complete types The main reason for the "home-grown" UpCast introduced with `904b3d1fce` "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since `39a1edd6fe` "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>		2020-04-27 07:19:30 +02:00
..
dtd
inc/pch
source	Make upcasting css::uno::Reference ctor require complete types	2020-04-27 07:19:30 +02:00
test
util
IwyuFilter_xmlscript.yaml
Library_xmlscript.mk
Makefile
Module_xmlscript.mk
Package_dtd.mk
README

README

XML dialogs.

This code is used to (de)serialize basic dialogs to XML for storage
inside documents. While the XML -appears- to have some hierarchical
structure, that is only a fabrication, parsing and underlying toolkit
widget structure is sadly linear and flat.