5130d240be
Select some HTML content on a password-protected webpage that has images, copy, paste into Writer when it's in LOK mode -> hang. What seems to happen is that the HTML content itself is on the clipboard, but not resources referred by that content, like images. Which means our code in SwHTMLParser::InsertImage() will at the end call into ucb/ code to get the HTTP image, which will call into uui/ code to ask for the password. This has multiple problems: 1) the popup dialog is not async (and not trivial to convert to async) and the dialog hints that the password can be saved, but LOK document edit sessions always start from a clean profile, so that's not working. The non-async dialog even results in a hang in practice. Fix the problem by not showing the password dialog in the LOK case at all: it's better to have an image placeholder in the paste result than hanging your entire document edit session. Non-password-protected images continue to work, unless HostFilter::isForbidden() rejects the URL. Change-Id: I1e55ab7adecd9c90ba38a97bcdc52b2b01f7ff2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172781 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> |
||
|---|---|---|
| .. | ||
| inc | ||
| qa/unit | ||
| source | ||
| uiconfig/ui | ||
| util | ||
| AllLangMoTarget_uui.mk | ||
| CppunitTest_uui_dialogs_test.mk | ||
| IwyuFilter_uui.yaml | ||
| Library_uui.mk | ||
| Makefile | ||
| Module_uui.mk | ||
| README.md | ||
| UIConfig_uui.mk | ||
Interaction Handler for ucb and More
Contains an Interaction Handler for the "ucb" and other uses. Works via VCL.