2d36e7f518
It's been a source of numerous problems since the beginning. Poor separation of C++ code causing the compiler to emit some generic code as CPU-specific, compiler optimizations moving CPU-specific code out of #ifdef to unguarded static initialization, etc. And it doesn't seem to even particularly improve performance, on my Ryzen2500U for one full column (1m cells) sumArray() takes about 1.6ms with AVX, 1.9ms with SSE2 and 4.6ms with generic code. So SSE2 code is perhaps worth it, especially given that SSE2 is our baseline requirement on x86_64 everywhere and x86 on Windows, but AVX+ is nowhere near worth the trouble. So this code removes all AVX+ code from Calc, and makes SSE2 a hardcoded option on where it's guaranteed. If we raise the baseline to AVX, the SSE2 code may be replaced by the one removed by this commit. Generic code is there for other platforms, if other platforms add CPU-specific code, they should preferably follow the same rules. This does not necessarily mean that CPU-specific code cannot be used at all. Some externals use them, for example. It just needs to be working, maintained, and worth the trouble. Change-Id: I5ab919930df9d0223db68a94bf84947984d313ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129733 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
33 lines
1 KiB
C++
33 lines
1 KiB
C++
#include "functions_test.hxx"
|
|
|
|
class StatisticalFunctionsTest : public FunctionsTest
|
|
{
|
|
public:
|
|
StatisticalFunctionsTest();
|
|
|
|
void testStatisticalFormulasFODS();
|
|
|
|
CPPUNIT_TEST_SUITE(StatisticalFunctionsTest);
|
|
CPPUNIT_TEST(testStatisticalFormulasFODS);
|
|
CPPUNIT_TEST_SUITE_END();
|
|
|
|
};
|
|
|
|
void StatisticalFunctionsTest::testStatisticalFormulasFODS()
|
|
{
|
|
OUString aDirectoryURL = m_directories.getURLFromSrc(u"/sc/qa/unit/data/functions/statistical/fods/");
|
|
recursiveScan(test::pass, "OpenDocument Spreadsheet Flat XML", aDirectoryURL,
|
|
"com.sun.star.comp.filter.OdfFlatXml,,com.sun.star.comp.Calc.XMLOasisImporter,com.sun.star.comp.Calc.XMLOasisExporter,,,true",
|
|
FODS_FORMAT_TYPE, SotClipboardFormatId::NONE, 0, false);
|
|
}
|
|
|
|
StatisticalFunctionsTest::StatisticalFunctionsTest():
|
|
FunctionsTest("sc/qa/unit/data/functions/statistical/fods/")
|
|
{
|
|
}
|
|
|
|
CPPUNIT_TEST_SUITE_REGISTRATION(StatisticalFunctionsTest);
|
|
|
|
CPPUNIT_PLUGIN_IMPLEMENT();
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|