d1a2b80b9d
...as discussed in the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2020-November/086234.html> "Bump --enable-compiler-plugins Clang baseline?" (and now picked up again at <https://lists.freedesktop.org/archives/libreoffice/2022-February/088459.html> "Re: Bump --enable-compiler-plugins Clang baseline?"), and clean up compilerplugins/clang/ accordingly Change-Id: I5e81c6fdcc363aeefd6227606225b526fdf7ac16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129989 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
84 lines
2 KiB
C++
84 lines
2 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* Based on LLVM/Clang.
|
|
*
|
|
* This file is distributed under the University of Illinois Open Source
|
|
* License. See LICENSE.TXT for details.
|
|
*
|
|
*/
|
|
#ifndef LO_CLANG_SHARED_PLUGINS
|
|
|
|
#include <cassert>
|
|
#include <string>
|
|
#include <iostream>
|
|
#include <fstream>
|
|
#include <set>
|
|
#include <unordered_set>
|
|
#include "plugin.hxx"
|
|
#include "check.hxx"
|
|
|
|
/*
|
|
Check for places where we end up with more than one copy of cppu::OweakObject in a class, which
|
|
really should not happen - we should be using one of the AggImplInheritanceHelper classes then
|
|
to inherit.
|
|
*/
|
|
|
|
namespace
|
|
{
|
|
class WeakObject : public loplugin::FilteringPlugin<WeakObject>
|
|
{
|
|
public:
|
|
explicit WeakObject(loplugin::InstantiationData const& data)
|
|
: FilteringPlugin(data)
|
|
{
|
|
}
|
|
|
|
virtual bool preRun() override
|
|
{
|
|
return true;
|
|
}
|
|
|
|
virtual void run() override
|
|
{
|
|
if (preRun())
|
|
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
|
|
bool VisitCXXRecordDecl( const CXXRecordDecl* decl);
|
|
|
|
};
|
|
|
|
bool WeakObject::VisitCXXRecordDecl(const CXXRecordDecl* decl)
|
|
{
|
|
if (ignoreLocation(decl))
|
|
return true;
|
|
if (!decl->hasDefinition())
|
|
return true;
|
|
if (decl->hasAnyDependentBases())
|
|
return true;
|
|
int cnt = 0;
|
|
decl->forallBases(
|
|
[&cnt] (const CXXRecordDecl *BaseDefinition) -> bool
|
|
{
|
|
if (loplugin::DeclCheck(BaseDefinition).Class("OWeakObject").Namespace("cppu").GlobalNamespace())
|
|
++cnt;
|
|
return true;
|
|
});
|
|
if (cnt < 2)
|
|
return true;
|
|
|
|
report(DiagnosticsEngine::Warning, "more than one copy of cppu::OWeakObject inherited",
|
|
decl->getBeginLoc())
|
|
<< decl->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
loplugin::Plugin::Registration<WeakObject> weakobject("weakobject", false);
|
|
|
|
} // namespace
|
|
|
|
#endif // LO_CLANG_SHARED_PLUGINS
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|