office-gobmx/sc/qa/extras/scdatapilottableobj.cxx
Noel Grandin 5708534b94 look for unnecessary calls to Reference::is() after an UNO_QUERY_THROW
Since the previous call would throw if there was nothing to be assigned
to the value.

Idea from tml.

Used the following script to find places:

    git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()'

Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969
Reviewed-on: https://gerrit.libreoffice.org/55417
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-08 01:29:32 +02:00

155 lines
5.2 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <test/calc_unoapi_test.hxx>
#include <test/container/xnamed.hxx>
#include <test/sheet/xdatapilotdescriptor.hxx>
#include <test/sheet/xdatapilottable.hxx>
#include <test/sheet/xdatapilottable2.hxx>
#include <com/sun/star/lang/XComponent.hpp>
#include <com/sun/star/sheet/XSpreadsheetDocument.hpp>
#include <com/sun/star/sheet/XSpreadsheet.hpp>
#include <com/sun/star/sheet/XDataPilotTablesSupplier.hpp>
#include <com/sun/star/sheet/XDataPilotTables.hpp>
#include <com/sun/star/sheet/XDataPilotTable.hpp>
using namespace css;
using namespace css::uno;
namespace sc_apitest {
class ScDataPilotTableObj : public CalcUnoApiTest,
public apitest::XDataPilotDescriptor,
public apitest::XDataPilotTable,
public apitest::XDataPilotTable2,
public apitest::XNamed
{
public:
ScDataPilotTableObj();
virtual void setUp() override;
virtual void tearDown() override;
virtual uno::Reference< uno::XInterface > init() override;
virtual uno::Reference< uno::XInterface > initDP2() override;
virtual uno::Reference< uno::XInterface > getSheets() override;
CPPUNIT_TEST_SUITE(ScDataPilotTableObj);
// XDataPilotDescriptor
CPPUNIT_TEST(testSourceRange);
CPPUNIT_TEST(testTag);
CPPUNIT_TEST(testGetFilterDescriptor);
CPPUNIT_TEST(testGetDataPilotFields);
CPPUNIT_TEST(testGetColumnFields);
CPPUNIT_TEST(testGetRowFields);
CPPUNIT_TEST(testGetPageFields);
CPPUNIT_TEST(testGetDataFields);
//CPPUNIT_TEST(testGetHiddenFields);
// XDataPilotTable
CPPUNIT_TEST(testGetOutputRange);
CPPUNIT_TEST(testRefresh);
// XDataPilotTable2
CPPUNIT_TEST(testGetDrillDownData);
CPPUNIT_TEST(testInsertDrillDownSheet);
CPPUNIT_TEST(testGetPositionData);
CPPUNIT_TEST(testGetOutputRangeByType);
// XNamed
CPPUNIT_TEST(testGetName);
CPPUNIT_TEST(testSetName);
CPPUNIT_TEST_SUITE_END();
private:
uno::Reference< lang::XComponent > mxComponent;
};
ScDataPilotTableObj::ScDataPilotTableObj()
: CalcUnoApiTest("/sc/qa/extras/testdocuments"),
apitest::XNamed("DataPilotTable")
{
}
uno::Reference< uno::XInterface > ScDataPilotTableObj::init()
{
uno::Reference< sheet::XSpreadsheetDocument > xDoc(mxComponent, UNO_QUERY_THROW);
uno::Reference< container::XIndexAccess > xIndex (xDoc->getSheets(), UNO_QUERY_THROW);
uno::Reference< sheet::XSpreadsheet > xSheet( xIndex->getByIndex(0), UNO_QUERY_THROW);
// set variables from xdatapilottable.[ch]xx
xCellForChange = xSheet->getCellByPosition( 1, 5 );
xCellForCheck = xSheet->getCellByPosition( 7, 11 );
CPPUNIT_ASSERT(xCellForCheck.is());
CPPUNIT_ASSERT(xCellForChange.is());
CPPUNIT_ASSERT_MESSAGE("Could not create interface of type XSpreadsheet", xSheet.is());
uno::Reference< sheet::XDataPilotTablesSupplier > xDPTS(xSheet, UNO_QUERY_THROW);
uno::Reference< sheet::XDataPilotTables > xDPT = xDPTS->getDataPilotTables();
CPPUNIT_ASSERT(xDPT.is());
uno::Reference< sheet::XDataPilotTable > xDPTable(xDPT->getByName("DataPilotTable"),UNO_QUERY_THROW);
return xDPTable;
}
uno::Reference< uno::XInterface > ScDataPilotTableObj::getSheets()
{
uno::Reference< sheet::XSpreadsheetDocument > xDoc(mxComponent, UNO_QUERY_THROW);
uno::Reference< uno::XInterface > xSheets(xDoc->getSheets());
return xSheets;
}
uno::Reference< uno::XInterface > ScDataPilotTableObj::initDP2()
{
uno::Reference< sheet::XSpreadsheetDocument > xDoc(mxComponent, UNO_QUERY_THROW);
uno::Reference< container::XIndexAccess > xIndex (xDoc->getSheets(), UNO_QUERY_THROW);
uno::Reference< sheet::XSpreadsheet > xSheet( xIndex->getByIndex(0), UNO_QUERY_THROW);
// set variables from xdatapilottable.[ch]xx
xCellForChange = xSheet->getCellByPosition( 1, 5 );
xCellForCheck = xSheet->getCellByPosition( 7, 11 );
CPPUNIT_ASSERT(xCellForCheck.is());
CPPUNIT_ASSERT(xCellForChange.is());
CPPUNIT_ASSERT_MESSAGE("Could not create interface of type XSpreadsheet", xSheet.is());
uno::Reference< sheet::XDataPilotTablesSupplier > xDPTS(xSheet, UNO_QUERY_THROW);
uno::Reference< sheet::XDataPilotTables > xDPT = xDPTS->getDataPilotTables();
CPPUNIT_ASSERT(xDPT.is());
uno::Reference< sheet::XDataPilotTable > xDPTable(xDPT->getByName("DataPilotTable2"),UNO_QUERY_THROW);
return xDPTable;
}
void ScDataPilotTableObj::setUp()
{
CalcUnoApiTest::setUp();
// create a calc document
OUString aFileURL;
createFileURL("ScDataPilotTableObj.ods", aFileURL);
mxComponent = loadFromDesktop(aFileURL, "com.sun.star.sheet.SpreadsheetDocument");
}
void ScDataPilotTableObj::tearDown()
{
closeDocument(mxComponent);
CalcUnoApiTest::tearDown();
}
CPPUNIT_TEST_SUITE_REGISTRATION(ScDataPilotTableObj);
}
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */