Test repository to check push and ssh key
Find a file
Bogdan Buzea e2479ebd5c tdf#163486: PVS: Identical branches
V1037 Two or more case-branches perform the same actions. Check lines: 944, 957

Change-Id: Ic637d4aa5e6024cc0011e8e51a0fba68c2644378
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175225
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-31 02:03:04 +01:00
.configurations
.git-hooks
.github
.vscode
accessibility a11y: Return early in VCLXAccessibleTabPage::getAccessibleAtPoint 2024-10-28 12:14:10 +01:00
android
animations
apple_remote
avmedia qt: Have just a single toQString(const OUString&) 2024-10-24 09:10:19 +02:00
basctl cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
basegfx
basic cid#1555767 COPY_INSTEAD_OF_MOVE 2024-10-26 19:25:03 +02:00
bean
bin find-unneeded-includes: nicer output with --finderror option 2024-10-28 10:39:41 +01:00
binaryurp
bridges
canvas vcl: move bitmap filter headers into vcl/bitmap global header directory 2024-10-21 09:45:21 +02:00
chart2 UnoApiTest: rename load to loadFromURL and use it everywhere 2024-10-29 09:11:37 +01:00
cli_ure
codemaker
comphelper cid#1556875 COPY_INSTEAD_OF_MOVE 2024-10-26 21:54:56 +02:00
compilerplugins move vcl::DeleteOnDeinit to tools 2024-10-22 08:01:19 +02:00
config_host
configmgr
connectivity cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
cppcanvas cid#1555259 COPY_INSTEAD_OF_MOVE 2024-10-22 17:53:07 +02:00
cppu tdf#163486: PVS: Identical branches 2024-10-23 11:57:15 +02:00
cppuhelper cid#1556875 COPY_INSTEAD_OF_MOVE 2024-10-26 21:54:56 +02:00
cpputools cid#1555171 Data race condition 2024-10-17 20:25:15 +02:00
cui tdf#130857 securityoptionsdialog.ui Define grid children in order 2024-10-30 12:08:23 +01:00
dbaccess UnoApiTest: check mxComponent right after loading 2024-10-29 13:50:40 +01:00
desktop win a11y: Stop using setting to indicate AT support 2024-10-30 08:27:28 +01:00
dictionaries@d375e51d98 Update git submodules 2024-10-29 07:23:05 +01:00
distro-configs
docmodel
drawinglayer cid#1555767 COPY_INSTEAD_OF_MOVE 2024-10-26 19:25:03 +02:00
editeng treat divs as requiring a new block/para 2024-10-29 14:16:37 +01:00
embeddedobj UnoApiTest: rename load to loadFromURL and use it everywhere 2024-10-29 09:11:37 +01:00
embedserv
emfio
eventattacher
extensions cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
external libvisio: upgrade to 0.1.8 2024-10-22 23:48:27 +02:00
extras tdf#87605: Add new words to technical dictionary. 2024-10-20 07:09:19 +02:00
filter UnoApiTest: rename load to loadFromURL and use it everywhere 2024-10-29 09:11:37 +01:00
forms cid#1555767 COPY_INSTEAD_OF_MOVE 2024-10-26 19:25:03 +02:00
formula
fpicker
framework win a11y: Stop using setting to indicate AT support 2024-10-30 08:27:28 +01:00
helpcompiler
helpcontent2@8493c54bdd Update git submodules 2024-10-30 12:59:02 +01:00
hwpfilter tdf#143148: Use pragma once instead of include guards 2024-10-22 14:06:42 +02:00
i18nlangtag tdf#90341 Clean up excessive const_cast'ing 2024-10-23 15:15:38 +02:00
i18npool cid#1555767 COPY_INSTEAD_OF_MOVE 2024-10-26 19:25:03 +02:00
i18nutil tdf#163215: Enable kashida justification for AAT fonts 2024-10-18 21:49:03 +02:00
icon-themes Resolves tdf148513 - Illustration for line break options 2024-10-24 10:04:17 +02:00
idl
idlc/test/parser
include win a11y: Move (Impl)InitAccessBridge logic to only caller 2024-10-30 08:27:36 +01:00
instsetoo_native Adapt to generation of .worker.js files gone from 3.1.68 2024-10-30 13:51:40 +01:00
io cid#1556875 COPY_INSTEAD_OF_MOVE 2024-10-26 21:54:56 +02:00
ios
javaunohelper
jurt
jvmaccess
jvmfwk
l10ntools add Tagalog (tl) langauge- & helppack 2024-10-23 18:22:36 +02:00
librelogo
libreofficekit Don't call std::string::erase with end() 2024-10-30 14:47:26 +01:00
lingucomponent
linguistic cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
lotuswordpro tdf#163486: PVS: Identical branches 2024-10-30 01:43:09 +01:00
m4
msicreator
net_ure
nlpsolver
o3tl
odk
offapi tdf#162262 sc add "Summary below data" option for Subtotal dialog 2024-10-28 13:28:21 +01:00
officecfg tdf#85976 Change label from "Handle Duplicate Records" to "Duplicates" 2024-10-30 19:39:50 +01:00
oovbaapi
oox cid#1556968 COPY_INSTEAD_OF_MOVE 2024-10-29 09:25:43 +01:00
opencl
osx Remove archaic xmerge 2024-10-24 16:28:18 +02:00
package cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
pch
postprocess
pyuno cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
qadevOOo
readlicense_oo update credits 2024-10-29 12:09:50 +01:00
registry
remotebridges
reportbuilder
reportdesign cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
ridljar
sal extract NaN payload test from single unit test 2024-10-17 11:46:34 +02:00
salhelper
sax
sc tdf#163486: PVS: Identical branches 2024-10-31 02:01:31 +01:00
scaddins tdf#163486: PVS: enum type as bool 2024-10-23 15:52:52 +02:00
sccomp
schema
scp2 add Tagalog (tl) langauge- & helppack 2024-10-23 18:22:36 +02:00
scripting cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
sd tdf#163486: PVS: Identical branches 2024-10-31 02:03:04 +01:00
sdext cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
setup_native
sfx2 UnoApiTest: rename load to loadFromURL and use it everywhere 2024-10-29 09:11:37 +01:00
shell
slideshow cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
smoketest
solenv Adapt to generation of .worker.js files gone from 3.1.68 2024-10-30 13:51:40 +01:00
soltools
sot move vcl::DeleteOnDeinit to tools 2024-10-22 08:01:19 +02:00
starmath UnoApiTest: rename load to loadFromURL and use it everywhere 2024-10-29 09:11:37 +01:00
static Adapt to generation of .worker.js files gone from 3.1.68 2024-10-30 13:51:40 +01:00
stoc cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
store cid#1608044 silence Overflowed constant 2024-10-28 21:22:14 +01:00
svgio vcl: move bitmap filter headers into vcl/bitmap global header directory 2024-10-21 09:45:21 +02:00
svl cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
svtools Simplify a bit 2024-10-27 19:43:17 +01:00
svx Fix typo 2024-10-29 10:12:43 +01:00
sw sw: redline changes may try to set broadcast on non PostIt fields 2024-10-30 21:34:31 +01:00
swext
sysui
test Remove duplicated include 2024-10-31 01:57:58 +01:00
testtools cid#1556875 COPY_INSTEAD_OF_MOVE 2024-10-26 21:54:56 +02:00
toolkit cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
tools cid#1606943 Overflowed constant 2024-10-28 18:42:47 +01:00
translations@3afbfbdd5f Update git submodules 2024-10-25 17:45:15 +02:00
ucb cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
ucbhelper cid#1555767 COPY_INSTEAD_OF_MOVE 2024-10-26 19:25:03 +02:00
udkapi
uitest Document LIBO_TEST_DEFAULT_DESKTOP environment variable 2024-10-21 10:48:29 +02:00
UnoControls
unodevtools
unoidl
unoil
unotest
unotools cid#1555789 COPY_INSTEAD_OF_MOVE 2024-10-27 20:19:12 +01:00
unoxml UnoApiTest: rename load to loadFromURL and use it everywhere 2024-10-29 09:11:37 +01:00
ure
uui
vbahelper
vcl Fix typo 2024-10-31 01:58:31 +01:00
winaccessibility Fix typo 2024-10-19 15:52:43 +02:00
wizards tdf#144702 Base Fields in Report Label Display Clipped 2024-10-23 07:47:34 +02:00
writerperfect tdf#130857 exportepub.ui Define frames in order 2024-10-25 18:44:41 +02:00
xmlhelp
xmloff tdf#163486: PVS: Identical branches 2024-10-30 01:36:46 +01:00
xmlreader
xmlscript cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
xmlsecurity UnoApiTest: rename load to loadFromURL and use it everywhere 2024-10-29 09:11:37 +01:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
.vsconfig
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in Adapt to generation of .worker.js files gone from 3.1.68 2024-10-30 13:51:40 +01:00
config_host_lang.mk.in
configure.ac Adapt to generation of .worker.js files gone from 3.1.68 2024-10-30 13:51:40 +01:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint
download.lst xmlsec: upgrade to 1.3.6 2024-10-23 12:47:23 +02:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.help.md
README.md README: mention PVS-Studio 2024-10-18 14:31:08 +02:00
README.Solaris
Repository.mk Remove archaic xmerge 2024-10-24 16:28:18 +02:00
RepositoryExternal.mk don't need to use dlsym for cairo_surface_set_device_scale... 2024-10-17 17:49:07 +02:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk Remove archaic xmerge 2024-10-24 16:28:18 +02:00
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.

SAST Tools

PVS-Studio - static analyzer for C, C++, C#, and Java code.