e57d5daaea
Specifically in sd/source/core/annotations/Annotation.cxx We seem to end up fixing leaks here often. The current tools::JsonWriter API is just very hard to use correctly. So rather return an OString, which is cheap to copy, and push that down into the LOK code. AFAIK that seems to end up requiring less code and less adhoc copying of data (specifically the queueing code in init.cxx was creating copies when converting to std::string). Ideally, we could have some special API to avoid the new strdup() calls in init.cxx, but not sure how to prevent other people from accidentally using that. Change-Id: Ia33437c1bfd9cc2d54dfb99914d1b72db20335f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149963 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> |
||
|---|---|---|
| .. | ||
| classification | ||
| doc | ||
| inc | ||
| qa | ||
| sdi | ||
| source | ||
| uiconfig/ui | ||
| util | ||
| AllLangMoTarget_sfx2.mk | ||
| CppunitTest_sfx2_classification.mk | ||
| CppunitTest_sfx2_controlleritem.mk | ||
| CppunitTest_sfx2_dialogs_test.mk | ||
| CppunitTest_sfx2_doc.mk | ||
| CppunitTest_sfx2_metadatable.mk | ||
| CppunitTest_sfx2_misc.mk | ||
| CppunitTest_sfx2_view.mk | ||
| CustomTarget_classification.mk | ||
| IwyuFilter_sfx2.yaml | ||
| JunitTest_sfx2_complex.mk | ||
| JunitTest_sfx2_unoapi.mk | ||
| Library_sfx.mk | ||
| Makefile | ||
| Module_sfx2.mk | ||
| Package_classification.mk | ||
| PythonTest_sfx2_python.mk | ||
| README.md | ||
| UIConfig_sfx.mk | ||
| UITest_sfx2_doc.mk | ||
Legacy Framework
SFX is the "old" framework, used for historical reasons.
An attempt of documentation of this module is located in [git:sfx2/doc].
It contains base classes for document model, view and controller, used
by "old" applications like sw, sc, sd (while "new" applications
are based on the "new" UNO based framework in "framework").
The SFX framework is based on dispatching slots identified by integers
(SlotIDs) to SfxShells, and there is a dedicated IDL compiler (svidl)
involved that generates C++ slot headers from SDI files in modules' sdi/
subdirectory.
Documentation about SFX dispatch, SDI etc.: https://wiki.openoffice.org/wiki/Framework/Article/Implementation_of_the_Dispatch_API_In_SFX2
Document load/save code is maintained in [git:sfx2/source/doc/docfile.cxx]
SfxMedium class, which handles all the twisty load and save corner cases.
[git:sfx2/source/appl/sfxhelp.cxx] Start procedure for the online
help viewer top level window; handling of help URL creation and
dispatch.
There are also some UNO services here that could really be implemented
anywhere, e.g. the DocumentProperties or DocumentMetadataAccess.
Notable files:
sfx2/source/dialog/backingwindow.cxx Startcenter buttons and the corresponding event handler.