office-gobmx/extensions/source/propctrlr
Michael Weghorn 7247f3ad59 tdf#153343 Show settings for the actual default font in control properties
Since

    commit ea36e0502c
    Date:   Tue Oct 4 12:42:33 2022 +0100

        tdf#150786 use a 'standard' theme for form controls

, form controls in Writer/Calc/Impress documents are
supposed to no longer make use of the system style,
but use style settings independent of the platform
and system style/theme.

Edits in forms actually use the standard font (set
in `ImplStyleData::SetStandardStyles`) by default
since that commit.

However, the font dialog in the control properties
was still showing data for the application default
font that depends on the system style for font
attributes not explicitly set for the control, which
was incorrect and inconsistent with the visual
appearance of the font actually used.

Take `PROPERTY_STANDARD_THEME` introduced in the
above-mentioned commit into account for the dialog
as well when deciding what default font to use.
Add inline comments that the 2 places setting and
making assumptions about the default style of
controls need to be kept in sync.

With this in place, the actually used font height
of 8 (as set in `ImplStyleData::SetStandardStyles`)
is now displayed in the dialog for a newly inserted
edit in Writer instead of something dependent on the
style (e.g. 10 for the kf5 VCL plugin with the Breeze
style in use, or 9 for the qt6 VCL plugin with the Fusion
style).

For the font family, the dialog now shows
"Segoe UI;Tahoma;Arial Unicode MS;Lucida Sans Unicode;DejaVu Sans;Albany AMT;Albany;Arial;Nimbus Sans L;Interface User;Geneva;Dialog;Lucida;Helvetica;Helmet;Interface System;Sans Serif"
(and "This font has not been installed. The closest available
font will be used.") instead of "Noto Sans", which seems a bit
odd, but is presumably "correct" based on the standard style
font. (In order to change that, it would potentially be necessary
to adjust what style settings are set in the
"standard style settings" for controls.)

Change-Id: I1fbee69fdcd6f73a126df64294eb1bcc44078642
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171426
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2024-08-02 18:34:08 +02:00
..
browserline.cxx
browserline.hxx
browserlistbox.cxx
browserlistbox.hxx
browserpage.cxx
browserpage.hxx
browserview.cxx
browserview.hxx
buttonnavigationhandler.cxx
buttonnavigationhandler.hxx
cellbindinghandler.cxx
cellbindinghandler.hxx
cellbindinghelper.cxx
cellbindinghelper.hxx
commoncontrol.cxx
commoncontrol.hxx
composeduiupdate.cxx
composeduiupdate.hxx
controlfontdialog.cxx
controlfontdialog.hxx
controltype.hxx
defaultforminspection.cxx
defaultforminspection.hxx
defaulthelpprovider.cxx
defaulthelpprovider.hxx
editpropertyhandler.cxx
editpropertyhandler.hxx
eformshelper.cxx
eformshelper.hxx
eformspropertyhandler.cxx
eformspropertyhandler.hxx
enumrepresentation.hxx
eventhandler.cxx
eventhandler.hxx
fontdialog.cxx
fontdialog.hxx
formbrowsertools.cxx
formbrowsertools.hxx
formcomponenthandler.cxx
formcomponenthandler.hxx
formcontroller.cxx
formcontroller.hxx
formgeometryhandler.cxx
formlinkdialog.cxx
formlinkdialog.hxx
formmetadata.cxx
formmetadata.hxx
formstrings.hxx
genericpropertyhandler.cxx
genericpropertyhandler.hxx
handlerhelper.cxx
handlerhelper.hxx
inspectorhelpwindow.cxx
inspectorhelpwindow.hxx
inspectormodelbase.cxx
inspectormodelbase.hxx
linedescriptor.hxx
listselectiondlg.cxx
listselectiondlg.hxx
MasterDetailLinkDialog.cxx
MasterDetailLinkDialog.hxx
modulepcr.cxx
modulepcr.hxx
newdatatype.cxx
newdatatype.hxx
objectinspectormodel.cxx
pcr.component
pcrcommon.cxx
pcrcommon.hxx
pcrcommontypes.hxx
pcrstrings.hxx
pcrunodialogs.cxx
pcrunodialogs.hxx
propcontroller.cxx
propcontroller.hxx
propcontrolobserver.hxx
propertycomposer.cxx
propertycomposer.hxx
propertycontrolextender.cxx
propertycontrolextender.hxx
propertyeditor.cxx
propertyeditor.hxx
propertyhandler.cxx
propertyhandler.hxx
propertyinfo.hxx
propeventtranslation.cxx
propeventtranslation.hxx
proplinelistener.hxx
pushbuttonnavigation.cxx
pushbuttonnavigation.hxx
selectlabeldialog.cxx
selectlabeldialog.hxx
sqlcommanddesign.cxx
sqlcommanddesign.hxx
standardcontrol.cxx
standardcontrol.hxx
stringrepresentation.cxx
submissionhandler.cxx
submissionhandler.hxx
taborder.cxx
taborder.hxx
unourl.cxx
unourl.hxx
usercontrol.cxx
usercontrol.hxx
xsddatatypes.cxx
xsddatatypes.hxx
xsdvalidationhelper.cxx
xsdvalidationhelper.hxx
xsdvalidationpropertyhandler.cxx
xsdvalidationpropertyhandler.hxx