office-gobmx/winaccessibility/source/service/msaaservice_impl.cxx
Michael Weghorn 206543c7be [API CHANGE] tdf#150683 a11y: Switch a11y child index to 64 bit
With 16k column support in Calc enabled by default in

    commit 4c5f8ccf0a
    Date:   Tue Mar 8 12:44:49 2022 +0100

        change default Calc number of columns to 16384 (tdf#50916)

, the number of Calc cells in a spreadsheet is larger than
SAL_MAX_INT32, meaning that a 32-bit a11y child index is no more
enough and using it resulted in integer overflows in
methods handling corresponding Calc cells in the a11y layer.
This e.g. had the effect of the Orca and NVDA screen readers
not announcing focused or selected cells properly when their
a11y child index was out of the 32-bit integer range.

Switch the internal a11y child indices to 64 bit to
be able to handle this properly internally.

Since the platform APIs (at least AT-SPI on Linux and
IAccessible2 on Windows; from what I can see LO's macOS
a11y bridge doesn't directly expose the child index)
are still restricted to 32 bit, larger child indices
still cannot be exposed via the platform APIs.

As a consequence, use of the the IAccessible2 and
AT-SPI methods that use the child index remains
problematic in those cases where the child index
is larger. However, as an alternative to using the
AT-SPI Table interface and the IAccessibleTable/
IAccessibleTable2 interfaces with the child index
to retrieve information about a specific cell,
both AT-SPI and IAccessible2 also provide interfaces
to retrieve that information directly
from the cell object (TableCell interface for AT-SPI,
IAccessibleTableCell for IAccessible2).

Those interfaces are already implemented/exposed
for winaccessibility (s. `CAccTable`) and the
qt5/qt6/kf5 VCL plugins (s. the `QAccessibleTableCellInterface`
methods implemented in `QtAccessibleInterface`).
With the switch to 64-bit internal a11y child indices,
these now behave correctly for cells with a child
index that doesn't fit into 32 bit as well.

NVDA on Windows already uses the IAccessibleTableCell
interface and thus announcing focused cells works fine
with this change in place.

Orca on Linux currently doesn't make use of the AT-SPI
TableCell interface yet, but with a suggested change to
do so [1], announcement of selected cells works
with the qt6 VCL plugin with a current qtbase dev branch
as well - when combined with the suggested changes
to implement support for the AT-SPI TableCell interface
in Qt [2] [3] and the LO change based on that [4] and
a fix for a nullptr dereference [5].

The gtk3 VCL plugin doesn't expose the AT-SPI
TableCell interface yet, but once it does so
(via `AtkTableCell`), it also works with the
suggested Orca change [1] in place.
(Adding that is planned for an upcoming change,
works with a local WIP patch.)

For handling return values that are larger than what
platform APIs support, the following approach has
been chosen for now:

1) When the return value is for the count of
(selected) children, the maximum value N
supported by the platform API is returned.
(This is what `ScAccessibleTableBase::getAccessibleChildCount`
did previously.)
The first N elements can be accessed by their
actual (selection) indices.

2) When the return value is the child/cell index,
-2 is returned for objects whose index is greater
than the maximum value supported by the platform
API.
Using a non-negative value would mean that the
index would refer to *another* actually existing
child. A child index of -1 on the other hand
tends to be interpreted as "child is invalid" or
"object isn't actually a child of its (previous)
parent any more)". For the Orca case, this would
result in objects with a child index of -1
not being announced, as they are considered
"zombies" [6].

What's still somewhat problematic is the case where
more than 2^31 children are *selected*, since access
to those children still happens by the index into
the selection in the platform APIs, and not all
selected items are accessible this way.
(Screen readers usually just retrieve
the first and last element from the selection and
announce those.)

Orca already seems to apply different handling for the
case for fully selected rows and columns, so
"All cells selected" or "Columns ... to ... selected"
is announced just fine even if more than 2^31
cells are selected.

(Side note: While Microsoft User Interface
Automation - UIA - also uses 32-bit indices, it also
has specific methods in the ISelectionProvider2
interface that allow to explicitly retrieve the
first and last selected item,
`ISelectionProvider2::get_FirstSelectedItem` and
`ISelectionProvider2::get_LastSelectedItem`, but
we currently don't support UIA on Windows.)

Bound checks at the beginning of the methods from the
`XAccessibleContext`, `XAccessibleSelection` and
`XAccessibleTable` interfaces that take a child index
(or in helper methods called by those) should generally
already prevent too large indices from being passed to
the methods in the lower layer code that take smaller
integer types. Such bound checking has been
been added in various places where it wasn't present yet.
If there any remaining issues of this
kind that show after this commit, they can probably be
solved in a similar way (s.e.g. the change to
`AccessibleBrowseBox::getAccessibleChild` in this
commit).
A few asserts were also added at
places where my understanding is that values shouldn't
be larger than what is supported by a called method
anyway.

A test case will be added in a following change.

[1] https://gitlab.gnome.org/GNOME/orca/-/merge_requests/131
[2] https://codereview.qt-project.org/c/qt/qtbase/+/428566
[3] https://codereview.qt-project.org/c/qt/qtbase/+/428567
[4] https://gerrit.libreoffice.org/c/core/+/138750
[5] https://codereview.qt-project.org/c/qt/qtbase/+/430157
[6] 82c8542002/src/orca/script_utilities.py (L5155)

Change-Id: I3af590c988b0e6754fc72545918412f39e8fea07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139258
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-09-02 15:47:37 +02:00

275 lines
9.7 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#include <rtl/ref.hxx>
#include <sal/log.hxx>
#include <cppuhelper/implbase.hxx>
#include <cppuhelper/factory.hxx>
#include <cppuhelper/implementationentry.hxx>
#include <cppuhelper/supportsservice.hxx>
#include <com/sun/star/lang/XServiceInfo.hpp>
#include <com/sun/star/accessibility/XMSAAService.hpp>
#include <com/sun/star/accessibility/AccessibleRole.hpp>
#include <com/sun/star/awt/XExtendedToolkit.hpp>
#include <vcl/svapp.hxx>
#include <vcl/window.hxx>
#include <prewin.h>
#include <postwin.h>
using namespace ::com::sun::star; // for odk interfaces
using namespace ::com::sun::star::uno; // for basic types
using namespace ::com::sun::star::accessibility;
using namespace ::com::sun::star::awt;
#include <AccTopWindowListener.hxx>
namespace my_sc_impl
{
namespace {
class MSAAServiceImpl : public ::cppu::WeakImplHelper<
XMSAAService, lang::XServiceInfo >
{
private:
rtl::Reference<AccTopWindowListener> m_pTopWindowListener;
public:
MSAAServiceImpl ();
// XComponent - as used by VCL to lifecycle manage this bridge.
virtual void SAL_CALL dispose() override;
virtual void SAL_CALL addEventListener( const css::uno::Reference< css::lang::XEventListener >& ) override
{ /* dummy */ }
virtual void SAL_CALL removeEventListener( const css::uno::Reference< css::lang::XEventListener >& ) override
{ /* dummy */ }
// XMSAAService
virtual sal_Int64 SAL_CALL getAccObjectPtr(
sal_Int64 hWnd, sal_Int64 lParam, sal_Int64 wParam) override;
virtual void SAL_CALL handleWindowOpened(sal_Int64) override;
// XServiceInfo
virtual OUString SAL_CALL getImplementationName() override;
virtual sal_Bool SAL_CALL supportsService( OUString const & serviceName ) override;
virtual Sequence< OUString > SAL_CALL getSupportedServiceNames() override;
};
}
/**
* Implementation of getAccObjectPtr.
* @param
* @return Com interface.
*/
sal_Int64 MSAAServiceImpl::getAccObjectPtr(
sal_Int64 hWnd, sal_Int64 lParam, sal_Int64 wParam)
{
SolarMutexGuard g;
if (!m_pTopWindowListener.is())
{
return 0;
}
return m_pTopWindowListener->GetMSComPtr(hWnd, lParam, wParam);
}
/**
* Implementation of handleWindowOpened, the method will be invoked when a
* top window is opened and AT starts up.
* @param
* @return
*/
void MSAAServiceImpl::handleWindowOpened(sal_Int64 nAcc)
{
SolarMutexGuard g;
SAL_INFO( "iacc2", "Window opened " << nAcc );
if (m_pTopWindowListener.is() && nAcc)
{
m_pTopWindowListener->HandleWindowOpened(
static_cast<css::accessibility::XAccessible*>(
reinterpret_cast<void*>(nAcc)));
}
}
OUString MSAAServiceImpl::getImplementationName()
{
return "com.sun.star.accessibility.my_sc_implementation.MSAAService";
}
/**
* Implementation of XServiceInfo, return support service name.
* @param Service name.
* @return If the service name is supported.
*/
sal_Bool MSAAServiceImpl::supportsService( OUString const & serviceName )
{
return cppu::supportsService(this, serviceName);
}
/**
* Implementation of XServiceInfo, return all service names.
* @param.
* @return service name sequence.
*/
Sequence< OUString > MSAAServiceImpl::getSupportedServiceNames()
{
return { "com.sun.star.accessibility.MSAAService" };
}
static void AccessBridgeHandleExistingWindow(const Reference< XMSAAService > &xAccMgr,
vcl::Window *pWindow, bool bShow)
{
if ( pWindow )
{
css::uno::Reference< css::accessibility::XAccessible > xAccessible;
SAL_INFO( "iacc2", "Decide whether to register existing window with IAccessible2" );
// Test for combo box - drop down floating windows first
vcl::Window * pParentWindow = pWindow->GetParent();
if ( pParentWindow )
{
try
{
// The parent window of a combo box floating window should have the role COMBO_BOX
css::uno::Reference< css::accessibility::XAccessible > xParentAccessible(pParentWindow->GetAccessible());
if ( xParentAccessible.is() )
{
css::uno::Reference< css::accessibility::XAccessibleContext > xParentAC( xParentAccessible->getAccessibleContext() );
if ( xParentAC.is() && (css::accessibility::AccessibleRole::COMBO_BOX == xParentAC->getAccessibleRole()) )
{
// O.k. - this is a combo box floating window corresponding to the child of role LIST of the parent.
// Let's not rely on a specific child order, just search for the child with the role LIST
sal_Int64 nCount = xParentAC->getAccessibleChildCount();
for (sal_Int64 n = 0; (n < nCount) && !xAccessible.is(); n++)
{
css::uno::Reference< css::accessibility::XAccessible > xChild = xParentAC->getAccessibleChild(n);
if ( xChild.is() )
{
css::uno::Reference< css::accessibility::XAccessibleContext > xChildAC = xChild->getAccessibleContext();
if ( xChildAC.is() && (css::accessibility::AccessibleRole::LIST == xChildAC->getAccessibleRole()) )
{
xAccessible = xChild;
}
}
}
}
}
}
catch (css::uno::RuntimeException const&)
{
// Ignore show events that throw DisposedExceptions in getAccessibleContext(),
// but keep revoking these windows in hide(s).
if (bShow)
return;
}
}
// We have to rely on the fact that Window::GetAccessible()->getAccessibleContext() returns a valid XAccessibleContext
// also for other menus than menubar or toplevel popup window. Otherwise we had to traverse the hierarchy to find the
// context object to this menu floater. This makes the call to Window->IsMenuFloatingWindow() obsolete.
if ( ! xAccessible.is() )
xAccessible = pWindow->GetAccessible();
assert( xAccMgr.is() );
if ( xAccessible.is() )
{
xAccMgr->handleWindowOpened(
reinterpret_cast<sal_Int64>(xAccessible.get()));
SAL_INFO( "iacc2", "Decide whether to register existing window with IAccessible2" );
}
}
}
/*
* Setup and notify the OS of Accessible peers for all existing windows.
*/
static void AccessBridgeUpdateOldTopWindows( const Reference< XMSAAService > &xAccMgr )
{
sal_uInt16 nTopWindowCount = static_cast<sal_uInt16>(Application::GetTopWindowCount());
for ( sal_uInt16 i = 0; i < nTopWindowCount; i++ )
{
vcl::Window* pTopWindow = Application::GetTopWindow( i );
css::uno::Reference< css::accessibility::XAccessible > xAccessible = pTopWindow->GetAccessible();
if ( xAccessible.is() )
{
css::uno::Reference< css::accessibility::XAccessibleContext > xAC( xAccessible->getAccessibleContext() );
if ( xAC.is())
{
if ( !xAC->getAccessibleName().isEmpty() )
AccessBridgeHandleExistingWindow( xAccMgr, pTopWindow, true );
}
}
}
}
MSAAServiceImpl::MSAAServiceImpl()
{
Reference< XExtendedToolkit > xToolkit(Application::GetVCLToolkit(), UNO_QUERY);
if( xToolkit.is() )
{
m_pTopWindowListener.set(new AccTopWindowListener());
Reference<XTopWindowListener> const xRef(m_pTopWindowListener);
xToolkit->addTopWindowListener( xRef );
SAL_INFO( "iacc2", "successfully connected to the toolkit event hose" );
}
else
SAL_WARN( "iacc2", "No VCL toolkit interface to listen to for events");
}
void MSAAServiceImpl::dispose()
{
SolarMutexGuard g;
// As all folders and streams contain references to their parents,
// we must remove these references so that they will be deleted when
// the hash_map of the root folder is cleared, releasing all subfolders
// and substreams which in turn release theirs, etc. When xRootFolder is
// released when this destructor completes, the folder tree should be
// deleted fully (and automagically).
m_pTopWindowListener.clear();
}
extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface*
winaccessibility_MSAAServiceImpl_get_implementation(
css::uno::XComponentContext* , css::uno::Sequence<css::uno::Any> const&)
{
Reference< XMSAAService > xAccMgr( new MSAAServiceImpl() );
AccessBridgeUpdateOldTopWindows( xAccMgr );
SAL_INFO("iacc2", "Created new IAccessible2 service impl.");
xAccMgr->acquire();
return xAccMgr.get();
}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */