7f3ca30951
...motivated by <https://gerrit.libreoffice.org/#/c/41565/2> adding dead code at the end of a switch statement, after the last case's "break". -Wunreachable-code appears to work well on Clang, while it appears to have no effect on GCC. Most of the affected places are apparently temporary/TODO/FIXME cases of disabling code via "if (false)", which can be written with an extra set of parentheses as "if ((false))" to silence -Wunreachable-code on Clang (which thus needed loplugin:unnecessaryparen to be adapted accordingly). In some cases, the controlling expression was more complex than just "false" and needed to be rewritten by taking it out of the if statement to silence Clang. One noteworthy case where the nature of the disabled code wasn't immediately apparent: Sep 12 16:59:58 <sberg> quikee, is that "if (false)" in ScExponentialSmoothingDialog::ApplyOutput (sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx) some work-in- progress or dead code? Sep 12 17:02:03 <quikee> sberg: WIP, but you can remove it Sep 12 17:04:47 <sberg> quikee, I'll wrap the false in an extra set of parentheses for now, to silence -Wunreachable-code (I wouldn't want to remove it, as I have no idea whether I should then also remove the "Initial value" comment preceding it) Sep 12 17:07:29 <quikee> sberg: both are different ways to calculate the "intital value"... so no Another case where the nature of the dead code, following while (true) loops without breaks, is unclear is sd/source/ui/remotecontrol/BluetoothServer.cxx, where I added TODO markers to the workarounds that silence the warnings for now. basic/source/sbx/sbxvalue.cxx had a variable of type double, of automatic storage duration, and without an initalizer at the top of a switch statement. Clang warning about it is arguably a false positive. Apart from that, this didn't find any cases of genuinely dead code in the existing code base. Change-Id: Ib00b822c8efec94278c048783d5997b8ba86a94c Reviewed-on: https://gerrit.libreoffice.org/42217 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> |
||
|---|---|---|
| .. | ||
| qa | ||
| source | ||
| util | ||
| CppunitTest_cppu_any-external.mk | ||
| CppunitTest_cppu_qa_any.mk | ||
| CppunitTest_cppu_qa_recursion.mk | ||
| CppunitTest_cppu_qa_reference.mk | ||
| CppunitTest_cppu_qa_unotype.mk | ||
| CppunitTest_cppu_test_cppumaker.mk | ||
| InternalUnoApi_cppu_qa_cppumaker_types.mk | ||
| InternalUnoApi_cppu_qa_types.mk | ||
| Library_affine_uno_uno.mk | ||
| Library_cppu.mk | ||
| Library_log_uno_uno.mk | ||
| Library_purpenvhelper.mk | ||
| Library_unsafe_uno_uno.mk | ||
| Makefile | ||
| Module_cppu.mk | ||
| README | ||
Type definitions/implementations for the core of UNO. The exported API is in C. See also: [http://wiki.openoffice.org/wiki/Uno/Binary/Modules/CPPU]