ece698a575
for the ItemInstanceManager the identification was done using typeid/hash_code, but that has problems - it is only defined to be identical for two instances of the same type, but other types can have the same code. Thanks to Noel to find that out, that is not reliable to be used. In the meantime we have SfxItemType to identify Item instances, so I changed the code to use that. The master had five additionally added Items that use the (2a) method of this mechanism (see comments in svl/source/items/globalpool.cxx for that). The gloal is to use as less as possible of this Items in that mechanism, so I checked. For four of these hashing was used, so the mem/runtime aspect is okay -> access is fast enough to prefer mem over runtime. Adding hashed Items (or any other fast mechanism) is always okay. One did not have that (SvxBoxItem) and used just the fallback ItemInstanceManager, so I removed it. We now have 18 Items for which that mechanism is initialized immediately. Noel also already moved the countdown for starting to use the mechanism in case of default handling (case (1), NUMBER_OF_UNSHARED_INSTANCES) to the unorderd_set. someting I had already planned to do, too - thanks! Change-Id: Icf6f427e5ea64672f385357aaad75bb5b7fcbf98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170314 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> |
||
|---|---|---|
| .. | ||
| inc | ||
| qa | ||
| source | ||
| uiconfig/ui | ||
| AllLangMoTarget_editeng.mk | ||
| CppunitTest_editeng_borderline.mk | ||
| CppunitTest_editeng_core.mk | ||
| CppunitTest_editeng_editeng.mk | ||
| CppunitTest_editeng_lookuptree.mk | ||
| CustomTarget_generated.mk | ||
| IwyuFilter_editeng.yaml | ||
| Library_editeng.mk | ||
| Makefile | ||
| Module_editeng.mk | ||
| README.md | ||
| UIConfig_editeng.mk | ||
Edit Engine
In OpenOffice.org build DEV300m72 this module was split off from svx but it
has no dependencies on svx (nor on sfx2) while in turn svx depends on editeng
Read more in the mailing list post: http://www.mail-archive.com/dev@openoffice.org/msg13237.html
If you build LibreOffice with dbgutil, you have some extended debug keys:
- Ctrl+Alt+F1 - draws the paragraph rectangles in different colors
- Ctrl+Alt+F11 - toggles dumping the edit engine state to the "editenginedump.log" on draw
- Ctrl+Alt+F12 - dumps the current edit engine state to "editenginedump.log"