office-gobmx/store/source/store.cxx
Stephan Bergmann f853ec317f Extend loplugin:external to warn about classes
...following up on 314f15bff0 "Extend
loplugin:external to warn about enums".

Cases where free functions were moved into an unnamed namespace along with a
class, to not break ADL, are in:

  filter/source/svg/svgexport.cxx
  sc/source/filter/excel/xelink.cxx
  sc/source/filter/excel/xilink.cxx
  svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx

All other free functions mentioning moved classes appear to be harmless and not
give rise to (silent, even) ADL breakage.  (One remaining TODO in
compilerplugins/clang/external.cxx is that derived classes are not covered by
computeAffectedTypes, even though they could also be affected by ADL-breakage---
but don't seem to be in any acutal case across the code base.)

For friend declarations using elaborate type specifiers, like

  class C1 {};
  class C2 { friend class C1; };

* If C2 (but not C1) is moved into an unnamed namespace, the friend declaration
must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see
C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither
qualified nor a template-id and the declaration is a function or an
elaborated-type-specifier, the lookup to determine whether the entity has been
previously declared shall not consider any scopes outside the innermost
enclosing namespace.")

* If C1 (but not C2) is moved into an unnamed namespace, the friend declaration
must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882>
"elaborated-type-specifier friend not looked up in unnamed namespace".

Apart from that, to keep changes simple and mostly mechanical (which should help
avoid regressions), out-of-line definitions of class members have been left in
the enclosing (named) namespace.  But explicit specializations of class
templates had to be moved into the unnamed namespace to appease
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of
template from unnamed namespace using unqualified-id in enclosing namespace".

Also, accompanying declarations (of e.g. typedefs or static variables) that
could arguably be moved into the unnamed namespace too have been left alone.

And in some cases, mention of affected types in blacklists in other loplugins
needed to be adapted.

And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which
is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is
not moved into an unnamed namespace (because it is declared in
sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is.  GCC warns about
such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler
doesn’t give this warning for types defined in the main .C file, as those are
unlikely to have multiple definitions."
(<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>)  The
warned-about classes also don't have multiple definitions in the given test, so
disable the warning when including the .cxx.

Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4
Reviewed-on: https://gerrit.libreoffice.org/83239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-22 12:57:32 +01:00

424 lines
11 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#include <store/store.h>
#include <sal/types.h>
#include <rtl/string.hxx>
#include <rtl/ref.hxx>
#include "object.hxx"
#include "lockbyte.hxx"
#include "storbase.hxx"
#include "storpage.hxx"
#include "stordir.hxx"
#include "storlckb.hxx"
using rtl::Reference;
namespace store
{
namespace {
/** Template helper class as type safe Reference to store_handle_type.
*/
template<class store_handle_type>
class OStoreHandle : public rtl::Reference<store_handle_type>
{
public:
explicit OStoreHandle (store_handle_type * pHandle)
: rtl::Reference<store_handle_type> (pHandle)
{}
static store_handle_type * SAL_CALL query (void * pHandle)
{
return store::query (
static_cast<OStoreObject*>(pHandle),
static_cast<store_handle_type*>(0));
}
};
}
}
using namespace store;
/*========================================================================
*
* storeHandle implementation.
*
*======================================================================*/
/*
* store_acquireHandle.
*/
storeError store_acquireHandle (
storeHandle Handle
) SAL_THROW_EXTERN_C()
{
OStoreObject *pHandle = static_cast<OStoreObject*>(Handle);
if (!pHandle)
return store_E_InvalidHandle;
pHandle->acquire();
return store_E_None;
}
/*
* store_releaseHandle.
*/
storeError store_releaseHandle (
storeHandle Handle
) SAL_THROW_EXTERN_C()
{
OStoreObject *pHandle = static_cast<OStoreObject*>(Handle);
if (!pHandle)
return store_E_InvalidHandle;
pHandle->release();
return store_E_None;
}
/*========================================================================
*
* storeFileHandle implementation.
*
*======================================================================*/
/*
* store_createMemoryFile.
*/
storeError store_createMemoryFile (
sal_uInt16 nPageSize,
storeFileHandle *phFile
) SAL_THROW_EXTERN_C()
{
if (!phFile)
return store_E_InvalidParameter;
*phFile = nullptr;
Reference<ILockBytes> xLockBytes;
storeError eErrCode = MemoryLockBytes_createInstance(xLockBytes);
if (eErrCode != store_E_None)
return eErrCode;
OSL_ASSERT(xLockBytes.is());
Reference<OStorePageManager> xManager (new OStorePageManager());
if (!xManager.is())
return store_E_OutOfMemory;
eErrCode = xManager->initialize (
&*xLockBytes, storeAccessMode::Create, nPageSize);
if (eErrCode != store_E_None)
return eErrCode;
xManager->acquire();
*phFile = xManager.get();
return store_E_None;
}
/*
* store_openFile.
*/
storeError store_openFile (
rtl_uString *pFilename,
storeAccessMode eAccessMode,
sal_uInt16 nPageSize,
storeFileHandle *phFile
) SAL_THROW_EXTERN_C()
{
if (phFile)
*phFile = nullptr;
if (!(pFilename && phFile))
return store_E_InvalidParameter;
Reference<ILockBytes> xLockBytes;
storeError eErrCode = FileLockBytes_createInstance (xLockBytes, pFilename, eAccessMode);
if (eErrCode != store_E_None)
return eErrCode;
OSL_ASSERT(xLockBytes.is());
Reference<OStorePageManager> xManager (new OStorePageManager());
if (!xManager.is())
return store_E_OutOfMemory;
eErrCode = xManager->initialize (
&*xLockBytes, eAccessMode, nPageSize);
if (eErrCode != store_E_None)
return eErrCode;
xManager->acquire();
*phFile = xManager.get();
return store_E_None;
}
/*
* store_closeFile.
*/
storeError store_closeFile (
storeFileHandle Handle
) SAL_THROW_EXTERN_C()
{
OStorePageManager *pManager =
OStoreHandle<OStorePageManager>::query (Handle);
if (!pManager)
return store_E_InvalidHandle;
storeError eErrCode = pManager->close();
pManager->release();
return eErrCode;
}
/*
* store_flushFile.
*/
storeError store_flushFile (
storeFileHandle Handle
) SAL_THROW_EXTERN_C()
{
OStoreHandle<OStorePageManager> xManager (
OStoreHandle<OStorePageManager>::query (Handle));
if (!xManager.is())
return store_E_InvalidHandle;
return xManager->flush();
}
/*========================================================================
*
* storeDirectoryHandle implementation.
*
*======================================================================*/
/*
* store_openDirectory.
*/
storeError store_openDirectory (
storeFileHandle hFile,
rtl_uString const *pPath,
rtl_uString const *pName,
storeAccessMode eAccessMode,
storeDirectoryHandle *phDirectory
) SAL_THROW_EXTERN_C()
{
storeError eErrCode = store_E_None;
if (phDirectory)
*phDirectory = nullptr;
OStoreHandle<OStorePageManager> xManager (
OStoreHandle<OStorePageManager>::query (hFile));
if (!xManager.is())
return store_E_InvalidHandle;
if (!(pPath && pName && phDirectory))
return store_E_InvalidParameter;
Reference<OStoreDirectory_Impl> xDirectory (new OStoreDirectory_Impl());
if (!xDirectory.is())
return store_E_OutOfMemory;
OString aPath (pPath->buffer, pPath->length, RTL_TEXTENCODING_UTF8);
OString aName (pName->buffer, pName->length, RTL_TEXTENCODING_UTF8);
eErrCode = xDirectory->create (&*xManager, aPath.pData, aName.pData, eAccessMode);
if (eErrCode != store_E_None)
return eErrCode;
xDirectory->acquire();
*phDirectory = xDirectory.get();
return store_E_None;
}
/*
* store_findFirst.
*/
storeError store_findFirst (
storeDirectoryHandle Handle,
storeFindData *pFindData
) SAL_THROW_EXTERN_C()
{
OStoreHandle<OStoreDirectory_Impl> xDirectory (
OStoreHandle<OStoreDirectory_Impl>::query (Handle));
if (!xDirectory.is())
return store_E_InvalidHandle;
if (!pFindData)
return store_E_InvalidParameter;
// Initialize FindData.
memset (pFindData, 0, sizeof (storeFindData));
// Find first.
pFindData->m_nReserved = sal_uInt32(~0);
return xDirectory->iterate (*pFindData);
}
/*
* store_findNext.
*/
storeError store_findNext (
storeDirectoryHandle Handle,
storeFindData *pFindData
) SAL_THROW_EXTERN_C()
{
OStoreHandle<OStoreDirectory_Impl> xDirectory (
OStoreHandle<OStoreDirectory_Impl>::query (Handle));
if (!xDirectory.is())
return store_E_InvalidHandle;
if (!pFindData)
return store_E_InvalidParameter;
// Check FindData.
if (!pFindData->m_nReserved)
return store_E_NoMoreFiles;
// Find next.
pFindData->m_nReserved -= 1;
return xDirectory->iterate (*pFindData);
}
/*========================================================================
*
* storeStreamHandle implementation.
*
*======================================================================*/
/*
* store_openStream
*/
storeError store_openStream (
storeFileHandle hFile,
rtl_uString const *pPath,
rtl_uString const *pName,
storeAccessMode eAccessMode,
storeStreamHandle *phStream
) SAL_THROW_EXTERN_C()
{
storeError eErrCode = store_E_None;
if (phStream)
*phStream = nullptr;
OStoreHandle<OStorePageManager> xManager (
OStoreHandle<OStorePageManager>::query (hFile));
if (!xManager.is())
return store_E_InvalidHandle;
if (!(pPath && pName && phStream))
return store_E_InvalidParameter;
Reference<OStoreLockBytes> xLockBytes (new OStoreLockBytes());
if (!xLockBytes.is())
return store_E_OutOfMemory;
OString aPath (pPath->buffer, pPath->length, RTL_TEXTENCODING_UTF8);
OString aName (pName->buffer, pName->length, RTL_TEXTENCODING_UTF8);
eErrCode = xLockBytes->create (&*xManager, aPath.pData, aName.pData, eAccessMode);
if (eErrCode != store_E_None)
return eErrCode;
xLockBytes->acquire();
*phStream = xLockBytes.get();
return store_E_None;
}
/*
* store_readStream.
*/
storeError store_readStream (
storeStreamHandle Handle,
sal_uInt32 nOffset,
void *pBuffer,
sal_uInt32 nBytes,
sal_uInt32 *pnDone
) SAL_THROW_EXTERN_C()
{
OStoreHandle<OStoreLockBytes> xLockBytes (
OStoreHandle<OStoreLockBytes>::query (Handle));
if (!xLockBytes.is())
return store_E_InvalidHandle;
if (!(pBuffer && pnDone))
return store_E_InvalidParameter;
return xLockBytes->readAt (nOffset, pBuffer, nBytes, *pnDone);
}
/*
* store_writeStream.
*/
storeError store_writeStream (
storeStreamHandle Handle,
sal_uInt32 nOffset,
const void *pBuffer,
sal_uInt32 nBytes,
sal_uInt32 *pnDone
) SAL_THROW_EXTERN_C()
{
OStoreHandle<OStoreLockBytes> xLockBytes (
OStoreHandle<OStoreLockBytes>::query (Handle));
if (!xLockBytes.is())
return store_E_InvalidHandle;
if (!(pBuffer && pnDone))
return store_E_InvalidParameter;
return xLockBytes->writeAt (nOffset, pBuffer, nBytes, *pnDone);
}
/*
* store_remove.
*/
storeError store_remove (
storeFileHandle Handle,
rtl_uString const *pPath,
rtl_uString const *pName
) SAL_THROW_EXTERN_C()
{
storeError eErrCode = store_E_None;
OStoreHandle<OStorePageManager> xManager (
OStoreHandle<OStorePageManager>::query (Handle));
if (!xManager.is())
return store_E_InvalidHandle;
if (!(pPath && pName))
return store_E_InvalidParameter;
// Setup page key.
OString aPath (pPath->buffer, pPath->length, RTL_TEXTENCODING_UTF8);
OString aName (pName->buffer, pName->length, RTL_TEXTENCODING_UTF8);
OStorePageKey aKey;
eErrCode = OStorePageManager::namei (aPath.pData, aName.pData, aKey);
if (eErrCode != store_E_None)
return eErrCode;
// Remove.
return xManager->remove (aKey);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */