strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
office-gobmx/cppu
History
Stephan Bergmann a0bc388b38 Use the saner std::condition_variable semantics for JobQueue::m_cndWait 
This avoids the need for the tricky osl::Condition::reset calls.  For example,
the first one (in the "disposed !" case) had been added with
2a3ed89284 "sb132: #i112448# proper clean up in
JobQueue::enter (patch by olistraub)" as

>                  if( 0 == m_lstCallstack.front() )
>                  {
>                      // disposed !
> +                    if( m_lstJob.empty() )
> +                    {
> +                        osl_resetCondition( m_cndWait );
> +                    }
>                      break;
>                  }
>

and then change to

>                  if( 0 == m_lstCallstack.front() )
>                  {
>                      // disposed !
> -                    if( m_lstJob.empty() )
> +                    if( m_lstJob.empty()
> +                        && (m_lstCallstack.empty()
> +                            || m_lstCallstack.front() != 0) )
>                      {
>                          osl_resetCondition( m_cndWait );
>                      }

with cba3ac1eab "Avoid deadlocks when disposing
recursive JobQueue::enter", which prevented the reset from ever hapening
(because m_lstCallstack.front() cannot both be zero and non-zero here at the
same time).  The std::condition_variable semantics nicely avoid any reasoning
whether or not a reset would be necessary here.

Change-Id: Ic9b57b836bb6679829f4aa3b68679256726acf60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96406
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-16 10:02:24 +02:00
..
qa tdf#115399: Don't kill pre-existing typelib_TypeDescription members 2020-04-28 15:07:45 +02:00
source Use the saner std::condition_variable semantics for JobQueue::m_cndWait 2020-06-16 10:02:24 +02:00
util
CppunitTest_cppu_any-external.mk
CppunitTest_cppu_qa_any.mk
CppunitTest_cppu_qa_recursion.mk
CppunitTest_cppu_qa_reference.mk
CppunitTest_cppu_qa_unotype.mk
CppunitTest_cppu_test_cppumaker.mk
CppunitTest_cppu_typelib.mk tdf#115399: Don't kill pre-existing typelib_TypeDescription members 2020-04-28 15:07:45 +02:00
InternalUnoApi_cppu_qa_cppumaker_types.mk
InternalUnoApi_cppu_qa_types.mk
IwyuFilter_cppu.yaml
Library_affine_uno_uno.mk
Library_cppu.mk
Library_log_uno_uno.mk
Library_purpenvhelper.mk
Library_unsafe_uno_uno.mk
Makefile
Module_cppu.mk tdf#115399: Don't kill pre-existing typelib_TypeDescription members 2020-04-28 15:07:45 +02:00
README

README 

Type definitions/implementations for the core of UNO. The exported API is in C.

See also:
[http://wiki.openoffice.org/wiki/Uno/Binary/Modules/CPPU]