office-gobmx/svx
Caolán McNamara 12e468a606 cid#1516651 Dereference after null check
Change-Id: I0f4586538a672426cbfe60d1e589778741b08dbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142338
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-05 22:13:43 +01:00
..
doc
inc tdf#151114: Improve styles preview alignment 2022-10-01 13:29:50 +02:00
qa UnoApiXmlTest: add new wrapper for XmlTestTools tests 2022-11-03 16:21:57 +01:00
sdi sw: add FN_PARA_1 to MAILPREPAREEXPORT slot 2022-11-04 08:33:18 +01:00
source cid#1516651 Dereference after null check 2022-11-05 22:13:43 +01:00
uiconfig/ui tdf#148017 harmonize sidebar .ui files 2022-10-17 19:15:50 +02:00
util WASM --enable-wasm-strip now skips lots of LO code 2022-01-20 12:28:54 +01:00
AllLangMoTarget_svx.mk
CppunitTest_svx_core.mk CppunitTest_svx_core: inherit from UnoApiTest 2022-11-01 11:09:55 +01:00
CppunitTest_svx_dialogs_test.mk
CppunitTest_svx_gallery_test.mk
CppunitTest_svx_removewhichrange.mk Separate core drawinglayer func. into drawinglayercore library 2021-12-22 12:10:10 +01:00
CppunitTest_svx_styles.mk CppunitTest_svx_styles: inherit from UnoApiTest 2022-11-01 13:13:43 +01:00
CppunitTest_svx_unit.mk CppunitTest_svx_unit: inherit from UnoApiTest 2022-11-01 10:55:18 +01:00
Executable_gengal.mk Drop support for OpenGL denylist on X11 2022-03-28 14:31:07 +02:00
IwyuFilter_svx.yaml Recheck modules sv* with IWYU 2022-03-03 09:50:43 +01:00
JunitTest_svx_unoapi.mk
Library_svx.mk WASM --enable-wasm-strip now skips lots of LO code 2022-01-20 12:28:54 +01:00
Library_svxcore.mk WASM add Calc as optional build result, make it build & run 2022-10-14 09:21:30 +02:00
Library_textconversiondlgs.mk Generally determine Rdb content from gb_*_set_componentfile calls 2021-12-10 08:14:24 +01:00
Makefile
Module_svx.mk gbuild: implement static partial build 2022-01-13 12:13:06 +01:00
Package_gengal.mk
README.md svx: fix URL and class name in README 2022-03-01 08:19:01 +01:00
UIConfig_svx.mk Add graphic size checker for the preferred document DPI 2021-12-20 06:21:34 +01:00
UITest_svx_table.mk

Graphics Related Helper Code

Contains graphics related helper code. Lots of the draw and impress code is in this shared library.

  • xoutdev

    this is where a lot of wht work would happen to move to the canvas. (what does that mean?)

  • svdraw

    transparent gradient stuff. [seriously? surely much more, too]

SdrObject

The shapes you can see in LibreOffice (like rectangle, etc.) are SdrObjects. They are declared as a hierarchy:

SdrObject <- SdrAttrObj <- E3dObject <- E3dCompoundObject <- E3dCubeObj
    ^ ^ ^             ^            ^              | | ^ ^
    | | |             |            |              | | | +--- E3dExtrudeObj
    | | |             |            |              | | +----- E3dLatheObj
    | | |             |            |              | +------- E3dPolygonObj
    | | |             |            |              +--------- E3dSphereObj
    | | |             |            +--- E3dScene...
    | | |             |
    | | |             +--- SdrTextObj <- SdrObjCustomShape...
    | | |                   ^ ^ ^ ^ ^
    | | |                   | | | | +--- SdrEdgeObj...
    | | |                   | | | +----- SdrMeasureObj...
    | | |                   | | +------- SdrPathObj...
    | | |                   | +--------- SdrRectObj...
    | | |                   +----------- SdrTableObj...
    | | +--- SdrObjGroup...
    | + ---- SdrPageObj...
    +------- SdrVirtObj...

The above is incomplete of course.

SdrModel / SdrView

Copied from svdview.hxx:

First of all the app creates a SdrModel. Then it opens a Win and creates a SdrView. ShowSdrPage() announces a page at SdrView. It's possible to show SdrView in any Wins at once.

SdrView can show as many Wins as it wants at once. Pages are announced or checked out with the help of ShowSdrPage()/HideSdrPage(). For every announced page there is a SdrPageView instance in container aPages. If more than one page is showed, you have to pay attention that the offset parameter of ShowSdrPage() is conformed to the size of the page (to prevent overlapping of two pages).

SdrView itself is inherited from many objects in a chain of inheritance (all that starts with SdrPaintView - that is itself inherited from few classes too):

SdrPaintView <- SdrSnapView <- SdrMarkView <- SdrEditView <- SdrPolyEditView
                                                                 ^
+----------------------------------------------------------------+
|
SdrGlueEditView <- SdrObjEditView <- SdrExchangeView <- SdrDragView
                                                                 ^
+----------------------------------------------------------------+
|
SdrCreateView <- SdrView

From SdrView on, it is not flat, but a real hierarchy again.

Drawing Layer / SdrObject(s)

See drawinglayer/README.md for general information about drawinglayer.

Below is the class diagram that comes from https://web.archive.org/web/20160827020830if_/http://www.openoffice.org:80/marketing/ooocon2006/presentations/wednesday_g11.odp slide number 6.

.------- Model --------------.      .------- View -----------------------------------------.
| SdrObject - ViewContact    | 1..* | ViewObjectContact                                    |
|              getChild()    |------|    getPrimitiveList()  -----> Object(s) ---> SdrView |
|              getVOC()      |      |    getRecPrimitiveList()      Contact                |
|              getViewInd... |      |________|_____________________________________________|
| ...ependentPrimitiveList() |               |
|____________________________|            generates
                                             |           ______
                                             V          /      |
                                   .----------------------.    |
                                   | basePrimitive        |    |
                                   |   getRange()         |<---'
                                   |   getDecomposition() |
                                   |______________________|

For SdrObjects, there are own DrawingLayer primitives in svx/source/sdr/primitive2d

The ViewContact / ViewObject / ViewObjectContact are in svx/source/sdr/contact Decomposes the SdrObjects, and does all sort of operations on them.

If the number of visualizable objects (e.g. SdrObjects) is X, and the number of SdrViews is Y, then:

  • there are X ViewContact instances (1:1 relation with a visualizable object)
  • there are Y ObjectContact instances (1:1 relation with an SdrView)
  • there are X*Y ViewObjectContact instances (1:N relation to both visualizable objects and SdrViews)