Test repository to check push and ssh key
Find a file
Miklos Vajna f726fbc269 tdf#151261 DOCX import: fix dropdown SDT when the item display text is missing
Dropdown content controls have list items, and each list item can have a
display text and a value. These are optional, and the bugdoc has a list
item where the value is set, but not the display text.

The trouble is that later in DomainMapper_Impl::PopSdt() we check if the
length of the display texts and values array match and if not, then we
throw away these arrays to avoid creating an inconsistent document
model.

Fix the problem by checking what display text and value we got at the end
of each list item; if any of them is missing, we add an empty string,
which matches the internal representation in SwContentControlListItem.

This also helps in case these array sizes matched by accident, but
display texts and values from different list items were mixed
previously.

Change-Id: Ib1eeabd2479963af4a84d4229d4f0ce4572e0f01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141151
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-10-10 16:05:53 +02:00
.git-hooks
.github
.vscode
accessibility use more string_view in accessibility..configmgr 2022-09-27 13:31:20 +02:00
android
animations
apple_remote
avmedia
basctl use more string_view in accessibility..configmgr 2022-09-27 13:31:20 +02:00
basegfx
basic use more string_view in accessibility..configmgr 2022-09-27 13:31:20 +02:00
bean
bin Drop unused gen-iwyu-dummy-lib.awk script 2022-09-30 08:15:04 +02:00
binaryurp
bridges
canvas
chart2 tdf#151424 Spider web chart drawing error 2022-10-09 13:24:27 +02:00
cli_ure
codemaker
comphelper
compilerplugins unwrap SwDelChr to plain SfxHint 2022-09-25 20:01:53 +02:00
config_host Revert "Use libo_CHECK_SYSTEM_MODULE for eot" 2022-10-01 14:21:28 +02:00
configmgr Revert some string_view pessimization 2022-09-27 19:47:55 +02:00
connectivity split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
cppcanvas
cppu
cppuhelper
cpputools
cui [API CHANGE] Resolves tdf#131136 - Remove option "Use printer metrics" 2022-10-06 18:55:20 +02:00
dbaccess Resolves: tdf#151441 queries don't show any content 2022-10-10 10:26:44 +02:00
desktop split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
dictionaries@0416c229fe Update git submodules 2022-10-05 09:14:13 +02:00
distro-configs
drawinglayer tdf#151104 correct missing ColorModification 2022-09-26 09:49:20 +02:00
editeng Check acor_langtag for language-script fallback instead of only language 2022-10-04 19:15:45 +02:00
embeddedobj split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
embedserv
emfio
eventattacher
extensions tdf#126917 menu: OpenXMLFilterSettings != Macros 2022-10-05 06:59:36 +02:00
external Adapt external/pdfium/gcc-c++20-comparison.patch to P2468R2 2022-10-10 15:00:02 +02:00
extras tdf#139962 make shellnew files 0-bytes 2022-09-25 16:21:15 +02:00
filter related tdf#148806 flatten filter/source/msfilter/msvbahelper.cxx 2022-10-09 01:10:59 +02:00
forms tdf#122319 - Don't allow nullable form components if input is required 2022-10-05 15:31:51 +02:00
formula use more string_view in formula 2022-09-28 11:28:53 +02:00
fpicker
framework tdf#127856: sc: Status bar "languages" when you click... 2022-10-03 15:43:09 +02:00
helpcompiler
helpcontent2@0a4e56a9fa Update git submodules 2022-10-10 15:44:35 +02:00
hwpfilter split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
i18nlangtag Konkani is CTL, the other unknowns are not ("Western") 2022-10-08 23:01:13 +02:00
i18npool Do not use double hyphen in DTD comment to satisfy xmllint 2022-10-06 20:48:05 +02:00
i18nutil Introduce unicode::getScriptClassFromLanguageTag() 2022-10-05 12:05:01 +02:00
icon-themes tdf#151071 Revise Sifr 2022-10-10 13:47:52 +02:00
idl
idlc/test/parser
include tdf#124672 for hicontrast white/black bg select either Sifr vs Sifr Dark 2022-10-08 17:34:34 +02:00
instsetoo_native
io
ios
javaunohelper
jurt
jvmaccess
jvmfwk Fix a misuse of two-argument std string_view rfind 2022-09-23 15:52:21 +02:00
l10ntools
librelogo LibreLogo: fix ast, gug, hsb and sid language support 2022-09-30 14:28:44 +02:00
libreofficekit
lingucomponent
linguistic
lotuswordpro
m4
nlpsolver
o3tl
odk
offapi tdf#148806 doc vba: highest priority is ThisDocument AutoOpen 2022-10-08 16:14:05 +02:00
officecfg [API CHANGE] Resolves tdf#131136 - Remove option "Use printer metrics" 2022-10-06 18:55:20 +02:00
onlineupdate
oovbaapi
oox split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
opencl
osx
package split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
pch
postprocess
pyuno
qadevOOo
readlicense_oo update credits 2022-10-05 19:40:31 +02:00
registry
remotebridges
reportbuilder
reportdesign reportdesign: keep the constant values in a comment 2022-10-05 10:01:14 +02:00
ridljar
sal rtl uuid : remove useless endian conversion 2022-09-27 10:59:22 +02:00
salhelper
sax avoid some ref-counting in a hot path 2022-09-28 11:03:09 +02:00
sc tdf#151429: don't convert OUStrings to system encoding 2022-10-09 00:16:51 +02:00
scaddins Resolves: tdf#151165 Function Wizard: ISODD()/ISEVEN() truncate to integer 2022-09-25 17:39:53 +02:00
sccomp
schema
scp2 tdf#132576 Remove unused template categories 2022-10-01 18:27:56 +02:00
scripting tdf#151076 Create callable Python script using InsertText 2022-10-07 15:13:27 +02:00
sd [API CHANGE] Resolves tdf#131136 - Remove option "Use printer metrics" 2022-10-06 18:55:20 +02:00
sdext
setup_native
sfx2 tdf#150622 sidebar icons empty in High Contrast mode 2022-10-06 17:44:04 +02:00
shell split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
slideshow
smoketest
solenv Revert "android: add Grammar Checker component to native-code.py" 2022-10-06 11:55:05 +02:00
soltools
sot split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
starmath tdf#126917 menu: OpenXMLFilterSettings != Macros 2022-10-05 06:59:36 +02:00
static tdf#151197: Remove EmojiControl 2022-09-29 14:39:17 +02:00
stoc use more string_view in stoc 2022-09-30 13:13:31 +02:00
store
svgio use more string_view in svgio 2022-09-28 16:04:46 +02:00
svl Simplify this code a bit 2022-10-08 15:09:09 +02:00
svtools tdf#148938 Fix position arrows when dragging Calc tabs in dark mode 2022-10-06 06:45:08 +02:00
svx tdf#151417 crash in draw, activating Form controls 2022-10-09 12:09:46 +02:00
sw sw: prefix members of SwOutlineTabDialog, SwSplitTableDlg, ... 2022-10-10 11:55:35 +02:00
swext
sysui Related tdf#132398 - Remove Hicolor Assets for Future Revamping 2022-09-26 17:04:42 +02:00
test [API CHANGE] Resolves tdf#131136 - Remove option "Use printer metrics" 2022-10-06 18:55:20 +02:00
testtools
toolkit tdf#150786 use a 'standard' theme for form controls 2022-10-04 21:17:46 +02:00
tools ofz#52191 Integer-overflow 2022-10-07 15:49:16 +02:00
translations@a06c7f55db Update git submodules 2022-10-10 14:43:38 +02:00
ucb use more string_view in ucb 2022-09-28 16:04:31 +02:00
ucbhelper
udkapi Replace dead langtag.net reference link with Wikipedia and W3C 2022-09-27 22:57:14 +02:00
uitest Use Markdown instead of reStructuredText 2022-09-26 00:26:05 +02:00
UnoControls
unodevtools
unoidl
unoil
unotest split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
unotools [API CHANGE] Resolves tdf#131136 - Remove option "Use printer metrics" 2022-10-06 18:55:20 +02:00
unoxml
ure
uui
vbahelper tdf#148806 doc vba: accept module AutoOpen.Main 2022-10-09 01:07:23 +02:00
vcl vcl: pAnimView to pRenderer (clarify variable name) 2022-10-09 11:27:36 +02:00
winaccessibility tdf#117173 wina11y: Send EVENT_SYSTEM_ALERT when notification shows 2022-09-26 16:15:06 +02:00
wizards
writerfilter tdf#151261 DOCX import: fix dropdown SDT when the item display text is missing 2022-10-10 16:05:53 +02:00
writerperfect tdf#143148 Use pragma once instead of include guards 2022-10-05 11:48:40 +02:00
xmerge
xmlhelp
xmloff split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
xmlreader
xmlscript split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
xmlsecurity split utl::TempFile into fast and named variants 2022-09-29 09:11:18 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in Revert "Use libo_CHECK_SYSTEM_MODULE for eot" 2022-10-01 14:21:28 +02:00
config_host_lang.mk.in
configure.ac Allow building libeot on any platform 2022-10-01 18:14:30 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint
download.lst tdf#144348: Remove EmojiOne Color font 2022-09-27 11:30:44 +02:00
g
hardened_runtime.xcent.in
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
lo.xcent.in
logerrit
Makefile.fetch tdf#144348: Remove EmojiOne Color font 2022-09-27 11:30:44 +02:00
Makefile.gbuild
Makefile.in
README.cross
README.help.md
README.md
README.Solaris
Repository.mk remove obsolete sfx2_emojiconfig from Repository.mk 2022-09-30 21:38:01 +02:00
RepositoryExternal.mk Revert "Use libo_CHECK_SYSTEM_MODULE for eot" 2022-10-01 14:21:28 +02:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.14
    • Build: 11.0 + Xcode 12.5
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 8.0.1 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 11 or later. It is possible to build LibreOffice with JDK version 9, but it is no longer supported by the JDK vendors, thus it should be avoided.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.