Test repository to check push and ssh key
Find a file
Bogdan Buzea f85366c407 tdf#163486: PVS: Identical branches
Since
commit 97075a384a
Author: Michael Brauer <mib@openoffice.org>
Date:   Wed Oct 24 13:16:17 2001 +0000

    #91961#: Support of language

V1037 Two or more case-branches perform the same actions. Check lines: 1462, 1465

Change-Id: Ie27fb47ec7e22b9dbe9a2338c661c261bea8926b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175383
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-22 14:30:26 +02:00
.configurations Fix typo 2024-10-11 14:01:05 +02:00
.git-hooks
.github
.vscode
accessibility cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
android android-viewer translated using Weblate 2024-10-15 17:03:07 +02:00
animations loplugin:ostr avmedia 2024-05-06 15:14:09 +02:00
apple_remote
avmedia Silence -Werror,-Wdeprecated-declarations (macOS 15.0) 2024-09-30 12:07:21 +02:00
basctl tdf#163486: PVS: Identical branches 2024-10-19 19:49:40 +02:00
basegfx cid#1607525 silence Overflowed constant 2024-09-26 13:39:23 +02:00
basic cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
bean
bin find-unneeded-includes: add option to detect IWYU failures 2024-10-18 08:30:41 +02:00
binaryurp cid#1557276 COPY_INSTEAD_OF_MOVE 2024-08-20 21:14:18 +02:00
bridges Fix typo 2024-09-18 16:59:07 +02:00
canvas vcl: move bitmap filter headers into vcl/bitmap global header directory 2024-10-21 09:45:21 +02:00
chart2 cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
cli_ure Only use -Wv:18 in Visual Studio 2019 2024-07-01 11:02:37 +02:00
codemaker cid#1554844 COPY_INSTEAD_OF_MOVE 2024-10-14 15:28:24 +02:00
comphelper Optimize JsonToPropertyValues a bit 2024-10-21 20:28:43 +02:00
compilerplugins move vcl::DeleteOnDeinit to tools 2024-10-22 08:01:19 +02:00
config_host Make --disable-emscripten-proxy-to-pthread configurable 2024-10-10 14:39:24 +02:00
configmgr cid#1554844 COPY_INSTEAD_OF_MOVE 2024-10-14 15:28:24 +02:00
connectivity cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
cppcanvas tdf#163410: fix missing text highlight color for outline text 2024-10-13 20:39:24 +02:00
cppu cid#1555847 COPY_INSTEAD_OF_MOVE 2024-08-22 22:42:37 +02:00
cppuhelper cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
cpputools cid#1555171 Data race condition 2024-10-17 20:25:15 +02:00
cui vcl: move bitmap filter headers into vcl/bitmap global header directory 2024-10-21 09:45:21 +02:00
dbaccess tdf#163486: PVS: Identical branches 2024-10-22 12:09:01 +02:00
desktop tdf#163486: PVS: Identical branches 2024-10-22 12:08:25 +02:00
dictionaries@d0c939181a Update git submodules 2024-10-20 19:23:00 +02:00
distro-configs add a --with-system-java-websocket 2024-09-20 17:43:42 +02:00
docmodel cid#1554709 COPY_INSTEAD_OF_MOVE 2024-07-16 15:13:41 +02:00
drawinglayer move vcl::DeleteOnDeinit to tools 2024-10-22 08:01:19 +02:00
editeng move vcl::DeleteOnDeinit to tools 2024-10-22 08:01:19 +02:00
embeddedobj Avoid deadlock 2024-10-18 11:14:16 +02:00
embedserv Simplify a bit 2024-06-16 08:59:33 +02:00
emfio Use good old string literals in assertXPath and friends 2024-10-05 10:06:44 +02:00
eventattacher loplugin:ostr in various 2024-05-20 22:09:56 +02:00
extensions cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
external ofz#372757014 png_fp_sub Integer-overflow 2024-10-14 09:26:57 +02:00
extras tdf#87605: Add new words to technical dictionary. 2024-10-20 07:09:19 +02:00
filter cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
forms cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
formula tdf#161543 Enhance the searching functionality in FD & FW 2024-09-03 09:59:16 +02:00
fpicker cid#1606833 Overflowed constant 2024-09-16 09:53:43 +02:00
framework cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
helpcompiler cid#1557699 COPY_INSTEAD_OF_MOVE 2024-08-18 11:04:45 +02:00
helpcontent2@b1d8f7ad81 Update git submodules 2024-10-21 10:39:30 +02:00
hwpfilter tdf#143148: Use pragma once instead of include guards 2024-10-22 14:06:42 +02:00
i18nlangtag Add Santali, Ol Chiki {sat-Olck-IN} [0x06B3] to language list 2024-10-14 18:36:38 +02:00
i18npool Move {sat-IN} locale data to {sat-Olck-IN}, tdf#154987 follow-up 2024-10-14 21:58:27 +02:00
i18nutil tdf#163215: Enable kashida justification for AAT fonts 2024-10-18 21:49:03 +02:00
icon-themes tdf#163086 Resize SVG pin icons to 24x24 and clean them up 2024-09-23 06:34:18 +02:00
idl cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
idlc/test/parser
include no need to cache GraphicAttr in SdrGrafObj 2024-10-22 11:44:10 +02:00
instsetoo_native Emscripten: For executables, only build .js files, not .html files 2024-10-10 10:21:42 +02:00
io cid#1608473 Data race condition 2024-10-17 14:37:49 +02:00
ios
javaunohelper loplugin:ostr in javaunohelper 2024-05-09 17:59:45 +02:00
jurt makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo) 2024-05-06 11:40:45 +02:00
jvmaccess Fix typo 2024-07-24 22:36:07 +02:00
jvmfwk cid#1606631 Overflowed constant 2024-10-04 20:30:43 +02:00
l10ntools tdf#163486: PVS: check stream read instead of EOF 2024-10-22 12:43:28 +02:00
librelogo cui, dbaccess, desktop, external, filter, librelogo: fix issues found by 2024-07-27 12:51:55 +02:00
libreofficekit cid#1606773 Check of thread-shared field evades lock acquisition 2024-10-22 11:55:53 +02:00
lingucomponent Optimize a bit: only create std::locale once in parseDudenResponse 2024-10-17 09:12:54 +02:00
linguistic cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
lotuswordpro cid#1608255 silence Overflowed constant 2024-10-21 12:33:48 +02:00
m4
msicreator comphelper, msicreator, odk: fix issues found by Ruff linter 2024-07-27 15:42:26 +02:00
net_ure .NET Bindings: Native bridge for .NET 2024-09-18 08:10:36 +02:00
nlpsolver
o3tl Use good old string literals in assertXPath and friends 2024-10-05 10:06:44 +02:00
odk Drop extra quoting 2024-10-16 15:18:59 +02:00
offapi set master slide name at creation time 2024-10-21 15:48:24 +02:00
officecfg tdf#151941: Show Alt_Shift_P as shortcut key for Page Style 2024-10-21 13:37:29 +02:00
oovbaapi Fix VBA Table's *Padding properties type 2024-06-29 22:47:38 +02:00
oox cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
opencl workaround segfault in compiler on macos-clang-intel 2024-07-25 15:03:36 +02:00
osx
package tdf#163486: PVS: Identical branches 2024-10-22 11:59:59 +02:00
pch
postprocess loplugin:ostr in various 2024-05-20 22:09:56 +02:00
pyuno tdf#163190: [pyuno] SyntaxWarning: invalid escape sequence '\P' 2024-09-29 20:17:13 +02:00
qadevOOo cid#1557158 Unguarded read 2024-09-17 13:23:25 +02:00
readlicense_oo update credits 2024-09-23 13:17:42 +02:00
registry version COVERITY conditionals 2024-10-14 13:07:37 +02:00
remotebridges loplugin:ostr in various 2024-05-20 22:09:56 +02:00
reportbuilder cid#1608462 XML external entity processing enabled 2024-08-04 20:05:02 +02:00
reportdesign cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
ridljar makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
sal extract NaN payload test from single unit test 2024-10-17 11:46:34 +02:00
salhelper Do not try to notify, if the thread is already killed 2024-08-20 11:14:01 +02:00
sax cid#1632259 COPY_INSTEAD_OF_MOVE 2024-10-08 13:16:08 +02:00
sc tdf#163486: PVS: Identical branches 2024-10-22 12:09:48 +02:00
scaddins cid#1608078 Overflowed return value 2024-10-10 07:46:59 +02:00
sccomp Fix typo 2024-10-09 22:41:42 +02:00
schema tdf#162690, tdf#162687: Adapt to ODF 1.4 2024-09-25 19:31:28 +02:00
scp2 tdf#163170 Add support for MS Visio Template format with .vstx extension 2024-09-29 10:04:37 +02:00
scripting cid#1556166 Data race condition 2024-10-03 18:44:28 +02:00
sd lok: fix repeat slideshow after duration issue 2024-10-22 13:29:00 +02:00
sdext cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
setup_native makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
sfx2 tdf#163486: PVS: Identical branches 2024-10-22 11:57:36 +02:00
shell Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
slideshow cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
smoketest cid#1555415 COPY_INSTEAD_OF_MOVE 2024-08-06 09:13:52 +02:00
solenv move vcl::DeleteOnDeinit to tools 2024-10-22 08:01:19 +02:00
soltools
sot move vcl::DeleteOnDeinit to tools 2024-10-22 08:01:19 +02:00
starmath starmath: prefix members of SmSymbolDialog 2024-10-21 17:01:28 +02:00
static Explicitly .delete() one more interface object in uno.js 2024-09-02 10:57:36 +02:00
stoc cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
store cid#1554844 COPY_INSTEAD_OF_MOVE 2024-10-14 15:28:24 +02:00
svgio vcl: move bitmap filter headers into vcl/bitmap global header directory 2024-10-21 09:45:21 +02:00
svl set stylesheet parent at creation time 2024-10-22 08:01:03 +02:00
svtools Make tools::Time ctor taking sal_Int64 private 2024-10-21 10:30:58 +02:00
svx tdf#163486: PVS: Identical branches 2024-10-22 12:14:06 +02:00
sw tdf#163486: PVS: Identical branches 2024-10-22 14:30:26 +02:00
swext makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo) 2024-05-06 11:40:45 +02:00
sysui Adapt to RPM 4.20 2024-09-22 22:26:18 +02:00
test Document LIBO_TEST_DEFAULT_DESKTOP environment variable 2024-10-21 10:48:29 +02:00
testtools cid#1608417 silence deliberate documented Infinite loop 2024-10-06 15:30:51 +02:00
toolkit tdf#163486: PVS: fix copy&paste error 2024-10-20 16:15:52 +02:00
tools move vcl::DeleteOnDeinit to tools 2024-10-22 08:01:19 +02:00
translations@d5e786eb56 Update git submodules 2024-10-04 17:06:42 +02:00
ucb tdf#163486: PVS: The variable was assign the same value. 2024-10-20 10:28:20 +02:00
ucbhelper loplugin:unusedmethods 2024-10-16 15:52:02 +02:00
udkapi
uitest Document LIBO_TEST_DEFAULT_DESKTOP environment variable 2024-10-21 10:48:29 +02:00
UnoControls loplugin:ostr in various 2024-05-20 22:09:56 +02:00
unodevtools cid#1607989 Overflowed constant 2024-09-23 09:32:54 +02:00
unoidl cid#1554844 COPY_INSTEAD_OF_MOVE 2024-10-14 15:28:24 +02:00
unoil .NET Bindings: Switch for old windows CLI bindings 2024-06-22 00:11:16 +02:00
unotest cid#1619687 Not restoring ostream format 2024-09-26 13:39:16 +02:00
unotools Make tools::Time ctor taking sal_Int64 private 2024-10-21 10:30:58 +02:00
unoxml unoxml: port testXProcessingInstruction from java to c++ 2024-10-15 17:37:33 +02:00
ure
uui cool#9956 uui lok: avoid showing the password dialog for now 2024-09-03 11:28:13 +02:00
vbahelper use less exception throwing for flow control 2024-08-13 19:36:37 +02:00
vcl tdf#163486: PVS: Identical branches 2024-10-22 12:14:48 +02:00
winaccessibility Fix typo 2024-10-19 15:52:43 +02:00
wizards scriptforge.pyi - Fix typo 2024-10-18 13:38:18 +02:00
writerperfect fix(lok): Expose the character encoding dialog 2024-10-21 10:34:18 +02:00
xmerge cid#1616070 XML external entity processing enabled 2024-08-09 10:52:57 +02:00
xmlhelp cid#1607687 Overflowed constant 2024-09-28 20:09:32 +02:00
xmloff tdf#163516 Draw fails to restore Layer data Title and Description 2024-10-22 12:37:13 +02:00
xmlreader loplugin:ostr in various 2024-05-20 22:09:56 +02:00
xmlscript cid#1545605 COPY_INSTEAD_OF_MOVE 2024-10-22 11:56:02 +02:00
xmlsecurity Make tools::Time ctor taking sal_Int64 private 2024-10-21 10:30:58 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
.vsconfig winget configuration files for installing Visual Studio Community 2022 2024-10-10 23:49:19 +02:00
antivirusDetection.vbs
autogen.sh wsl-as-helper: fix paths to module/Makefile in builddir!=srcdir case 2024-10-14 19:48:15 +02:00
BUCK
config.guess
config.sub
config_host.mk.in Make --disable-emscripten-proxy-to-pthread configurable 2024-10-10 14:39:24 +02:00
config_host_lang.mk.in
configure.ac configure.ac: Drop bashism 2024-10-17 11:40:37 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint sw: drop DECLARE_FODFEXPORT_TEST macro 2024-10-16 15:28:13 +02:00
download.lst Update pdfium to 6764 2024-10-14 08:11:10 +02:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit
Makefile.fetch Bundle fonts of Google's DocRepair Project 2024-07-05 15:37:11 +02:00
Makefile.gbuild use gb_StaticLibrary_WORKDIR and gb_Library_DLLDIR more consistently 2024-06-19 20:00:39 +02:00
Makefile.in .NET Bindings: Add DotnetTest class to gbuild 2024-08-03 12:07:11 +02:00
README.cross
README.help.md
README.md README: mention PVS-Studio 2024-10-18 14:31:08 +02:00
README.Solaris
Repository.mk add a rtf to pdf fuzzer 2024-09-25 22:28:32 +02:00
RepositoryExternal.mk don't need to use dlsym for cairo_surface_set_device_scale... 2024-10-17 17:49:07 +02:00
RepositoryFixes.mk Emscripten: For executables, only build .js files, not .html files 2024-10-10 10:21:42 +02:00
RepositoryModule_build.mk .NET Bindings: Add DotnetLibrary class to gbuild 2024-06-12 18:48:07 +02:00
RepositoryModule_host.mk .NET Bindings: Add DotnetLibrary class to gbuild 2024-06-12 18:48:07 +02:00
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt update tsan suppressions 2024-07-11 13:04:30 +02:00

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.

SAST Tools

PVS-Studio - static analyzer for C, C++, C#, and Java code.